[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5806: [RUNTIME][String] Overload string operators

[GitBox <gi...@apache.org>]

zhiics commented on a change in pull request #5806:
URL: https://github.com/apache/incubator-tvm/pull/5806#discussion_r440329966



##########
File path: include/tvm/runtime/container.h
##########
@@ -1410,10 +1344,114 @@ inline String& String::operator=(std::string other) {
 
 inline String& String::operator=(const char* other) { return operator=(std::string(other)); }
 
-inline String operator+(const std::string lhs, const String& rhs) {
-  return lhs + rhs.operator std::string();
+template <typename T, typename U,
+          typename = typename std::enable_if<std::is_same<T, String>::value ||
+                                             std::is_same<T, std::string>::value>::type,
+          typename = typename std::enable_if<std::is_same<U, String>::value ||
+                                             (std::is_same<U, std::string>::value &&
+                                              !std::is_same<T, U>::value)>::type>
+inline String operator+(const T& lhs, const U& rhs) {
+  size_t lhs_size = lhs.size();
+  size_t rhs_size = rhs.size();
+  char* concat = new char[lhs_size + rhs_size + 1];
+  std::memcpy(concat, lhs.data(), lhs_size);
+  std::memcpy(concat + lhs_size, rhs.data(), rhs_size);
+  auto ptr = make_object<StringObj>();

Review comment:
       we can probably have a `StringObj::FromCharPtr` for `const char*` and make the constructor use `make_inplace_array`. Currently we just use `std::string` for the `const char*`. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org