You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <re...@gmail.com> on 2013/07/05 21:35:51 UTC
Review Request 12280: Remove anchors for non-nav elements
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12280/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Anchors should be reserved for navigation elements. The table headers are still clickable for sorting but no longer look like anchors.
Eventually all blue text should be navigation links.
Diffs
-----
src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
src/webui/master/static/slave_framework.html 1a38c65c6febeece1a84716951b82066faa9b8be
src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
Diff: https://reviews.apache.org/r/12280/diff/
Testing
-------
Thanks,
Ross Allen
Re: Review Request 12280: Remove anchors for non-nav elements
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12280/#review22820
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On July 5, 2013, 10:16 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12280/
> -----------------------------------------------------------
>
> (Updated July 5, 2013, 10:16 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Anchors should be reserved for navigation elements. The table headers are still clickable for sorting but no longer look like anchors.
>
> Eventually all blue text should be navigation links.
>
>
> Diffs
> -----
>
> src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
> src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
> src/webui/master/static/slave_framework.html 1a38c65c6febeece1a84716951b82066faa9b8be
> src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
>
> Diff: https://reviews.apache.org/r/12280/diff/
>
>
> Testing
> -------
>
> Confirmed columns are still sortable in Chrome + Firefox by clicking column headers.
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12280: Remove anchors for non-nav elements
Posted by Ross Allen <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12280/
-----------------------------------------------------------
(Updated July 5, 2013, 10:16 p.m.)
Review request for mesos.
Repository: mesos
Description
-------
Anchors should be reserved for navigation elements. The table headers are still clickable for sorting but no longer look like anchors.
Eventually all blue text should be navigation links.
Diffs
-----
src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
src/webui/master/static/slave_framework.html 1a38c65c6febeece1a84716951b82066faa9b8be
src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
Diff: https://reviews.apache.org/r/12280/diff/
Testing (updated)
-------
Confirmed columns are still sortable in Chrome + Firefox by clicking column headers.
Thanks,
Ross Allen