You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by ni...@apache.org on 2008/11/11 13:58:53 UTC
svn commit: r713027 - in /activemq/camel/trunk/components/camel-ibatis/src:
main/java/org/apache/camel/component/ibatis/
main/java/org/apache/camel/component/ibatis/strategy/
test/java/org/apache/camel/component/ibatis/
Author: ningjiang
Date: Tue Nov 11 04:58:53 2008
New Revision: 713027
URL: http://svn.apache.org/viewvc?rev=713027&view=rev
Log:
Fixed the CS errors in camel-ibatis
Modified:
activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/IBatisComponent.java
activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/IBatisEndpoint.java
activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/IBatisProducer.java
activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/strategy/DefaultIBatisProcessingStategy.java
activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/strategy/IBatisProcessingStrategy.java
activemq/camel/trunk/components/camel-ibatis/src/test/java/org/apache/camel/component/ibatis/IBatisQueueTest.java
Modified: activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/IBatisComponent.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/IBatisComponent.java?rev=713027&r1=713026&r2=713027&view=diff
==============================================================================
--- activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/IBatisComponent.java (original)
+++ activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/IBatisComponent.java Tue Nov 11 04:58:53 2008
@@ -70,10 +70,10 @@
private String sqlMapConfig = DEFAULT_CONFIG_URI;
private boolean useTransactions = true;
- public IBatisComponent(){
+ public IBatisComponent() {
}
- public IBatisComponent(SqlMapClient sqlMapClient){
+ public IBatisComponent(SqlMapClient sqlMapClient) {
this.sqlMapClient = sqlMapClient;
}
Modified: activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/IBatisEndpoint.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/IBatisEndpoint.java?rev=713027&r1=713026&r2=713027&view=diff
==============================================================================
--- activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/IBatisEndpoint.java (original)
+++ activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/IBatisEndpoint.java Tue Nov 11 04:58:53 2008
@@ -42,7 +42,7 @@
* @version $Revision$
*/
public class IBatisEndpoint extends DefaultPollingEndpoint {
- private static final transient Log logger = LogFactory.getLog(IBatisEndpoint.class);
+ private static final transient Log LOG = LogFactory.getLog(IBatisEndpoint.class);
private IBatisProcessingStrategy strategy;
/**
@@ -156,8 +156,8 @@
if (clazz != null) {
strategy = ObjectHelper.newInstance(clazz, IBatisProcessingStrategy.class);
}
- } catch(Exception e) {
- logger.error("Failed to resolve/create processing strategy (" + name + ")", e);
+ } catch (Exception e) {
+ LOG.error("Failed to resolve/create processing strategy (" + name + ")", e);
throw e;
}
}
Modified: activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/IBatisProducer.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/IBatisProducer.java?rev=713027&r1=713026&r2=713027&view=diff
==============================================================================
--- activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/IBatisProducer.java (original)
+++ activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/IBatisProducer.java Tue Nov 11 04:58:53 2008
@@ -19,14 +19,14 @@
import java.util.Iterator;
import java.util.List;
+import com.ibatis.sqlmap.client.SqlMapClient;
+
import org.apache.camel.Endpoint;
import org.apache.camel.Exchange;
import org.apache.camel.Message;
import org.apache.camel.impl.DefaultProducer;
import org.apache.camel.util.ObjectHelper;
-import com.ibatis.sqlmap.client.SqlMapClient;
-
/**
* @version $Revision$
*/
Modified: activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/strategy/DefaultIBatisProcessingStategy.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/strategy/DefaultIBatisProcessingStategy.java?rev=713027&r1=713026&r2=713027&view=diff
==============================================================================
--- activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/strategy/DefaultIBatisProcessingStategy.java (original)
+++ activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/strategy/DefaultIBatisProcessingStategy.java Tue Nov 11 04:58:53 2008
@@ -19,12 +19,12 @@
import java.sql.Connection;
import java.util.List;
+import com.ibatis.sqlmap.client.SqlMapClient;
+
import org.apache.camel.Exchange;
import org.apache.camel.component.ibatis.IBatisEndpoint;
import org.apache.camel.component.ibatis.IBatisPollingConsumer;
-import com.ibatis.sqlmap.client.SqlMapClient;
-
/**
* Default strategy for consuming messages for a route
*/
@@ -39,14 +39,14 @@
SqlMapClient client = endpoint.getSqlMapClient();
boolean useTrans = endpoint.isUseTransactions();
String[] statements = consumeStatement.split(",");
- try{
- if (useTrans){
+ try {
+ if (useTrans) {
client.startTransaction(Connection.TRANSACTION_REPEATABLE_READ);
}
- for (String statement: statements) {
+ for (String statement : statements) {
client.update(statement.trim(), data);
}
- if (useTrans){
+ if (useTrans) {
client.commitTransaction();
}
} finally {
Modified: activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/strategy/IBatisProcessingStrategy.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/strategy/IBatisProcessingStrategy.java?rev=713027&r1=713026&r2=713027&view=diff
==============================================================================
--- activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/strategy/IBatisProcessingStrategy.java (original)
+++ activemq/camel/trunk/components/camel-ibatis/src/main/java/org/apache/camel/component/ibatis/strategy/IBatisProcessingStrategy.java Tue Nov 11 04:58:53 2008
@@ -23,27 +23,29 @@
import org.apache.camel.component.ibatis.IBatisPollingConsumer;
/**
- * Processing strategy for dealing with IBatis records
- *
+ * Processing strategy for dealing with IBatis records
*/
public interface IBatisProcessingStrategy {
- /**
- * Called when record is being queried.
- * @param consumer The Ibatis Polling Consumer
- * @param endpoint The Ibatis Endpoint
- * @return Results of the query as a java.util.List
- * @throws Exception
- */
- List poll (IBatisPollingConsumer consumer, IBatisEndpoint endpoint) throws Exception;
-
- /**
- * Called if there is a statement to be run after processing
- * @param endpoint The Ibatis Enpoint
- * @param exchange The exchange after it has been processed
- * @param data The original data delivered to the route
- * @param consumeStatement The update statement to run
- * @throws Exception
- */
- void commit(IBatisEndpoint endpoint, Exchange exchange, Object data, String consumeStatement) throws Exception;
+ /**
+ * Called when record is being queried.
+ *
+ * @param consumer The Ibatis Polling Consumer
+ * @param endpoint The Ibatis Endpoint
+ * @return Results of the query as a java.util.List
+ * @throws Exception
+ */
+ List poll(IBatisPollingConsumer consumer, IBatisEndpoint endpoint) throws Exception;
+
+ /**
+ * Called if there is a statement to be run after processing
+ *
+ * @param endpoint The Ibatis Enpoint
+ * @param exchange The exchange after it has been processed
+ * @param data The original data delivered to the route
+ * @param consumeStatement The update statement to run
+ * @throws Exception
+ */
+ void commit(IBatisEndpoint endpoint, Exchange exchange, Object data, String consumeStatement)
+ throws Exception;
}
Modified: activemq/camel/trunk/components/camel-ibatis/src/test/java/org/apache/camel/component/ibatis/IBatisQueueTest.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/components/camel-ibatis/src/test/java/org/apache/camel/component/ibatis/IBatisQueueTest.java?rev=713027&r1=713026&r2=713027&view=diff
==============================================================================
--- activemq/camel/trunk/components/camel-ibatis/src/test/java/org/apache/camel/component/ibatis/IBatisQueueTest.java (original)
+++ activemq/camel/trunk/components/camel-ibatis/src/test/java/org/apache/camel/component/ibatis/IBatisQueueTest.java Tue Nov 11 04:58:53 2008
@@ -26,7 +26,7 @@
public class IBatisQueueTest extends ContextTestSupport {
- public void testConsume() throws Exception {
+ public void testConsume() throws Exception {
MockEndpoint endpoint = getMockEndpoint("mock:results");
endpoint.expectedMinimumMessageCount(2);
@@ -76,7 +76,7 @@
};
}
- @Override
+ @Override
protected void setUp() throws Exception {
super.setUp();
@@ -89,8 +89,8 @@
}
@Override
- protected void tearDown() throws Exception{
- super.tearDown();
+ protected void tearDown() throws Exception {
+ super.tearDown();
IBatisEndpoint endpoint = resolveMandatoryEndpoint("ibatis:Account", IBatisEndpoint.class);
Connection connection = endpoint.getSqlMapClient().getDataSource().getConnection();
Statement statement = connection.createStatement();