You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.com> on 2015/10/07 15:46:12 UTC
Review Request 39086: Fixed typos in comments and docs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39086/
-----------------------------------------------------------
Review request for mesos and Joris Van Remoortere.
Repository: mesos
Description
-------
Fixed typos in comments and docs.
Diffs
-----
docs/fetcher.md 36351a3d0377d1b4523110c299aa7c5f9549506e
include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999
include/mesos/v1/mesos.proto eadbc9d6b097f0652dfc33af28a67eed6631a799
src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf
src/zookeeper/authentication.hpp 5919ec021465cf4f27a51041ff635730d0043eb9
Diff: https://reviews.apache.org/r/39086/diff/
Testing
-------
I only changed comments and docs, but I made sure that "make check" passes on OS X 10.10.5.
Thanks,
Gastón Kleiman
Re: Review Request 39086: Fixed typos in comments and docs.
Posted by Gastón Kleiman <ga...@mesosphere.com>.
> On Oct. 7, 2015, 2:12 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [39086]
> >
> > Failed command: ./support/apply-review.sh -n -r 39086
> >
> > Error:
> > 2015-10-07 14:12:55 URL:https://reviews.apache.org/r/39086/diff/raw/ [5430/5430] -> "39086.patch" [1]
> > Traceback (most recent call last):
> > File "./support/jsonurl.py", line 25, in <module>
> > print data
> > UnicodeEncodeError: 'ascii' codec can't encode character u'\xf3' in position 4: ordinal not in range(128)
> > Successfully applied: Fixed typos in comments and docs.
> >
> > Fixed typos in comments and docs.
> >
> >
> > Review: https://reviews.apache.org/r/39086
> > fatal: empty ident name (for <ga...@mesosphere.com>) not allowed
> > Failed to commit patch
https://reviews.apache.org/r/39087/ should make this patch apply.
- Gastón
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39086/#review101761
-----------------------------------------------------------
On Oct. 7, 2015, 1:46 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39086/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2015, 1:46 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed typos in comments and docs.
>
>
> Diffs
> -----
>
> docs/fetcher.md 36351a3d0377d1b4523110c299aa7c5f9549506e
> include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999
> include/mesos/v1/mesos.proto eadbc9d6b097f0652dfc33af28a67eed6631a799
> src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf
> src/zookeeper/authentication.hpp 5919ec021465cf4f27a51041ff635730d0043eb9
>
> Diff: https://reviews.apache.org/r/39086/diff/
>
>
> Testing
> -------
>
> I only changed comments and docs, but I made sure that "make check" passes on OS X 10.10.5.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 39086: Fixed typos in comments and docs.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39086/#review101761
-----------------------------------------------------------
Bad patch!
Reviews applied: [39086]
Failed command: ./support/apply-review.sh -n -r 39086
Error:
2015-10-07 14:12:55 URL:https://reviews.apache.org/r/39086/diff/raw/ [5430/5430] -> "39086.patch" [1]
Traceback (most recent call last):
File "./support/jsonurl.py", line 25, in <module>
print data
UnicodeEncodeError: 'ascii' codec can't encode character u'\xf3' in position 4: ordinal not in range(128)
Successfully applied: Fixed typos in comments and docs.
Fixed typos in comments and docs.
Review: https://reviews.apache.org/r/39086
fatal: empty ident name (for <ga...@mesosphere.com>) not allowed
Failed to commit patch
- Mesos ReviewBot
On Oct. 7, 2015, 1:46 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39086/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2015, 1:46 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed typos in comments and docs.
>
>
> Diffs
> -----
>
> docs/fetcher.md 36351a3d0377d1b4523110c299aa7c5f9549506e
> include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999
> include/mesos/v1/mesos.proto eadbc9d6b097f0652dfc33af28a67eed6631a799
> src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf
> src/zookeeper/authentication.hpp 5919ec021465cf4f27a51041ff635730d0043eb9
>
> Diff: https://reviews.apache.org/r/39086/diff/
>
>
> Testing
> -------
>
> I only changed comments and docs, but I made sure that "make check" passes on OS X 10.10.5.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 39086: Fixed typos in comments and docs.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39086/#review102169
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Oct. 7, 2015, 1:46 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39086/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2015, 1:46 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed typos in comments and docs.
>
>
> Diffs
> -----
>
> docs/fetcher.md 36351a3d0377d1b4523110c299aa7c5f9549506e
> include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999
> include/mesos/v1/mesos.proto eadbc9d6b097f0652dfc33af28a67eed6631a799
> src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf
> src/zookeeper/authentication.hpp 5919ec021465cf4f27a51041ff635730d0043eb9
>
> Diff: https://reviews.apache.org/r/39086/diff/
>
>
> Testing
> -------
>
> I only changed comments and docs, but I made sure that "make check" passes on OS X 10.10.5.
>
>
> Thanks,
>
> Gastón Kleiman
>
>