You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "sanjeet006py (via GitHub)" <gi...@apache.org> on 2025/04/22 17:36:25 UTC
[PR] Revert: PHOENIX-7006: Configure maxLookbackAge at table level [phoenix]
sanjeet006py opened a new pull request, #2125:
URL: https://github.com/apache/phoenix/pull/2125
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7587: Revert configuring Table level MaxLookBack in syscat [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #2125:
URL: https://github.com/apache/phoenix/pull/2125#issuecomment-2831413231
While for other indexes, we can manually set HBase TableDescriptor level maxLookback config. For CDC index, we usually don't make it as visible as other indexes. I think having a follow-up Jira to set the CDC index TTL at HBase TableDescriptor level from base table maxLookback will be useful, which can be later extended to other indexes also.
WDYT @tkhurana @sanjeet006py?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7587: Revert configuring Table level MaxLookBack in syscat [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #2125:
URL: https://github.com/apache/phoenix/pull/2125#issuecomment-2831430305
Test failures on the build don't seem relevant. This is good to go?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7587: Revert configuring Table level MaxLookBack in syscat [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani merged PR #2125:
URL: https://github.com/apache/phoenix/pull/2125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7587: Revert configuring Table level MaxLookBack in syscat [phoenix]
Posted by "tkhurana (via GitHub)" <gi...@apache.org>.
tkhurana commented on PR #2125:
URL: https://github.com/apache/phoenix/pull/2125#issuecomment-2831437369
We can address the CDC index maxlookback in a separate JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7587: Revert configuring Table level MaxLookBack in syscat [phoenix]
Posted by "sanjeet006py (via GitHub)" <gi...@apache.org>.
sanjeet006py commented on PR #2125:
URL: https://github.com/apache/phoenix/pull/2125#issuecomment-2830735027
> One downside is that maxlookback for indexes is not being inherited from base table. This could be a problem for CDC indexes. We will have to explicitly set maxlookback on indexes.
Yeah, I thought we were fine this limitation while reverting this change.
In general I see two limitations with reverting (noticed these in ITs):
- Indexes are not inheriting table level max lookback and for CDC indexes we need to set it explicitly on a hidden index.
- QueryCompiler doesn't prevent a user from setting SCN lesser than table level max lookback as it doesn't read HBase table attributes.
Shall I create a JIRA for extending setting table level max lookback in HBase table attribute as a complete feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7587: Revert configuring Table level MaxLookBack in syscat [phoenix]
Posted by "sanjeet006py (via GitHub)" <gi...@apache.org>.
sanjeet006py commented on PR #2125:
URL: https://github.com/apache/phoenix/pull/2125#issuecomment-2831468025
@virajjasani we don't need to backport this to 5.2. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7587: Revert configuring Table level MaxLookBack in syscat [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #2125:
URL: https://github.com/apache/phoenix/pull/2125#issuecomment-2829389386
Needs rebase :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7587: Revert configuring Table level MaxLookBack in syscat [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #2125:
URL: https://github.com/apache/phoenix/pull/2125#issuecomment-2831439582
I hope we don't need to backport this to 5.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7587: Revert configuring Table level MaxLookBack in syscat [phoenix]
Posted by "tkhurana (via GitHub)" <gi...@apache.org>.
tkhurana commented on PR #2125:
URL: https://github.com/apache/phoenix/pull/2125#issuecomment-2830688474
One downside is that maxlookback for indexes is not being inherited from base table. This could be a problem for CDC indexes. We will have to explicitly set maxlookback on indexes. @sanjeet006py @virajjasani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org