You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/05/18 20:42:05 UTC

[GitHub] [trafficcontrol] rawlinp commented on a diff in pull request #6213: Remove Traffic Router Profile name restrictions

rawlinp commented on code in PR #6213:
URL: https://github.com/apache/trafficcontrol/pull/6213#discussion_r876353295


##########
traffic_ops/traffic_ops_golang/cdn/dnssecrefresh.go:
##########
@@ -375,7 +375,7 @@ WITH cdn_profile_ids AS (
     MAX(p.id) as profile_id -- We only want 1 profile, so get the probably-newest if there's more than one.
   FROM
     cdn c
-    LEFT JOIN profile p ON c.id = p.cdn AND (p.name like 'CCR%' OR p.name like 'TR%')
+    LEFT JOIN profile p ON c.id = p.cdn AND (p.type = 'TR_PROFILE')

Review Comment:
   We should probably have a constant for `"TR_PROFILE"`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org