[GitHub] [dubbo-go] gaoxinge commented on issue #1167: Imp: disable gRPC EnableTracing

[GitBox <gi...@apache.org>]

gaoxinge commented on issue #1167:
URL: https://github.com/apache/dubbo-go/issues/1167#issuecomment-822953468


   [EnableTracing](https://github.com/grpc/grpc-go/blob/master/trace.go#L35) is a global variable in grpc.
   
   - In grpc, this varialbe is `false` by default.
   - In etcd, this varialbe will be set `true` in server side with debug mode ([[1](https://github.com/etcd-io/etcd/blob/master/server/embed/config_logging.go#L206)], [[2](https://github.com/etcd-io/etcd/blob/master/server/etcdmain/grpc_proxy.go#L170)]).
   
   This variable should be `false` in dubbo-go, because
   
   - dubbo-go do not set it `true` explicitly for tracing and debuging grpc
   - dependent package is responsible to set it `false` by default 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org