[jira] [Created] (FLINK-11167) Optimize RocksDBList#put for no empty input

["Congxian Qiu (JIRA)" <ji...@apache.org>]

Congxian Qiu created FLINK-11167:
------------------------------------

             Summary: Optimize RocksDBList#put for no empty input
                 Key: FLINK-11167
                 URL: https://issues.apache.org/jira/browse/FLINK-11167
             Project: Flink
          Issue Type: Improvement
            Reporter: Congxian Qiu


In `RocksDBListState.putInternal` we will first remove the current state and then add the new list if needed(list is no empty) such as below.

I think if the list is not empty, we could {color:#FF0000}skip the remove operation{color}.

 
{code:java}
public void updateInternal(List<V> values) {
   Preconditions.checkNotNull(values, "List of values to add cannot be null.");

   clear();

   if (!values.isEmpty()) {
      try {
         writeCurrentKeyWithGroupAndNamespace();
         byte[] key = dataOutputView.getCopyOfBuffer();
         byte[] premerge = getPreMergedValue(values, elementSerializer, dataOutputView);
         backend.db.put(columnFamily, writeOptions, key, premerge);
      } catch (IOException | RocksDBException e) {
         throw new FlinkRuntimeException("Error while updating data to RocksDB", e);
      }
   }
}
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)