You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2025/03/07 13:22:57 UTC
[PR] [WIP][SPARK-51437][CORE] Let timeoutCheckingTask could response thread interrupt [spark]
beliefer opened a new pull request, #50211:
URL: https://github.com/apache/spark/pull/50211
### What changes were proposed in this pull request?
This PR proposes to let `timeoutCheckingTask` could response thread interrupt.
### Why are the changes needed?
Currently, we cancel the `timeoutCheckingTask` by specify the `mayInterruptIfRunning` is true.
```
private var timeoutCheckingTask: ScheduledFuture[_] = null
override def onStop(): Unit = {
if (timeoutCheckingTask != null) {
timeoutCheckingTask.cancel(true)
}
eventLoopThread.shutdownNow()
killExecutorThread.shutdownNow()
}
```
But the Runnable cannot response the thread interrupt.
```
timeoutCheckingTask = eventLoopThread.scheduleAtFixedRate(
() => Utils.tryLogNonFatalError { Option(self).foreach(_.ask[Boolean](ExpireDeadHosts)) },
0, checkTimeoutIntervalMs, TimeUnit.MILLISECONDS)
```
### Does this PR introduce _any_ user-facing change?
'No'.
But fix.
### How was this patch tested?
GA.
### Was this patch authored or co-authored using generative AI tooling?
'No'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51437][CORE] Let timeoutCheckingTask could response thread interrupt [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #50211:
URL: https://github.com/apache/spark/pull/50211#issuecomment-2707862706
ping @srowen @dongjoon-hyun @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51437][CORE] Let timeoutCheckingTask could response thread interrupt [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer closed pull request #50211: [SPARK-51437][CORE] Let timeoutCheckingTask could response thread interrupt
URL: https://github.com/apache/spark/pull/50211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51437][CORE] Let timeoutCheckingTask could response thread interrupt [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #50211:
URL: https://github.com/apache/spark/pull/50211#issuecomment-2707940074
I make a mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org