You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/10/11 18:06:07 UTC

[GitHub] [thrift] fishy commented on a diff in pull request #2701: Bump go version to 1.19.2 and update hashes

fishy commented on code in PR #2701:
URL: https://github.com/apache/thrift/pull/2701#discussion_r992637352


##########
go.mod:
##########
@@ -1,5 +1,5 @@
 module github.com/apache/thrift
 
-go 1.18
+go 1.19.2

Review Comment:
   this is wrong:
   1. this cannot include point releases
   2. this is the minimal version of go we support, and we don't want to drop support for go1.18 yet, per our support policy at https://github.com/apache/thrift/blob/master/lib/go/README.md#suppored-go-releases



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org