[GitHub] [trafficcontrol] mitchell852 commented on issue #4058: Inactive tenant - should not be allowed to login with an appropriate message

[GitBox <gi...@apache.org>]

mitchell852 commented on issue #4058: Inactive tenant - should not be allowed to login with an appropriate message
URL: https://github.com/apache/trafficcontrol/issues/4058#issuecomment-548546761
 
 
   I think we need a bigger discussion of what tenant.active=false is supposed to do. Should it:
   
   1. set all child tenants active=false as well?
   2. prevent all users of that tenant from login? or is login restriction to be only determined by role. i.e. role == disallowed is the only way to prevent a user from logging in.
   3. prevent api calls to all tenantable routes of the inactive tenant? Examples:
   
   PUT /deliverservices/42 where 42 is a ds in an inactive tenant return a 400 or something?
   PUT /users/88 where 88 is a user in an inactive tenant return a 400 or something?
   PUT /tenants/22 where 22 is an inactive tenant return a 400 or something?
   
   what should GET /deliveryservices return if I am part of an inactive tenant? empty array or a 400?
   
   The point is, until we determine the intent of tenant.active, it is hard to say what works and what doesn't work.
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services