You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/09/27 06:04:49 UTC
[GitHub] [iceberg] nastra opened a new issue, #5861: Test flakiness: TestManifestCaching > testWeakFileIOReferenceCleanUp
nastra opened a new issue, #5861:
URL: https://github.com/apache/iceberg/issues/5861
### Apache Iceberg version
main (development)
### Query engine
_No response_
### Please describe the bug 🐞
The test itself was introduced with #4518 and failed on latest master in https://github.com/apache/iceberg/actions/runs/3129464949/jobs/5078743589:
I've been running `TestManifestCaching` in a loop and this test failed quite often for me locally
```
TestManifestCaching > testWeakFileIOReferenceCleanUp FAILED
java.lang.AssertionError: expected:<8> but was:<1>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:633)
at org.apache.iceberg.TestManifestCaching.testWeakFileIOReferenceCleanUp(TestManifestCaching.java:182)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rizaon commented on issue #5861: Test flakiness: TestManifestCaching > testWeakFileIOReferenceCleanUp
Posted by GitBox <gi...@apache.org>.
rizaon commented on issue #5861:
URL: https://github.com/apache/iceberg/issues/5861#issuecomment-1259035763
It looks like the assertion in line 182 and 184 might not be true under some corner case scenario (memory pressure). They can be removed since the next assertions in the end of the test is sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] danielcweeks closed issue #5861: Test flakiness: TestManifestCaching > testWeakFileIOReferenceCleanUp
Posted by GitBox <gi...@apache.org>.
danielcweeks closed issue #5861: Test flakiness: TestManifestCaching > testWeakFileIOReferenceCleanUp
URL: https://github.com/apache/iceberg/issues/5861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on issue #5861: Test flakiness: TestManifestCaching > testWeakFileIOReferenceCleanUp
Posted by GitBox <gi...@apache.org>.
nastra commented on issue #5861:
URL: https://github.com/apache/iceberg/issues/5861#issuecomment-1259063150
It looks like even with removing those 2 assertions, the test still fails at `Assert.assertEquals(2, manifestCache.estimatedSize());`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org