You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@twill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/21 20:59:42 UTC

[jira] [Commented] (TWILL-122) Allow disabling the log transport

    [ https://issues.apache.org/jira/browse/TWILL-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935331#comment-15935331 ] 

ASF GitHub Bot commented on TWILL-122:
--------------------------------------

GitHub user chtyim opened a pull request:

    https://github.com/apache/twill/pull/40

    (TWILL-122) Allow disabling log collection

    - Introduced a new configuration twill.log.collection.enabled for
      turning off log collection
    - Refactor YarnTwillController and related class hierarchy to not
      starting Kafka client when log collection is disabled
    - Added Kafka zk connection string information in AM live node data
    - Refactor KafkaAppender and ServiceMain configureLogger
      - Log to StatusManager instead of Logger to avoid recursive logging
      - Instead of resetting logback configuration, directly instantiate and
        add the Kafka log appender to the logging context.
    - Refactor ServiceMain, ApplicationMasterMain and TwillContainerMain to
      simplify ZK Connection string construction

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chtyim/twill feature/TWILL-122

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/twill/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #40
    
----
commit 617280ee72b2e7fc7a3cc473d6dfe35576cf5e57
Author: Terence Yim <ch...@apache.org>
Date:   2017-03-20T21:42:46Z

    (TWILL-122) Allow disabling log collection
    
    - Introduced a new configuration twill.log.collection.enabled for
      turning off log collection
    - Refactor YarnTwillController and related class hierarchy to not
      starting Kafka client when log collection is disabled
    - Added Kafka zk connection string information in AM live node data
    - Refactor KafkaAppender and ServiceMain configureLogger
      - Log to StatusManager instead of Logger to avoid recursive logging
      - Instead of resetting logback configuration, directly instantiate and
        add the Kafka log appender to the logging context.
    - Refactor ServiceMain, ApplicationMasterMain and TwillContainerMain to
      simplify ZK Connection string construction

----


> Allow disabling the log transport
> ---------------------------------
>
>                 Key: TWILL-122
>                 URL: https://issues.apache.org/jira/browse/TWILL-122
>             Project: Apache Twill
>          Issue Type: Improvement
>          Components: core
>            Reporter: Terence Yim
>            Assignee: Terence Yim
>             Fix For: 0.11.0
>
>
> Currently transporting logs to Kafka is mandatory. It should be optionally so that application can have its own way of log collection.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)