You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/20 20:50:19 UTC

[GitHub] [airflow] mattpetersen opened a new pull request #5876: [AIRFLOW-5270] JSONDecodeError in DockerOperator when force_pull

mattpetersen opened a new pull request #5876: [AIRFLOW-5270] JSONDecodeError in DockerOperator when force_pull
URL: https://github.com/apache/airflow/pull/5876
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira]
   https://issues.apache.org/jira/browse/AIRFLOW-5270
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes
   The DockerAPI often returns multiple JSONs within the same line, joined by `\r\n`. If we replace `\r\n` with `\n`, then the response is decoded as expected; otherwise we get "JSONDecodeError"
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason
   
   Happy to add tests if necessary.
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines.
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [X] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services