[GitHub] [incubator-superset] bkyryliuk edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

[GitBox <gi...@apache.org>]

bkyryliuk edited a comment on pull request #9794:
URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-647707780


   > LGTM, but a few minor nits. To avoid being blocked by design efforts, perhaps we could put this behind a feature flag for now so as to not put more strain on UX before the design implications have been properly vetted?
   
   @villebro done, not a feature flag -> but DB level control that allows to add CVAS button to the view.
   From the previous discussions as I understand we agree that feature is useful, the remaining challenge is design & feature representation in UI. That's smth that can be tackled later and I don't think have a good skillset to implement it in this PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org