You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/04 03:30:50 UTC
[GitHub] [airflow] ryanahamilton opened a new pull request #14595: Fix functionality of "Demo Mode", refactor/simplify naming
ryanahamilton opened a new pull request #14595:
URL: https://github.com/apache/airflow/pull/14595
"Demo Mode" wasn't functioning properly (obfuscating sensitive info). This update fixes the implementation so the Tree, Graph, and Code view blur contents as expected.
- Refactored the instrumentation of the "demo mode" to use a global jinja variable instead of repeating individual view variables
- Used more instructive variable naming. eg. `is_demo_mode` instead of `blur`.
_Side note:_ I'm interested in the genesis of this feature, but wasn't able to track down a PR in my initial searching. Curious how widely something like this would actually be used—if it's worth the overhead?
| Before | After |
|---|---|
| <img width="1110" alt="Image 2021-03-03 at 10 16 38 PM" src="https://user-images.githubusercontent.com/3267/109906388-694f8d00-7c6e-11eb-8ecf-1a0d91424ebd.png"> | <img width="1170" alt="Image 2021-03-03 at 10 14 29 PM" src="https://user-images.githubusercontent.com/3267/109906550-b469a000-7c6e-11eb-932c-c4fafd9b3200.png"> |
| Before | After |
|---|---|
| <img width="581" alt="Image 2021-03-03 at 10 16 53 PM" src="https://user-images.githubusercontent.com/3267/109906386-6785c980-7c6e-11eb-896d-f29418387438.png"> | <img width="753" alt="Image 2021-03-03 at 10 14 13 PM" src="https://user-images.githubusercontent.com/3267/109906418-73718b80-7c6e-11eb-8218-cd685f05eab8.png"> |
| Before | After |
|---|---|
| <img width="1246" alt="Image 2021-03-03 at 10 17 10 PM" src="https://user-images.githubusercontent.com/3267/109906380-63f24280-7c6e-11eb-84a2-4677b9bf0db7.png"> | <img width="1303" alt="Image 2021-03-03 at 10 13 56 PM" src="https://user-images.githubusercontent.com/3267/109906425-753b4f00-7c6e-11eb-92d5-a030836b5a2d.png"> |
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14595: Fix functionality of "Demo Mode", refactor/simplify naming
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14595:
URL: https://github.com/apache/airflow/pull/14595#issuecomment-790574870
I wonder if _all_ of the code view should be blurred? Do you know what it was trying to blur before?
For instance the any code of python operators is "sensitive" and probably wanted to be blurred too. (This could be a separate PR.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton closed pull request #14595: Fix functionality of "Demo Mode", refactor/simplify naming
Posted by GitBox <gi...@apache.org>.
ryanahamilton closed pull request #14595:
URL: https://github.com/apache/airflow/pull/14595
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sfc-gh-kbregula commented on pull request #14595: Fix functionality of "Demo Mode", refactor/simplify naming
Posted by GitBox <gi...@apache.org>.
sfc-gh-kbregula commented on pull request #14595:
URL: https://github.com/apache/airflow/pull/14595#issuecomment-790385923
> I'm interested in the genesis of this feature, but wasn't able to track down a PR in my initial searching.
See: https://github.com/apache/airflow/commit/afe1b13236ff6294406c5fe3745a3262b3e7bb66
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14595: Fix functionality of "Demo Mode", refactor/simplify naming
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14595:
URL: https://github.com/apache/airflow/pull/14595#issuecomment-792258244
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] HaloKo4 commented on pull request #14595: Fix functionality of "Demo Mode", refactor/simplify naming
Posted by GitBox <gi...@apache.org>.
HaloKo4 commented on pull request #14595:
URL: https://github.com/apache/airflow/pull/14595#issuecomment-790599526
This is really cool but if the only way to activate it is from airflow.cfg it isn't very convinent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sfc-gh-kbregula edited a comment on pull request #14595: Fix functionality of "Demo Mode", refactor/simplify naming
Posted by GitBox <gi...@apache.org>.
sfc-gh-kbregula edited a comment on pull request #14595:
URL: https://github.com/apache/airflow/pull/14595#issuecomment-790385923
> I'm interested in the genesis of this feature, but wasn't able to track down a PR in my initial searching.
See: https://github.com/apache/airflow/commit/afe1b13236ff6294406c5fe3745a3262b3e7bb66
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sfc-gh-kbregula edited a comment on pull request #14595: Fix functionality of "Demo Mode", refactor/simplify naming
Posted by GitBox <gi...@apache.org>.
sfc-gh-kbregula edited a comment on pull request #14595:
URL: https://github.com/apache/airflow/pull/14595#issuecomment-790385923
> I'm interested in the genesis of this feature, but wasn't able to track down a PR in my initial searching.
See: https://github.com/apache/airflow/commit/afe1b13236ff6294406c5fe3745a3262b3e7bb66
> Curious how widely something like this would actually be used—if it's worth the overhead?
I suspect this is rarely used because we don't have the documentation for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #14595: Fix functionality of "Demo Mode", refactor/simplify naming
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #14595:
URL: https://github.com/apache/airflow/pull/14595#issuecomment-796850429
Closing this PR in favor of #14601 that removes the "demo mode" feature. I put [a call out to the Dev list](https://lists.apache.org/thread.html/ra4da69a77a9fa59dac48b1e5254851e8f79b46a0db8ad735c2d28ef3%40%3Cdev.airflow.apache.org%3E) as a gut check and did not receive any dissenting feedback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14595: Fix functionality of "Demo Mode", refactor/simplify naming
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14595:
URL: https://github.com/apache/airflow/pull/14595#issuecomment-790575714
I think i t was by design that on, for example the Tree view that only the task ids were blurred, but not the tree itself. Ditto on the graph view.
This lets the "structure" be seen clearly without exposing any of the info about what the dag is doing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #14595: Fix functionality of "Demo Mode", refactor/simplify naming
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #14595:
URL: https://github.com/apache/airflow/pull/14595#issuecomment-790586929
This implementation is definitely a "demonstration mode" feature and by no means a security feature. The [description in the config](https://github.com/apache/airflow/blob/master/airflow/config_templates/config.yml/#L1069-L1071):
> Puts the webserver in demonstration mode; blurs the names of Operators for privacy.
Given the lack of documentation and no reports of it being largely broken (for how long?), **I'd advocate for removing it completely**. Would be easy to do now that I've found all of the pieces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sfc-gh-kbregula removed a comment on pull request #14595: Fix functionality of "Demo Mode", refactor/simplify naming
Posted by GitBox <gi...@apache.org>.
sfc-gh-kbregula removed a comment on pull request #14595:
URL: https://github.com/apache/airflow/pull/14595#issuecomment-790385923
> I'm interested in the genesis of this feature, but wasn't able to track down a PR in my initial searching.
See: https://github.com/apache/airflow/commit/afe1b13236ff6294406c5fe3745a3262b3e7bb66
> Curious how widely something like this would actually be used—if it's worth the overhead?
I suspect this is rarely used because we don't have the documentation for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14595: Fix functionality of "Demo Mode", refactor/simplify naming
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14595:
URL: https://github.com/apache/airflow/pull/14595#issuecomment-790573172
I think this was used for producing screenshots for marketing materials, or similar, without exposing internal details of what the DAG does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #14595: Fix functionality of "Demo Mode", refactor/simplify naming
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #14595:
URL: https://github.com/apache/airflow/pull/14595#issuecomment-790387821
> I'm interested in the genesis of this feature, but wasn't able to track down a PR in my initial searching.
See: https://github.com/apache/airflow/commit/afe1b13236ff6294406c5fe3745a3262b3e7bb66
> Curious how widely something like this would actually be used—if it's worth the overhead?
I suspect this is rarely used because we don't have the documentation for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14595: Fix functionality of "Demo Mode", refactor/simplify naming
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14595:
URL: https://github.com/apache/airflow/pull/14595#issuecomment-790581682
https://imageupscaler.com/deblurring 😁
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #14595: Fix functionality of "Demo Mode", refactor/simplify naming
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #14595:
URL: https://github.com/apache/airflow/pull/14595#issuecomment-790659998
I would like to propose that we close this PR in favor of #14601 that will remove the feature instead. What do you all think of that? Please comment on that PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org