You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/04/28 18:45:03 UTC

Review Request 33629: Cross-stack config changes not being sent to agents correctly

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33629/
-----------------------------------------------------------

Review request for Ambari and Jonathan Hurley.


Bugs: AMBARI-10798
    https://issues.apache.org/jira/browse/AMBARI-10798


Repository: ambari


Description
-------

Config merge for cross-stack are made after the stages have already been created, so when the stages were created, the desired config was still on the older version.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java b973d98 

Diff: https://reviews.apache.org/r/33629/diff/


Testing
-------

Existing tests cover the code, this change precipitated by cluster testing.  No new tests required.

Tests run: 2900, Failures: 0, Errors: 0, Skipped: 17

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 23:33.286s
[INFO] Finished at: Tue Apr 28 12:29:46 EDT 2015
[INFO] Final Memory: 42M/808M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole


Re: Review Request 33629: Cross-stack config changes not being sent to agents correctly

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33629/#review81830
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On April 28, 2015, 12:46 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33629/
> -----------------------------------------------------------
> 
> (Updated April 28, 2015, 12:46 p.m.)
> 
> 
> Review request for Ambari and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-10798
>     https://issues.apache.org/jira/browse/AMBARI-10798
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Config merge for cross-stack are made after the stages have already been created, so when the stages were created, the desired config was still on the older version.
> 
> Also confirmed that host-groups still functioned as designed.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java b973d98 
> 
> Diff: https://reviews.apache.org/r/33629/diff/
> 
> 
> Testing
> -------
> 
> Existing tests cover the code, this change precipitated by cluster testing.  No new tests required.
> 
> Tests run: 2900, Failures: 0, Errors: 0, Skipped: 17
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:33.286s
> [INFO] Finished at: Tue Apr 28 12:29:46 EDT 2015
> [INFO] Final Memory: 42M/808M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 33629: Cross-stack config changes not being sent to agents correctly

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33629/
-----------------------------------------------------------

(Updated April 28, 2015, 12:46 p.m.)


Review request for Ambari and Jonathan Hurley.


Bugs: AMBARI-10798
    https://issues.apache.org/jira/browse/AMBARI-10798


Repository: ambari


Description (updated)
-------

Config merge for cross-stack are made after the stages have already been created, so when the stages were created, the desired config was still on the older version.

Also confirmed that host-groups still functioned as designed.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java b973d98 

Diff: https://reviews.apache.org/r/33629/diff/


Testing
-------

Existing tests cover the code, this change precipitated by cluster testing.  No new tests required.

Tests run: 2900, Failures: 0, Errors: 0, Skipped: 17

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 23:33.286s
[INFO] Finished at: Tue Apr 28 12:29:46 EDT 2015
[INFO] Final Memory: 42M/808M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole