[GitHub] [solr] patsonluk commented on a diff in pull request #1242: SOLR-16580: Avoid making copies of DocCollection for PRS updates

[GitBox <gi...@apache.org>]

patsonluk commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1060920901


##########
solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java:
##########
@@ -139,30 +138,10 @@ public static String getCollectionPathRoot(String coll) {
    * only a replica is updated
    */
   public DocCollection copyWith(PerReplicaStates newPerReplicaStates) {

Review Comment:
   The test here https://github.com/cowpaths/fullstory-solr/commit/8a83fdfc20d4ae7dc832217ed8533aca3c0bb4ee fails with the current branch as Slice and Replica are direct access to read from `Map` (as in https://github.com/cowpaths/fullstory-solr/blob/ef15b8615d01b9a4c00731c489c57dfe36621201/solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java#L233 and  https://github.com/cowpaths/fullstory-solr/blob/ef15b8615d01b9a4c00731c489c57dfe36621201/solr/solrj/src/java/org/apache/solr/common/cloud/Slice.java#L304). Unless the `Map` is a specialized version that knows to read from `PrsSupplier`? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org