You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/08/27 03:25:20 UTC
[GitHub] [incubator-doris] DinoZhang opened a new pull request #6520: [Bug] format json output
DinoZhang opened a new pull request #6520:
URL: https://github.com/apache/incubator-doris/pull/6520
## Proposed changes
#6519
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on (Fix #6519 ) and described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] DinoZhang closed pull request #6520: [Bug] format json output
Posted by GitBox <gi...@apache.org>.
DinoZhang closed pull request #6520:
URL: https://github.com/apache/incubator-doris/pull/6520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #6520: [Bug] format json output
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #6520:
URL: https://github.com/apache/incubator-doris/pull/6520#discussion_r702811402
##########
File path: fe/fe-core/src/main/java/org/apache/doris/httpv2/HttpServer.java
##########
@@ -93,4 +101,16 @@ public void start(String dorisHome) {
.properties(properties)
.run(new String[]{});
}
+
+ @Bean
+ public Jackson2ObjectMapperBuilderCustomizer jacksonObjectMapperCustomization() {
Review comment:
This may affect all HTTP api, I am not sure if this is ok for result of other APIs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] DinoZhang commented on pull request #6520: [Bug] format json output
Posted by GitBox <gi...@apache.org>.
DinoZhang commented on pull request #6520:
URL: https://github.com/apache/incubator-doris/pull/6520#issuecomment-913937286
ok,I will close this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #6520: [Bug] format json output
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #6520:
URL: https://github.com/apache/incubator-doris/pull/6520#issuecomment-913614744
I suggest to use [bigint](https://developer.mozilla.org/zh-CN/docs/Web/JavaScript/Reference/Global_Objects/BigInt) or some [other library](https://github.com/MikeMcl/bignumber.js/) in javascript to solve this problem.
So that we won' t lose type info of the data.
It will be resolved later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] DinoZhang commented on a change in pull request #6520: [Bug] format json output
Posted by GitBox <gi...@apache.org>.
DinoZhang commented on a change in pull request #6520:
URL: https://github.com/apache/incubator-doris/pull/6520#discussion_r702829986
##########
File path: fe/fe-core/src/main/java/org/apache/doris/httpv2/HttpServer.java
##########
@@ -93,4 +101,16 @@ public void start(String dorisHome) {
.properties(properties)
.run(new String[]{});
}
+
+ @Bean
+ public Jackson2ObjectMapperBuilderCustomizer jacksonObjectMapperCustomization() {
Review comment:
1. I tested it and there is no problem
2. Because of the potential overflow problem of json numbers, these types of return values should be converted into strings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org