You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Mridul Muralidharan (JIRA)" <ji...@apache.org> on 2011/04/08 10:31:05 UTC

[jira] [Commented] (PIG-1745) Disable converting bytes loading from BinStorage

    [ https://issues.apache.org/jira/browse/PIG-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017345#comment-13017345 ] 

Mridul Muralidharan commented on PIG-1745:
------------------------------------------

Since this is a backwardly incompatible change, some release notes indicating how users can continue to rely on earlier behavior (when the data being casted is indeed a long in the example in desc) would be good - assuming it is still possible to do so.
If it is totally removed as an option, it is very unfortunate and drastically diminishes the value of BinStorage.

> Disable converting bytes loading from BinStorage
> ------------------------------------------------
>
>                 Key: PIG-1745
>                 URL: https://issues.apache.org/jira/browse/PIG-1745
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.8.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.9.0
>
>         Attachments: PIG-1745-1.patch, PIG-1745-2.patch, PIG-1745-3.patch
>
>
> If we load bytes from BinStorage, we don't actually know how we get these bytes originally, and we will not have a way to cast those bytes. Ideally we shall encode caster into BinStorage data file, but we are not there yet. Currrently bytesToXXX methods for BinStorage is wrong and it results unexpected errors. Eg.
> {code}
> a = load '1.txt' as (a0, a1, a2);
> store a into '1.bin' as BinStorage();
> a = load '1.bin' using BinStorage as (a0, a1, a2);
> b = foreach a generate (long)a0;
> dump b;
> {code}
> The code will run but produce wrong data. It's less confusing if we throw an exception in this case.
> Release Notes:
> Pig will throw exception in the case we want to convert bytes loading from BinStorage

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira