You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/05/19 23:12:49 UTC

Review Request 34437: serverUtils.py is not using customized client.api.port in ambari.properties

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34437/
-----------------------------------------------------------

Review request for Ambari and Robert Levas.


Bugs: AMBARI-11251
    https://issues.apache.org/jira/browse/AMBARI-11251


Repository: ambari


Description
-------

In customized ambari.properties file, client.api.port=8033.
When running command "#ambari-server sync-ldap --all -v" and find the output still shows Ambari is syncing with " 127.0.0.1:8080 "
It uses a hard coded value for the port.


Diffs
-----

  ambari-server/src/main/python/ambari_server/serverUtils.py 6466524 
  ambari-server/src/test/python/TestAmbariServer.py 8f90e59 
  ambari-server/src/test/python/TestServerUpgrade.py 05b48fa 
  ambari-server/src/test/python/TestServerUtils.py a1a9ef3 

Diff: https://reviews.apache.org/r/34437/diff/


Testing
-------

Manual test.

Updated unit tests.

mvn clean test

All tests pass.


Thanks,

Tom Beerbower


Re: Review Request 34437: serverUtils.py is not using customized client.api.port in ambari.properties

Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34437/#review84510
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Levas


On May 19, 2015, 5:12 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34437/
> -----------------------------------------------------------
> 
> (Updated May 19, 2015, 5:12 p.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-11251
>     https://issues.apache.org/jira/browse/AMBARI-11251
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In customized ambari.properties file, client.api.port=8033.
> When running command "#ambari-server sync-ldap --all -v" and find the output still shows Ambari is syncing with " 127.0.0.1:8080 "
> It uses a hard coded value for the port.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/ambari_server/serverUtils.py 6466524 
>   ambari-server/src/test/python/TestAmbariServer.py 8f90e59 
>   ambari-server/src/test/python/TestServerUpgrade.py 05b48fa 
>   ambari-server/src/test/python/TestServerUtils.py a1a9ef3 
> 
> Diff: https://reviews.apache.org/r/34437/diff/
> 
> 
> Testing
> -------
> 
> Manual test.
> 
> Updated unit tests.
> 
> mvn clean test
> 
> All tests pass.
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>