[GitHub] [hbase] bharathv commented on a change in pull request #2996: HBASE-25547 (addendum): Roll ExecutorType into ExecutorConfig

[GitBox <gi...@apache.org>]

bharathv commented on a change in pull request #2996:
URL: https://github.com/apache/hbase/pull/2996#discussion_r584014860



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java
##########
@@ -127,25 +127,14 @@ public ThreadPoolExecutor getExecutorThreadPool(final ExecutorType type) {
     return getExecutor(type).getThreadPoolExecutor();
   }
 
-  public void startExecutorService(final ExecutorType type, final ExecutorConfig config) {
-    String name = type.getExecutorName(this.servername);
-    if (isExecutorServiceRunning(name)) {
-      LOG.debug("Executor service {} already running on {}", this,
-          this.servername);
-      return;
-    }
-    startExecutorService(config.setName(name));
-  }
-
   /**
    * Initialize the executor lazily, Note if an executor need to be initialized lazily, then all

Review comment:
       I'm not sure I understood this comment. In what sense this is lazier compared to startExecutorService()? Wanted to get rid of this but checking here first.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org