You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by afs <gi...@git.apache.org> on 2017/06/14 20:35:15 UTC

[GitHub] jena pull request #262: JENA-1313: Some cleanup around NodeValueSortKey

GitHub user afs opened a pull request:

    https://github.com/apache/jena/pull/262

    JENA-1313: Some cleanup around NodeValueSortKey

    - NodeValue.sameAs (complete switch statement)
    - Add NodeValue.getSortKey() and use instead of casts.
    - javadoc fixes

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/afs/jena sortkey

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jena/pull/262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #262
    
----
commit 11f7ef8b20d21151a0282015d3cda916e73bcf58
Author: Andy Seaborne <an...@apache.org>
Date:   2017-06-14T20:23:50Z

    JENA-1313: Some cleanup
    
    NodeValue.sameAs (complete switch statement)
    Add NodeValue.getSortKey and use instead of casts.
    javadoc fixes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena issue #262: JENA-1313: Some cleanup around NodeValueSortKey

Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:

    https://github.com/apache/jena/pull/262
  
    Thanks for the explanation Andy! I hadn't a clue that would be necessary, but will try to keep it in mind next time I have a change for ARQ.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena issue #262: JENA-1313: Some cleanup around NodeValueSortKey

Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:

    https://github.com/apache/jena/pull/262
  
    +1 !!!
    
    Just so I know when to use it, what's `SystemARQ.ValueExtensions` for?
    
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena issue #262: JENA-1313: Some cleanup around NodeValueSortKey

Posted by afs <gi...@git.apache.org>.
Github user afs commented on the issue:

    https://github.com/apache/jena/pull/262
  
    `SystemARQ.ValueExtensions` is a very old flag (that I'd complete forgotten about!) that will make ARQ only deal with the minimum set of datatypes in SPARQL, so no xsd:date, xsd:g*, language tags, and others appearing in the built-in operators for "same value" and "compare".
    
    Looking at it, the treatment I can see that the list isn't right - I'll push a fix as part of this PR and tidy up some comments.
    
    It is enabled in "strict mode", which is only useful for investigating specs, and is unlikely to be perfect so check the query and results to confirm.
    
    The set of "value spaces" is more detailed than that in XDM (XQuery and XPath Data Model) - xsd:date and xsd:dateTimes can be compared using special rules, duration needed a java fix, so {{NodeValue.compare}} has several special cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena pull request #262: JENA-1313: Some cleanup around NodeValueSortKey

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/jena/pull/262


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena issue #262: JENA-1313: Some cleanup around NodeValueSortKey

Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:

    https://github.com/apache/jena/pull/262
  
    And had a look at the second commit, looks OK from what I could see. Keeping my +1 lgtm for it! :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---