You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/03/22 11:03:24 UTC
[GitHub] [arrow-datafusion] tustvold opened a new pull request, #5685: Update for arrow 36
tustvold opened a new pull request, #5685:
URL: https://github.com/apache/arrow-datafusion/pull/5685
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5685: Update to arrow 36
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5685:
URL: https://github.com/apache/arrow-datafusion/pull/5685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #5685: Update to arrow 36
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5685:
URL: https://github.com/apache/arrow-datafusion/pull/5685#discussion_r1150723143
##########
datafusion/core/tests/sqllogictests/test_files/aggregate.slt:
##########
@@ -1390,7 +1390,7 @@ as values
('2021-1-1T05:11:10.432', 'Row 3');
-statement ok
+statement error DataFusion error: Arrow error: Parser error: Error parsing timestamp from '2021-1-1T05:11:10.432': error parsing date
Review Comment:
> 1. Change this test from
Will do
> 2 file an upstream ticket in arrow-rs to be more lenient
I would strongly request we do not do this, it will severely hurt performance for an incredibly esoteric use-case. It isn't actually documented that chrono supports this, and we have never intentionally supported it either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #5685: Update to arrow 36
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5685:
URL: https://github.com/apache/arrow-datafusion/pull/5685#discussion_r1144628553
##########
datafusion/common/src/scalar.rs:
##########
@@ -3437,10 +3437,6 @@ mod tests {
ScalarValue::Decimal128(None, 10, 2),
ScalarValue::try_from_array(&array, 3).unwrap()
);
- assert_eq!(
Review Comment:
See https://github.com/apache/arrow-datafusion/pull/5441#discussion_r1121792711
This test was wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5685: Update to arrow 36
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5685:
URL: https://github.com/apache/arrow-datafusion/pull/5685#discussion_r1146529079
##########
datafusion/core/tests/dataframe_functions.rs:
##########
@@ -398,10 +398,10 @@ async fn test_fn_regexp_match() -> Result<()> {
"+-----------------------------------+",
"| regexpmatch(test.a,Utf8(\"[a-z]\")) |",
"+-----------------------------------+",
- "| [] |",
- "| [] |",
- "| [] |",
- "| [] |",
+ "| [a] |",
Review Comment:
Bug fix -- see https://github.com/apache/arrow-rs/issues/3803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5685: Update to arrow 36
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5685:
URL: https://github.com/apache/arrow-datafusion/pull/5685#discussion_r1150666599
##########
datafusion/core/tests/sqllogictests/test_files/aggregate.slt:
##########
@@ -1390,7 +1390,7 @@ as values
('2021-1-1T05:11:10.432', 'Row 3');
-statement ok
+statement error DataFusion error: Arrow error: Parser error: Error parsing timestamp from '2021-1-1T05:11:10.432': error parsing date
Review Comment:
I think we should change the data in this test so it passes
Also, it looks like a slight regression to me in that parsing `2021-1-1` used to parse and now doesn't.
So I suggest:
# 1. Change this test from
```
2021-1-1T05:11:10.432
```
to something like
```
2021-01-01T05:11:10.432
```
# 2 file an upstream ticket in arrow-rs to be more lenient
Aka to accept `2021-1-1T05:11:10.432` as valid -- I can do this if you like
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5685: Update to arrow 36
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5685:
URL: https://github.com/apache/arrow-datafusion/pull/5685#discussion_r1150797407
##########
datafusion/core/tests/sqllogictests/test_files/aggregate.slt:
##########
@@ -1387,7 +1387,7 @@ as values
('2018-11-13T17:11:10.011375885995', 'Row 0'),
('2011-12-13T11:13:10.12345', 'Row 1'),
(null, 'Row 2'),
- ('2021-1-1T05:11:10.432', 'Row 3');
+ ('2021-01-01T05:11:10.432', 'Row 3');
Review Comment:
Filed https://github.com/apache/arrow-rs/issues/3969 to track (I don't think we necessarily need to change arrow to support these timestamps, it but it will reduce confusion to have the change documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #5685: Update to arrow 36
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5685:
URL: https://github.com/apache/arrow-datafusion/pull/5685#discussion_r1150732948
##########
datafusion/core/tests/sqllogictests/test_files/aggregate.slt:
##########
@@ -1387,7 +1387,7 @@ as values
('2018-11-13T17:11:10.011375885995', 'Row 0'),
('2011-12-13T11:13:10.12345', 'Row 1'),
(null, 'Row 2'),
- ('2021-1-1T05:11:10.432', 'Row 3');
+ ('2021-01-01T05:11:10.432', 'Row 3');
Review Comment:
Arrow no longer supports timestamps of this shortened form, it has never been documented to support them, and it is an accidental undocumented quirk of chrono that it did. I would very strongly resist changing this, being able to predict the digit locations ahead of time is critical to avoiding a data dependency when parsing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org