You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2018/04/26 16:34:33 UTC
svn commit: r1830241 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDStrikeoutAppearanceHandler.java
Author: tilman
Date: Thu Apr 26 16:34:33 2018
New Revision: 1830241
URL: http://svn.apache.org/viewvc?rev=1830241&view=rev
Log:
PDFBOX-3353: handle special case where quadpoints surface is empty
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDStrikeoutAppearanceHandler.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDStrikeoutAppearanceHandler.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDStrikeoutAppearanceHandler.java?rev=1830241&r1=1830240&r2=1830241&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDStrikeoutAppearanceHandler.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDStrikeoutAppearanceHandler.java Thu Apr 26 16:34:33 2018
@@ -113,16 +113,24 @@ public class PDStrikeoutAppearanceHandle
// https://stackoverflow.com/questions/7740507/extend-a-line-segment-a-specific-distance
float len0 = (float) (Math.sqrt(Math.pow(pathsArray[i * 8] - pathsArray[i * 8 + 4], 2) +
Math.pow(pathsArray[i * 8 + 1] - pathsArray[i * 8 + 5], 2)));
- float x0 = pathsArray[i * 8 + 4] + (pathsArray[i * 8] -
- pathsArray[i * 8 + 4]) / len0 * (len0 / 2 - ab.width);
- float y0 = pathsArray[i * 8 + 5] + (pathsArray[i * 8 + 1] -
- pathsArray[i * 8 + 5]) / len0 * (len0 / 2 - ab.width);
+ float x0 = pathsArray[i * 8 + 4];
+ float y0 = pathsArray[i * 8 + 5];
+ if (Float.compare(len0, 0) != 0)
+ {
+ // only if both coordinates are not identical to avoid divide by zero
+ x0 += (pathsArray[i * 8] - pathsArray[i * 8 + 4]) / len0 * (len0 / 2 - ab.width);
+ y0 += (pathsArray[i * 8 + 1] - pathsArray[i * 8 + 5]) / len0 * (len0 / 2 - ab.width);
+ }
float len1 = (float) (Math.sqrt(Math.pow(pathsArray[i * 8 + 2] - pathsArray[i * 8 + 6], 2) +
Math.pow(pathsArray[i * 8 + 3] - pathsArray[i * 8 + 7], 2)));
- float x1 = pathsArray[i * 8 + 6] + (pathsArray[i * 8 + 2] -
- pathsArray[i * 8 + 6]) / len1 * (len1 / 2 - ab.width);
- float y1 = pathsArray[i * 8 + 7] + (pathsArray[i * 8 + 3] -
- pathsArray[i * 8 + 7]) / len1 * (len1 / 2 - ab.width);
+ float x1 = pathsArray[i * 8 + 6];
+ float y1 = pathsArray[i * 8 + 7];
+ if (Float.compare(len1, 0) != 0)
+ {
+ // only if both coordinates are not identical to avoid divide by zero
+ x1 += (pathsArray[i * 8 + 2] - pathsArray[i * 8 + 6]) / len1 * (len1 / 2 - ab.width);
+ y1 += (pathsArray[i * 8 + 3] - pathsArray[i * 8 + 7]) / len1 * (len1 / 2 - ab.width);
+ }
cs.moveTo(x0, y0);
cs.lineTo(x1, y1);
}