You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ttpro1995 (via GitHub)" <gi...@apache.org> on 2023/08/29 04:18:53 UTC
[GitHub] [airflow] ttpro1995 opened a new pull request, #33867: Update taskflow.rst, Multiple outputs inference example
ttpro1995 opened a new pull request, #33867:
URL: https://github.com/apache/airflow/pull/33867
Change `dict[str, int]` to `Dict[str, int]`
Add `from typing import Dict` for clarity
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #33867: Update taskflow.rst, fix Multiple outputs inference example
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #33867:
URL: https://github.com/apache/airflow/pull/33867#issuecomment-1696749051
The `dict` usage is correct, see [PEP 585](https://peps.python.org/pep-0585/).
Maybe we could add a note somewhere (or do we already?) explaining that `from __future__ import annotations` is needed for some of the examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #33867: Update taskflow.rst, Multiple outputs inference example
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #33867:
URL: https://github.com/apache/airflow/pull/33867#issuecomment-1696741527
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #33867: Update taskflow.rst, fix Multiple outputs inference example
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33867:
URL: https://github.com/apache/airflow/pull/33867#issuecomment-1704342784
> Maybe we could add a note somewhere (or do we already?) explaining that from __future__ import annotations is needed for some of the examples.
I don't think we have a good place to add such info. If anything, all examples that need it should possibly have it added - but i think that's kinda difficult to enforce.
Anyhow closing this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #33867: Update taskflow.rst, fix Multiple outputs inference example
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #33867: Update taskflow.rst, fix Multiple outputs inference example
URL: https://github.com/apache/airflow/pull/33867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org