You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/28 07:34:46 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #6091: Enhance Envoy metrics service analyzer by MAL
kezhenxu94 opened a new pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes https://github.com/apache/skywalking/issues/5988.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-752412407
@wu-sheng according to https://www.envoyproxy.io/docs/envoy/latest/configuration/observability/statistics, I only added some of them that I thought is useful/helpful, will also take a look whether the other statistics https://www.envoyproxy.io/docs/envoy/latest/configuration/listeners/stats#listener are emitted to metrics service or not, (as per test at the moment, seems not). The updated screenshot
<img width="1792" alt="image" src="https://user-images.githubusercontent.com/15965696/103346135-289c9180-4ace-11eb-99b2-6a89be04dfaf.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (fd13101) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `1.32%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 50.00% -1.33%
+ Complexity 3504 3356 -148
============================================
Files 1693 907 -786
Lines 35808 22455 -13353
Branches 3956 2172 -1784
============================================
- Hits 18380 11229 -7151
+ Misses 16488 10287 -6201
+ Partials 940 939 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1195 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (9605d09) into [master](https://codecov.io/gh/apache/skywalking/commit/209a3bd044d24bbce9beadc39f6b9c58f58db4ef?el=desc) (209a3bd) will **increase** coverage by `0.61%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 49.39% 50.00% +0.61%
+ Complexity 3273 2692 -581
============================================
Files 907 764 -143
Lines 22436 19102 -3334
Branches 2180 1786 -394
============================================
- Hits 11082 9552 -1530
+ Misses 10420 8840 -1580
+ Partials 934 710 -224
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+3.33%)` | `3.00 <2.00> (+1.00)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ng/oap/server/core/source/EnvoyInstanceMetric.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Vudm95SW5zdGFuY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [190 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (54efea6) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `8.25%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.44% 43.19% -8.26%
+ Complexity 3527 2470 -1057
============================================
Files 1695 766 -929
Lines 35839 19119 -16720
Branches 3958 1802 -2156
============================================
- Hits 18437 8258 -10179
+ Misses 16462 10253 -6209
+ Partials 940 608 -332
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `95.00% <100.00%> (-0.84%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1280 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...54efea6](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (763c807) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `2.15%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 53.57% +2.15%
+ Complexity 3522 3510 -12
============================================
Files 1693 907 -786
Lines 35832 22513 -13319
Branches 3958 2185 -1773
============================================
- Hits 18425 12062 -6363
+ Misses 16467 9468 -6999
- Partials 940 983 +43
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1184 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...4ba7244](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (b966295) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `15.35%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.32% 35.97% -15.36%
+ Complexity 3505 2026 -1479
=============================================
Files 1693 747 -946
Lines 35811 18549 -17262
Branches 3960 1738 -2222
=============================================
- Hits 18381 6673 -11708
+ Misses 16490 11361 -5129
+ Partials 940 515 -425
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1323 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...02b5eb0](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (d44af04) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `0.11%`.
> The diff coverage is `32.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.41% 51.30% -0.12%
+ Complexity 3516 3504 -12
============================================
Files 1693 1692 -1
Lines 35811 35814 +3
Branches 3960 3958 -2
============================================
- Hits 18412 18374 -38
- Misses 16459 16499 +40
- Partials 940 941 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `21.87% <25.00%> (+9.71%)` | `3.00 <2.00> (+1.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.00% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/source/EnvoyInstanceMetric.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Vudm95SW5zdGFuY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| ... and [15 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...f2cc92a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (f10ab5f) into [master](https://codecov.io/gh/apache/skywalking/commit/1b1f08511ccb8542d96f29dcaee72c73492b74f9?el=desc) (1b1f085) will **decrease** coverage by `1.51%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 52.86% 51.35% -1.52%
+ Complexity 3472 2768 -704
============================================
Files 907 764 -143
Lines 22484 19162 -3322
Branches 2183 1804 -379
============================================
- Hits 11887 9841 -2046
+ Misses 9614 8600 -1014
+ Partials 983 721 -262
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+3.33%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [193 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1b1f085...75e552d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (9f3224e) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `3.58%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.44% 47.86% -3.59%
+ Complexity 3530 2652 -878
============================================
Files 1695 766 -929
Lines 35839 19148 -16691
Branches 3958 1804 -2154
============================================
- Hits 18439 9166 -9273
+ Misses 16462 9301 -7161
+ Partials 938 681 -257
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1265 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...9f3224e](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-752557480
> Do you think providing 2 separated level 1 dashboard called `Istio` and `Istio Data Panel` makes more sense? In this case, we could provide another group name for those sidecar's services/instances.
>
> @hanahmily What do you think?
Make sense to me. I think the key point is the service group, metrics from Istio control/data plane need different aggregation dimissions, should not share the same service group.
And for isito data plane, do we intend to show relationship metrics between mesh services?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (02b5eb0) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `24.96%`.
> The diff coverage is `19.56%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.32% 26.36% -24.97%
+ Complexity 3505 1545 -1960
=============================================
Files 1693 746 -947
Lines 35811 18375 -17436
Branches 3960 1705 -2255
=============================================
- Hits 18381 4844 -13537
+ Misses 16490 13163 -3327
+ Partials 940 368 -572
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `5.55% <0.00%> (-84.59%)` | `2.00 <0.00> (-18.00)` | |
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `10.05% <11.11%> (-46.95%)` | `9.00 <1.00> (-51.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1370 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...02b5eb0](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (14c8eaf) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `21.46%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.32% 29.85% -21.47%
=============================================
Files 1693 1605 -88
Lines 35811 33421 -2390
Branches 3960 4416 +456
=============================================
- Hits 18381 9979 -8402
- Misses 16490 22522 +6032
+ Partials 940 920 -20
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `100.00% <ø> (+43.00%)` | `0.00 <0.00> (-60.00)` | :arrow_up: |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | `0.00 <0.00> (-8.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-12.17%)` | `0.00 <0.00> (-2.00)` | |
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/server/core/source/Source.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...che/skywalking/oap/server/core/source/Service.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/oap/server/core/source/SideCar.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NpZGVDYXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [749 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...14c8eaf](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (fd13101) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `14.86%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.32% 36.46% -14.87%
+ Complexity 3504 2056 -1448
=============================================
Files 1693 747 -946
Lines 35808 18575 -17233
Branches 3956 1741 -2215
=============================================
- Hits 18380 6773 -11607
+ Misses 16488 11281 -5207
+ Partials 940 521 -419
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1321 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (9171205) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **increase** coverage by `0.14%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.41% 51.55% +0.14%
+ Complexity 3516 3397 -119
============================================
Files 1693 907 -786
Lines 35811 22490 -13321
Branches 3960 2187 -1773
============================================
- Hits 18412 11595 -6817
+ Misses 16459 9920 -6539
- Partials 940 975 +35
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1197 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...f2cc92a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (9f3224e) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `0.09%`.
> The diff coverage is `30.37%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.44% 51.35% -0.10%
+ Complexity 3530 3519 -11
============================================
Files 1695 1695
Lines 35839 35855 +16
Branches 3958 3954 -4
============================================
- Hits 18439 18413 -26
- Misses 16462 16498 +36
- Partials 938 944 +6
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.85% <19.04%> (-4.14%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `25.92% <27.27%> (+13.76%)` | `3.00 <2.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/source/EnvoyInstanceMetric.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Vudm95SW5zdGFuY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/worker/TopNWorker.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5Xb3JrZXIuamF2YQ==) | `42.42% <0.00%> (-12.13%)` | `4.00% <0.00%> (-1.00%)` | |
| ... and [14 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...9f3224e](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (cfbf5b3) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `3.00%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.42% 48.41% -3.01%
+ Complexity 3522 2668 -854
============================================
Files 1693 764 -929
Lines 35832 19159 -16673
Branches 3958 1804 -2154
============================================
- Hits 18425 9275 -9150
+ Misses 16467 9181 -7286
+ Partials 940 703 -237
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1264 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...cfbf5b3](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (9171205) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `13.39%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.41% 38.01% -13.40%
+ Complexity 3516 2136 -1380
=============================================
Files 1693 747 -946
Lines 35811 18565 -17246
Branches 3960 1751 -2209
=============================================
- Hits 18412 7058 -11354
+ Misses 16459 10981 -5478
+ Partials 940 526 -414
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1310 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...f2cc92a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (cfbf5b3) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `2.26%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 53.68% +2.26%
- Complexity 3522 3532 +10
============================================
Files 1693 911 -782
Lines 35832 22578 -13254
Branches 3958 2193 -1765
============================================
- Hits 18425 12120 -6305
+ Misses 16467 9462 -7005
- Partials 940 996 +56
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1182 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...cfbf5b3](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4ba7244) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `2.15%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 53.57% +2.15%
+ Complexity 3522 3508 -14
============================================
Files 1693 907 -786
Lines 35832 22513 -13319
Branches 3958 2185 -1773
============================================
- Hits 18425 12062 -6363
+ Misses 16467 9469 -6998
- Partials 940 982 +42
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1184 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...4ba7244](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#discussion_r550505683
##########
File path: oap-server/server-bootstrap/src/main/resources/ui-initialized-templates/istio-dp.yml
##########
@@ -0,0 +1,82 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+templates:
+ - name: "Istio Data Plane"
Review comment:
I am good with this name. @hanahmily Please review from tech perspective, especially MAL integration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (54efea6) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `0.57%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.44% 50.87% -0.58%
+ Complexity 3527 2760 -767
============================================
Files 1695 766 -929
Lines 35839 19169 -16670
Branches 3958 1804 -2154
============================================
- Hits 18437 9752 -8685
+ Misses 16462 8703 -7759
+ Partials 940 714 -226
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `95.00% <100.00%> (-0.84%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1254 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...54efea6](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (8e40d6d) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `0.20%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.41% 51.20% -0.21%
+ Complexity 3516 3381 -135
============================================
Files 1693 907 -786
Lines 35811 22493 -13318
Branches 3960 2187 -1773
============================================
- Hits 18412 11518 -6894
+ Misses 16459 10032 -6427
- Partials 940 943 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1194 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...8e40d6d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (fd13101) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `2.06%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 49.26% -2.07%
+ Complexity 3504 3314 -190
============================================
Files 1693 907 -786
Lines 35808 22455 -13353
Branches 3956 2172 -1784
============================================
- Hits 18380 11062 -7318
+ Misses 16488 10466 -6022
+ Partials 940 927 -13
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1198 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (9605d09) into [master](https://codecov.io/gh/apache/skywalking/commit/209a3bd044d24bbce9beadc39f6b9c58f58db4ef?el=desc) (209a3bd) will **decrease** coverage by `0.95%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 49.39% 48.44% -0.96%
+ Complexity 3273 2643 -630
============================================
Files 907 764 -143
Lines 22436 19085 -3351
Branches 2180 1785 -395
============================================
- Hits 11082 9245 -1837
+ Misses 10420 9131 -1289
+ Partials 934 709 -225
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+3.33%)` | `3.00 <2.00> (+1.00)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [199 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4ba7244) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `1.14%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 52.56% +1.14%
+ Complexity 3522 3464 -58
============================================
Files 1693 907 -786
Lines 35832 22513 -13319
Branches 3958 2185 -1773
============================================
- Hits 18425 11835 -6590
+ Misses 16467 9721 -6746
- Partials 940 957 +17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1187 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...4ba7244](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (6754a3d) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `7.42%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.42% 43.99% -7.43%
+ Complexity 3522 2505 -1017
============================================
Files 1693 764 -929
Lines 35832 19104 -16728
Branches 3958 1787 -2171
============================================
- Hits 18425 8404 -10021
+ Misses 16467 10084 -6383
+ Partials 940 616 -324
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1278 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...6754a3d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (d44af04) into [master](https://codecov.io/gh/apache/skywalking/commit/1f012463a21b4274a2c633a1515f91b57174fc4b?el=desc) (1f01246) will **decrease** coverage by `10.46%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.41% 40.95% -10.47%
+ Complexity 3517 2290 -1227
=============================================
Files 1692 746 -946
Lines 35802 18593 -17209
Branches 3959 1755 -2204
=============================================
- Hits 18408 7614 -10794
+ Misses 16457 10407 -6050
+ Partials 937 572 -365
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1302 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1f01246...d44af04](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-752407916
> Another question is, this PR is only considering the Istio 1.6 and 1.7 right? We do the upgrade and compatible mode with ALS together, right?
Yes, this PR only focuses on migrating Envoy metrics service from OAL to MAL, the protocol upgrade from v2 -> v3 will be #5872 's scope
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (54efea6) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **increase** coverage by `0.17%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.44% 51.61% +0.17%
+ Complexity 3527 2789 -738
============================================
Files 1695 766 -929
Lines 35839 19169 -16670
Branches 3958 1804 -2154
============================================
- Hits 18437 9895 -8542
+ Misses 16462 8552 -7910
+ Partials 940 722 -218
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `95.00% <100.00%> (-0.84%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1251 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...54efea6](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (763c807) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `20.21%`.
> The diff coverage is `19.56%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.42% 31.20% -20.22%
+ Complexity 3522 1789 -1733
=============================================
Files 1693 747 -946
Lines 35832 18428 -17404
Branches 3958 1704 -2254
=============================================
- Hits 18425 5751 -12674
+ Misses 16467 12266 -4201
+ Partials 940 411 -529
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `5.55% <0.00%> (-84.59%)` | `2.00 <0.00> (-18.00)` | |
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `24.62% <11.11%> (-32.38%)` | `25.00 <1.00> (-35.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1345 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...4ba7244](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (f2cc92a) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `10.85%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.41% 40.55% -10.86%
+ Complexity 3516 2266 -1250
=============================================
Files 1693 747 -946
Lines 35811 18575 -17236
Branches 3960 1752 -2208
=============================================
- Hits 18412 7533 -10879
+ Misses 16459 10473 -5986
+ Partials 940 569 -371
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1303 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...f2cc92a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (6754a3d) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `1.75%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 53.17% +1.75%
+ Complexity 3522 3489 -33
============================================
Files 1693 907 -786
Lines 35832 22513 -13319
Branches 3958 2185 -1773
============================================
- Hits 18425 11972 -6453
+ Misses 16467 9560 -6907
- Partials 940 981 +41
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1186 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...6754a3d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#discussion_r550819580
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -161,12 +162,32 @@ public SampleFamily div(SampleFamily another) {
/* Aggregation operators */
public SampleFamily sum(List<String> by) {
+ return aggregate(by, Double::sum);
+ }
+
+ public SampleFamily max(List<String> by) {
+ return aggregate(by, Double::max);
+ }
+
+ public SampleFamily min(List<String> by) {
+ return aggregate(by, Double::min);
Review comment:
Pls add more unit tests to cover these functions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (cfbf5b3) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `9.45%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.42% 41.96% -9.46%
+ Complexity 3522 2412 -1110
============================================
Files 1693 764 -929
Lines 35832 19081 -16751
Branches 3958 1797 -2161
============================================
- Hits 18425 8008 -10417
+ Misses 16467 10471 -5996
+ Partials 940 602 -338
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1287 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...cfbf5b3](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (cfbf5b3) into [master](https://codecov.io/gh/apache/skywalking/commit/1b1f08511ccb8542d96f29dcaee72c73492b74f9?el=desc) (1b1f085) will **increase** coverage by `6.97%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 46.70% 53.68% +6.97%
- Complexity 3213 3532 +319
============================================
Files 907 911 +4
Lines 22434 22578 +144
Branches 2181 2193 +12
============================================
+ Hits 10477 12120 +1643
+ Misses 11076 9462 -1614
- Partials 881 996 +115
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+3.33%)` | `3.00 <2.00> (+1.00)` | |
| [...ng/oap/server/core/source/EnvoyInstanceMetric.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Vudm95SW5zdGFuY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-2.00%)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `73.56% <0.00%> (-3.45%)` | `28.00% <0.00%> (-2.00%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `53.36% <0.00%> (-0.90%)` | `12.00% <0.00%> (ø%)` | |
| ... and [98 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1b1f085...f10ab5f](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (f2cc92a) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `4.94%`.
> The diff coverage is `32.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.41% 46.47% -4.95%
+ Complexity 3516 2545 -971
============================================
Files 1693 1680 -13
Lines 35811 35541 -270
Branches 3960 4123 +163
============================================
- Hits 18412 16516 -1896
- Misses 16459 18070 +1611
- Partials 940 955 +15
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `21.87% <25.00%> (+9.71%)` | `3.00 <2.00> (+1.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.00% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [195 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...7659c5a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (20aae26) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **increase** coverage by `0.93%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.44% 52.38% +0.93%
+ Complexity 3530 3465 -65
============================================
Files 1695 909 -786
Lines 35839 22535 -13304
Branches 3958 2186 -1772
============================================
- Hits 18439 11804 -6635
+ Misses 16462 9759 -6703
- Partials 938 972 +34
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1187 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...20aae26](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (75e552d) into [master](https://codecov.io/gh/apache/skywalking/commit/1b1f08511ccb8542d96f29dcaee72c73492b74f9?el=desc) (1b1f085) will **increase** coverage by `0.52%`.
> The diff coverage is `31.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 50.89% 51.41% +0.52%
- Complexity 3472 3520 +48
============================================
Files 1693 1693
Lines 35831 35843 +12
Branches 3958 3957 -1
============================================
+ Hits 18235 18430 +195
+ Misses 16657 16474 -183
Partials 939 939
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `21.87% <25.00%> (+9.71%)` | `3.00 <2.00> (+1.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.00% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...ng/oap/server/core/source/EnvoyInstanceMetric.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Vudm95SW5zdGFuY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-2.00%)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `91.95% <0.00%> (-1.15%)` | `28.00% <0.00%> (-2.00%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.96% <0.00%> (+0.69%)` | `2.00% <0.00%> (ø%)` | |
| ... and [29 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1b1f085...75e552d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (9605d09) into [master](https://codecov.io/gh/apache/skywalking/commit/209a3bd044d24bbce9beadc39f6b9c58f58db4ef?el=desc) (209a3bd) will **increase** coverage by `0.60%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 49.39% 49.99% +0.60%
+ Complexity 3273 2690 -583
============================================
Files 907 764 -143
Lines 22436 19102 -3334
Branches 2180 1786 -394
============================================
- Hits 11082 9550 -1532
+ Misses 10420 8842 -1578
+ Partials 934 710 -224
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+3.33%)` | `3.00 <2.00> (+1.00)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ng/oap/server/core/source/EnvoyInstanceMetric.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Vudm95SW5zdGFuY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [191 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (8e40d6d) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **increase** coverage by `1.34%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.41% 52.76% +1.34%
+ Complexity 3516 3454 -62
============================================
Files 1693 907 -786
Lines 35811 22493 -13318
Branches 3960 2187 -1773
============================================
- Hits 18412 11868 -6544
+ Misses 16459 9661 -6798
- Partials 940 964 +24
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1187 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...8e40d6d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (d44af04) into [master](https://codecov.io/gh/apache/skywalking/commit/1f012463a21b4274a2c633a1515f91b57174fc4b?el=desc) (1f01246) will **increase** coverage by `2.14%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.41% 53.56% +2.14%
+ Complexity 3517 3504 -13
============================================
Files 1692 906 -786
Lines 35802 22483 -13319
Branches 3959 2185 -1774
============================================
- Hits 18408 12043 -6365
+ Misses 16457 9459 -6998
- Partials 937 981 +44
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1184 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1f01246...d44af04](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (bfac6c1) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **increase** coverage by `1.95%`.
> The diff coverage is `41.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.43% 53.38% +1.95%
+ Complexity 3519 3490 -29
============================================
Files 1693 907 -786
Lines 35811 22492 -13319
Branches 3960 2187 -1773
============================================
- Hits 18418 12008 -6410
+ Misses 16454 9511 -6943
- Partials 939 973 +34
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.27% <22.22%> (-1.72%)` | `61.00 <2.00> (+1.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `2.00 <1.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1185 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...bfac6c1](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (20aae26) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `2.19%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.44% 49.25% -2.20%
+ Complexity 3530 2712 -818
============================================
Files 1695 766 -929
Lines 35839 19170 -16669
Branches 3958 1804 -2154
============================================
- Hits 18439 9442 -8997
+ Misses 16462 9038 -7424
+ Partials 938 690 -248
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1258 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...20aae26](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (916e20a) into [master](https://codecov.io/gh/apache/skywalking/commit/1f012463a21b4274a2c633a1515f91b57174fc4b?el=desc) (1f01246) will **decrease** coverage by `21.58%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.41% 29.83% -21.59%
=============================================
Files 1692 1605 -87
Lines 35802 33425 -2377
Branches 3959 4414 +455
=============================================
- Hits 18408 9971 -8437
- Misses 16457 22534 +6077
+ Partials 937 920 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `100.00% <ø> (+43.00%)` | `0.00 <0.00> (-60.00)` | :arrow_up: |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | `0.00 <0.00> (-8.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-12.17%)` | `0.00 <0.00> (-2.00)` | |
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/server/core/source/Source.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...che/skywalking/oap/server/core/source/Service.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/oap/server/core/source/SideCar.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NpZGVDYXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [749 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1f01246...916e20a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (9605d09) into [master](https://codecov.io/gh/apache/skywalking/commit/209a3bd044d24bbce9beadc39f6b9c58f58db4ef?el=desc) (209a3bd) will **decrease** coverage by `3.90%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 49.38% 45.48% -3.91%
+ Complexity 3273 2534 -739
============================================
Files 907 764 -143
Lines 22436 19047 -3389
Branches 2180 1783 -397
============================================
- Hits 11081 8663 -2418
+ Misses 10421 9715 -706
+ Partials 934 669 -265
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+3.33%)` | `3.00 <2.00> (+1.00)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [203 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (9171205) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `1.53%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.41% 49.88% -1.54%
+ Complexity 3516 3321 -195
============================================
Files 1693 907 -786
Lines 35811 22476 -13335
Branches 3960 2186 -1774
============================================
- Hits 18412 11212 -7200
+ Misses 16459 10314 -6145
- Partials 940 950 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1205 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...f2cc92a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (6da1cb4) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `3.35%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 47.97% -3.36%
+ Complexity 3504 2604 -900
============================================
Files 1693 764 -929
Lines 35808 19092 -16716
Branches 3956 1785 -2171
============================================
- Hits 18380 9160 -9220
+ Misses 16488 9247 -7241
+ Partials 940 685 -255
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1266 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (02b5eb0) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `5.37%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 45.95% -5.38%
+ Complexity 3505 2550 -955
============================================
Files 1693 764 -929
Lines 35811 19074 -16737
Branches 3960 1800 -2160
============================================
- Hits 18381 8765 -9616
+ Misses 16490 9648 -6842
+ Partials 940 661 -279
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1276 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...02b5eb0](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (fd13101) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `11.73%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.32% 39.59% -11.74%
+ Complexity 3504 2261 -1243
=============================================
Files 1693 764 -929
Lines 35808 19080 -16728
Branches 3956 1789 -2167
=============================================
- Hits 18380 7555 -10825
+ Misses 16488 10949 -5539
+ Partials 940 576 -364
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1297 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (f2cc92a) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `17.82%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.41% 33.59% -17.83%
+ Complexity 3516 1959 -1557
=============================================
Files 1693 746 -947
Lines 35811 18526 -17285
Branches 3960 1735 -2225
=============================================
- Hits 18412 6223 -12189
+ Misses 16459 11814 -4645
+ Partials 940 489 -451
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...f2cc92a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (cfbf5b3) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `1.51%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 52.93% +1.51%
+ Complexity 3522 3489 -33
============================================
Files 1693 911 -782
Lines 35832 22578 -13254
Branches 3958 2193 -1765
============================================
- Hits 18425 11952 -6473
+ Misses 16467 9644 -6823
- Partials 940 982 +42
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1185 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...cfbf5b3](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#discussion_r549248213
##########
File path: oap-server/server-bootstrap/src/main/resources/otel-oc-rules/istio-controlplane.yaml
##########
@@ -28,7 +28,7 @@
# "-P6H3M" -- parses as "-6 hours and -3 minutes"
# "-P-6H+3M" -- parses as "+6 hours and -3 minutes"
# </pre>
-expSuffix: tag({tags -> tags.cluster = 'istio-ctrl::' + tags.cluster}).service(['cluster', 'app'])
Review comment:
No, we should let the OT collector handle it by "relabel" as the OAP cluster is a center cluster that can't identify the metrics from which cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (bfac6c1) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **increase** coverage by `2.17%`.
> The diff coverage is `41.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.43% 53.61% +2.17%
+ Complexity 3519 3504 -15
============================================
Files 1693 907 -786
Lines 35811 22492 -13319
Branches 3960 2187 -1773
============================================
- Hits 18418 12058 -6360
+ Misses 16454 9452 -7002
- Partials 939 982 +43
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.27% <22.22%> (-1.72%)` | `61.00 <2.00> (+1.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `2.00 <1.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1184 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...bfac6c1](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (20aae26) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **increase** coverage by `2.24%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.44% 53.69% +2.24%
+ Complexity 3530 3520 -10
============================================
Files 1695 909 -786
Lines 35839 22535 -13304
Branches 3958 2186 -1772
============================================
- Hits 18439 12100 -6339
+ Misses 16462 9452 -7010
- Partials 938 983 +45
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1184 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...20aae26](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (6da1cb4) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `3.64%`.
> The diff coverage is `31.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 47.68% -3.65%
+ Complexity 3505 2607 -898
============================================
Files 1693 1683 -10
Lines 35811 35565 -246
Branches 3960 4116 +156
============================================
- Hits 18381 16960 -1421
- Misses 16490 17652 +1162
- Partials 940 953 +13
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `21.87% <25.00%> (+9.71%)` | `3.00 <2.00> (+1.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.00% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...op/server/receiver/mesh/MeshGRPCHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlckNvbXBhdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [186 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...02b5eb0](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (b966295) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `1.26%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 50.06% -1.27%
+ Complexity 3505 3341 -164
============================================
Files 1693 907 -786
Lines 35811 22476 -13335
Branches 3960 2173 -1787
============================================
- Hits 18381 11252 -7129
+ Misses 16490 10291 -6199
+ Partials 940 933 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1193 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...02b5eb0](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (763c807) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `13.28%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.42% 38.13% -13.29%
+ Complexity 3522 2135 -1387
=============================================
Files 1693 747 -946
Lines 35832 18622 -17210
Branches 3958 1755 -2203
=============================================
- Hits 18425 7101 -11324
+ Misses 16467 10992 -5475
+ Partials 940 529 -411
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1315 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...4ba7244](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (0fab4e4) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `11.94%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.42% 39.48% -11.95%
+ Complexity 3522 2213 -1309
=============================================
Files 1693 747 -946
Lines 35832 18594 -17238
Branches 3958 1750 -2208
=============================================
- Hits 18425 7341 -11084
+ Misses 16467 10682 -5785
+ Partials 940 571 -369
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1310 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...0fab4e4](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (be62df5) into [master](https://codecov.io/gh/apache/skywalking/commit/1f012463a21b4274a2c633a1515f91b57174fc4b?el=desc) (1f01246) will **decrease** coverage by `21.57%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.41% 29.83% -21.58%
=============================================
Files 1692 1605 -87
Lines 35802 33425 -2377
Branches 3959 4414 +455
=============================================
- Hits 18408 9974 -8434
- Misses 16457 22532 +6075
+ Partials 937 919 -18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `100.00% <ø> (+43.00%)` | `0.00 <0.00> (-60.00)` | :arrow_up: |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | `0.00 <0.00> (-8.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-12.17%)` | `0.00 <0.00> (-2.00)` | |
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/server/core/source/Source.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...che/skywalking/oap/server/core/source/Service.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/oap/server/core/source/SideCar.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NpZGVDYXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [749 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1f01246...d44af04](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (71b9ddd) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `0.07%`.
> The diff coverage is `30.37%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.44% 51.37% -0.08%
+ Complexity 3530 3522 -8
============================================
Files 1695 1695
Lines 35839 35855 +16
Branches 3958 3954 -4
============================================
- Hits 18439 18419 -20
- Misses 16462 16495 +33
- Partials 938 941 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.85% <19.04%> (-4.14%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `25.92% <27.27%> (+13.76%)` | `3.00 <2.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/source/EnvoyInstanceMetric.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Vudm95SW5zdGFuY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/worker/TopNWorker.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5Xb3JrZXIuamF2YQ==) | `42.42% <0.00%> (-12.13%)` | `4.00% <0.00%> (-1.00%)` | |
| ... and [10 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...20aae26](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (f25ee23) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `21.57%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.43% 29.86% -21.58%
=============================================
Files 1693 1605 -88
Lines 35811 33422 -2389
Branches 3960 4416 +456
=============================================
- Hits 18418 9980 -8438
- Misses 16454 22520 +6066
+ Partials 939 922 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `100.00% <ø> (+43.00%)` | `0.00 <0.00> (-60.00)` | :arrow_up: |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | `0.00 <0.00> (-8.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-12.17%)` | `0.00 <0.00> (-2.00)` | |
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/server/core/source/Source.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...che/skywalking/oap/server/core/source/Service.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/oap/server/core/source/SideCar.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NpZGVDYXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [748 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...6e0a5a7](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (6da1cb4) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `15.30%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.32% 36.02% -15.31%
+ Complexity 3504 2025 -1479
=============================================
Files 1693 747 -946
Lines 35808 18538 -17270
Branches 3956 1736 -2220
=============================================
- Hits 18380 6678 -11702
+ Misses 16488 11322 -5166
+ Partials 940 538 -402
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1321 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (71b9ddd) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **increase** coverage by `2.25%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.44% 53.70% +2.25%
+ Complexity 3530 3519 -11
============================================
Files 1695 909 -786
Lines 35839 22535 -13304
Branches 3958 2186 -1772
============================================
- Hits 18439 12103 -6336
+ Misses 16462 9452 -7010
- Partials 938 980 +42
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1183 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...71b9ddd](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (71b9ddd) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **increase** coverage by `2.27%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.44% 53.72% +2.27%
+ Complexity 3530 3522 -8
============================================
Files 1695 909 -786
Lines 35839 22535 -13304
Branches 3958 2186 -1772
============================================
- Hits 18439 12106 -6333
+ Misses 16462 9452 -7010
- Partials 938 977 +39
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1183 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...71b9ddd](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (9f3224e) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `1.13%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.44% 50.31% -1.14%
+ Complexity 3530 2754 -776
============================================
Files 1695 766 -929
Lines 35839 19184 -16655
Branches 3958 1805 -2153
============================================
- Hits 18439 9652 -8787
+ Misses 16462 8812 -7650
+ Partials 938 720 -218
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1255 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...9f3224e](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (71b9ddd) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `3.64%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.44% 47.80% -3.65%
+ Complexity 3530 3252 -278
============================================
Files 1695 909 -786
Lines 35839 22499 -13340
Branches 3958 2185 -1773
============================================
- Hits 18439 10756 -7683
+ Misses 16462 10861 -5601
+ Partials 938 882 -56
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1206 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...71b9ddd](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (71b9ddd) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **increase** coverage by `1.42%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.44% 52.87% +1.42%
+ Complexity 3530 3478 -52
============================================
Files 1695 909 -786
Lines 35839 22535 -13304
Branches 3958 2186 -1772
============================================
- Hits 18439 11916 -6523
+ Misses 16462 9651 -6811
- Partials 938 968 +30
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1187 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...71b9ddd](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (f10ab5f) into [master](https://codecov.io/gh/apache/skywalking/commit/1b1f08511ccb8542d96f29dcaee72c73492b74f9?el=desc) (1b1f085) will **decrease** coverage by `2.41%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 52.86% 50.44% -2.42%
+ Complexity 3472 2739 -733
============================================
Files 907 764 -143
Lines 22484 19162 -3322
Branches 2183 1804 -379
============================================
- Hits 11887 9667 -2220
+ Misses 9614 8786 -828
+ Partials 983 709 -274
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+3.33%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.84%)` | `0.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [203 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1b1f085...75e552d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (fd13101) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `2.81%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 48.51% -2.82%
+ Complexity 3504 3276 -228
============================================
Files 1693 907 -786
Lines 35808 22452 -13356
Branches 3956 2172 -1784
============================================
- Hits 18380 10893 -7487
+ Misses 16488 10632 -5856
+ Partials 940 927 -13
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1204 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (b966295) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `4.88%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 46.44% -4.89%
+ Complexity 3505 2570 -935
============================================
Files 1693 764 -929
Lines 35811 19122 -16689
Branches 3960 1792 -2168
============================================
- Hits 18381 8881 -9500
+ Misses 16490 9573 -6917
+ Partials 940 668 -272
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1267 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...02b5eb0](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4fa1eb2) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `6.70%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 44.62% -6.71%
+ Complexity 3505 2509 -996
============================================
Files 1693 764 -929
Lines 35811 19074 -16737
Branches 3960 1800 -2160
============================================
- Hits 18381 8512 -9869
+ Misses 16490 9936 -6554
+ Partials 940 626 -314
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1272 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...14c8eaf](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (54efea6) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `14.82%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.44% 36.61% -14.83%
+ Complexity 3527 2075 -1452
=============================================
Files 1695 749 -946
Lines 35839 18586 -17253
Branches 3958 1735 -2223
=============================================
- Hits 18437 6806 -11631
+ Misses 16462 11265 -5197
+ Partials 940 515 -425
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `95.00% <100.00%> (-0.84%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1319 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...54efea6](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (b966295) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `1.25%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 50.07% -1.26%
+ Complexity 3505 3344 -161
============================================
Files 1693 907 -786
Lines 35811 22476 -13335
Branches 3960 2173 -1787
============================================
- Hits 18381 11255 -7126
+ Misses 16490 10288 -6202
+ Partials 940 933 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1193 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...02b5eb0](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (6da1cb4) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `11.64%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.32% 39.68% -11.65%
+ Complexity 3504 2244 -1260
=============================================
Files 1693 764 -929
Lines 35808 19038 -16770
Branches 3956 1784 -2172
=============================================
- Hits 18380 7556 -10824
+ Misses 16488 10880 -5608
+ Partials 940 602 -338
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1296 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (cfbf5b3) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `23.49%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.42% 27.92% -23.50%
+ Complexity 3522 1640 -1882
=============================================
Files 1693 746 -947
Lines 35832 18508 -17324
Branches 3958 1730 -2228
=============================================
- Hits 18425 5169 -13256
+ Misses 16467 12948 -3519
+ Partials 940 391 -549
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1381 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...cfbf5b3](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4ba7244) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `2.15%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 53.57% +2.15%
+ Complexity 3522 3508 -14
============================================
Files 1693 907 -786
Lines 35832 22513 -13319
Branches 3958 2185 -1773
============================================
- Hits 18425 12061 -6364
+ Misses 16467 9469 -6998
- Partials 940 983 +43
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1184 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...4ba7244](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4ba7244) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `1.55%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 52.97% +1.55%
+ Complexity 3522 3485 -37
============================================
Files 1693 907 -786
Lines 35832 22513 -13319
Branches 3958 2185 -1773
============================================
- Hits 18425 11927 -6498
+ Misses 16467 9614 -6853
- Partials 940 972 +32
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1184 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...4ba7244](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (71b9ddd) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `11.76%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.44% 39.68% -11.77%
+ Complexity 3530 2224 -1306
=============================================
Files 1695 749 -946
Lines 35839 18616 -17223
Branches 3958 1751 -2207
=============================================
- Hits 18439 7388 -11051
+ Misses 16462 10674 -5788
+ Partials 938 554 -384
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1308 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...71b9ddd](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (f10ab5f) into [master](https://codecov.io/gh/apache/skywalking/commit/1b1f08511ccb8542d96f29dcaee72c73492b74f9?el=desc) (1b1f085) will **decrease** coverage by `12.66%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 52.86% 40.20% -12.67%
+ Complexity 3472 2218 -1254
=============================================
Files 907 747 -160
Lines 22484 18594 -3890
Branches 2183 1750 -433
=============================================
- Hits 11887 7475 -4412
- Misses 9614 10529 +915
+ Partials 983 590 -393
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+3.33%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [286 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1b1f085...f10ab5f](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (cfbf5b3) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `1.19%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 52.61% +1.19%
+ Complexity 3522 3458 -64
============================================
Files 1693 907 -786
Lines 35832 22513 -13319
Branches 3958 2185 -1773
============================================
- Hits 18425 11846 -6579
+ Misses 16467 9707 -6760
- Partials 940 960 +20
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1188 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...cfbf5b3](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4fa1eb2) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **increase** coverage by `2.23%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.32% 53.56% +2.23%
+ Complexity 3505 3504 -1
============================================
Files 1693 907 -786
Lines 35811 22492 -13319
Branches 3960 2187 -1773
============================================
- Hits 18381 12048 -6333
+ Misses 16490 9469 -7021
- Partials 940 975 +35
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1189 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...14c8eaf](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4ba7244) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `0.07%`.
> The diff coverage is `31.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.42% 51.34% -0.08%
+ Complexity 3522 3511 -11
============================================
Files 1693 1693
Lines 35832 35843 +11
Branches 3958 3957 -1
============================================
- Hits 18425 18404 -21
- Misses 16467 16499 +32
Partials 940 940
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `21.87% <25.00%> (+9.71%)` | `3.00 <2.00> (+1.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.00% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/source/EnvoyInstanceMetric.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Vudm95SW5zdGFuY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/worker/TopNWorker.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5Xb3JrZXIuamF2YQ==) | `42.42% <0.00%> (-12.13%)` | `4.00% <0.00%> (-1.00%)` | |
| ... and [7 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...4ba7244](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (54efea6) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `2.09%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.44% 49.34% -2.10%
+ Complexity 3527 2712 -815
============================================
Files 1695 766 -929
Lines 35839 19169 -16670
Branches 3958 1804 -2154
============================================
- Hits 18437 9459 -8978
+ Misses 16462 9003 -7459
+ Partials 940 707 -233
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `95.00% <100.00%> (-0.84%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1259 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...54efea6](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (b966295) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `9.61%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 41.71% -9.62%
+ Complexity 3505 2273 -1232
============================================
Files 1693 747 -946
Lines 35811 18594 -17217
Branches 3960 1739 -2221
============================================
- Hits 18381 7757 -10624
+ Misses 16490 10237 -6253
+ Partials 940 600 -340
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1301 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...02b5eb0](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (6754a3d) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `2.13%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 53.56% +2.13%
+ Complexity 3522 3509 -13
============================================
Files 1693 907 -786
Lines 35832 22513 -13319
Branches 3958 2185 -1773
============================================
- Hits 18425 12058 -6367
+ Misses 16467 9471 -6996
- Partials 940 984 +44
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1185 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...cfbf5b3](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (54efea6) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `13.80%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.44% 37.63% -13.81%
+ Complexity 3527 2105 -1422
=============================================
Files 1695 749 -946
Lines 35839 18595 -17244
Branches 3958 1737 -2221
=============================================
- Hits 18437 6999 -11438
+ Misses 16462 11070 -5392
+ Partials 940 526 -414
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `95.00% <100.00%> (-0.84%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1318 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...54efea6](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (20aae26) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **increase** coverage by `2.23%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.44% 53.68% +2.23%
+ Complexity 3530 3518 -12
============================================
Files 1695 909 -786
Lines 35839 22535 -13304
Branches 3958 2186 -1772
============================================
- Hits 18439 12098 -6341
+ Misses 16462 9454 -7008
- Partials 938 983 +45
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1184 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...20aae26](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#discussion_r550748426
##########
File path: test/e2e/e2e-test/src/test/resources/expected/metricsservice/services.yml
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+services:
+ - key: not null
+ label: istio-dp::ratings.default
+ - key: not null
+ label: istio-dp::reviews.default
+ - key: not null
+ label: istio-dp::productpage.default
+ - key: not null
+ label: istio-dp::details.default
+ - key: not null
+ label: istio-dp::istio-ingressgateway
Review comment:
This is `services.yaml`
##########
File path: test/e2e/e2e-test/src/test/resources/expected/metricsservice/services.yml
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+services:
+ - key: not null
+ label: istio-dp::ratings.default
+ - key: not null
+ label: istio-dp::reviews.default
+ - key: not null
+ label: istio-dp::productpage.default
+ - key: not null
+ label: istio-dp::details.default
+ - key: not null
+ label: istio-dp::istio-ingressgateway
Review comment:
This is `services.yaml`, not instances
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (54efea6) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `12.32%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.44% 39.12% -12.33%
+ Complexity 3527 2243 -1284
=============================================
Files 1695 766 -929
Lines 35839 19082 -16757
Branches 3958 1784 -2174
=============================================
- Hits 18437 7465 -10972
+ Misses 16462 11055 -5407
+ Partials 940 562 -378
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `95.00% <100.00%> (-0.84%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1302 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...54efea6](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (02b5eb0) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `5.13%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 46.18% -5.14%
+ Complexity 3505 2559 -946
============================================
Files 1693 764 -929
Lines 35811 19074 -16737
Branches 3960 1800 -2160
============================================
- Hits 18381 8810 -9571
+ Misses 16490 9594 -6896
+ Partials 940 670 -270
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1275 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...02b5eb0](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4fa1eb2) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `4.07%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 47.24% -4.08%
+ Complexity 3505 2617 -888
============================================
Files 1693 764 -929
Lines 35811 19105 -16706
Branches 3960 1805 -2155
============================================
- Hits 18381 9027 -9354
+ Misses 16490 9413 -7077
+ Partials 940 665 -275
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1263 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...14c8eaf](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (75e552d) into [master](https://codecov.io/gh/apache/skywalking/commit/1b1f08511ccb8542d96f29dcaee72c73492b74f9?el=desc) (1b1f085) will **decrease** coverage by `14.27%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 52.86% 38.59% -14.28%
+ Complexity 3472 2168 -1304
=============================================
Files 907 747 -160
Lines 22484 18594 -3890
Branches 2183 1750 -433
=============================================
- Hits 11887 7176 -4711
- Misses 9614 10857 +1243
+ Partials 983 561 -422
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+3.33%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [301 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1b1f085...75e552d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (75e552d) into [master](https://codecov.io/gh/apache/skywalking/commit/1b1f08511ccb8542d96f29dcaee72c73492b74f9?el=desc) (1b1f085) will **decrease** coverage by `0.09%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 52.86% 52.77% -0.10%
- Complexity 3472 3485 +13
============================================
Files 907 907
Lines 22484 22513 +29
Branches 2183 2185 +2
============================================
- Hits 11887 11881 -6
- Misses 9614 9655 +41
+ Partials 983 977 -6
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+3.33%)` | `3.00 <2.00> (+1.00)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `10.20% <0.00%> (-77.56%)` | `3.00% <0.00%> (-6.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | |
| [...ng/oap/server/core/source/EnvoyInstanceMetric.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Vudm95SW5zdGFuY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-2.00%)` | |
| [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | |
| ... and [41 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1b1f085...75e552d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#discussion_r549937709
##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -266,6 +266,7 @@ envoy-metric:
# to append the version number to the service name.
# Be careful, when using environment variables to pass this configuration, use single quotes(`''`) to avoid it being evaluated by the shell.
k8sServiceNameRule: ${K8S_SERVICE_NAME_RULE:"${service.metadata.name}"}
+ enabledMALRules: ${SW_ENVOY_METRIC_MAL_RULES:"envoy"}
Review comment:
OK, removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (02b5eb0) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `17.74%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.32% 33.58% -17.75%
+ Complexity 3505 1958 -1547
=============================================
Files 1693 746 -947
Lines 35811 18525 -17286
Branches 3960 1735 -2225
=============================================
- Hits 18381 6221 -12160
+ Misses 16490 11814 -4676
+ Partials 940 490 -450
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1341 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...02b5eb0](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (d44af04) into [master](https://codecov.io/gh/apache/skywalking/commit/1f012463a21b4274a2c633a1515f91b57174fc4b?el=desc) (1f01246) will **decrease** coverage by `10.47%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.41% 40.94% -10.48%
+ Complexity 3517 2289 -1228
=============================================
Files 1692 746 -946
Lines 35802 18593 -17209
Branches 3959 1755 -2204
=============================================
- Hits 18408 7612 -10796
+ Misses 16457 10408 -6049
+ Partials 937 573 -364
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1302 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1f01246...d44af04](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (71b9ddd) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `15.37%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.44% 36.07% -15.38%
+ Complexity 3530 2032 -1498
=============================================
Files 1695 749 -946
Lines 35839 18596 -17243
Branches 3958 1748 -2210
=============================================
- Hits 18439 6709 -11730
+ Misses 16462 11372 -5090
+ Partials 938 515 -423
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1327 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...71b9ddd](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#discussion_r549937582
##########
File path: oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/metrics/adapters/ProtoMetricFamily2MetricsAdapter.java
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.receiver.envoy.metrics.adapters;
+
+import io.prometheus.client.Metrics;
+import java.util.Map;
+import java.util.stream.Stream;
+import lombok.RequiredArgsConstructor;
+import org.apache.skywalking.oap.server.library.util.prometheus.metrics.Gauge;
+import org.apache.skywalking.oap.server.library.util.prometheus.metrics.Metric;
+
+import static java.util.stream.Collectors.toMap;
+
+@RequiredArgsConstructor
+public class ProtoMetricFamily2MetricsAdapter {
+ protected final Metrics.MetricFamily metricFamily;
+
+ public Stream<Metric> adapt() {
+ // TODO: should adapt more types
+ switch (metricFamily.getType()) {
Review comment:
Can't be null actually
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (b966295) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `1.25%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 50.07% -1.26%
+ Complexity 3505 3344 -161
============================================
Files 1693 907 -786
Lines 35811 22476 -13335
Branches 3960 2173 -1787
============================================
- Hits 18381 11255 -7126
+ Misses 16490 10288 -6202
+ Partials 940 933 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1193 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...14c8eaf](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (8e40d6d) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `13.72%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.41% 37.68% -13.73%
+ Complexity 3516 2102 -1414
=============================================
Files 1693 747 -946
Lines 35811 18575 -17236
Branches 3960 1752 -2208
=============================================
- Hits 18412 7000 -11412
+ Misses 16459 11048 -5411
+ Partials 940 527 -413
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1317 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...8e40d6d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (6da1cb4) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `11.70%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.32% 39.62% -11.71%
+ Complexity 3504 2192 -1312
=============================================
Files 1693 747 -946
Lines 35808 18558 -17250
Branches 3956 1738 -2218
=============================================
- Hits 18380 7354 -11026
+ Misses 16488 10615 -5873
+ Partials 940 589 -351
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1307 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (c79305a) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `21.57%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.43% 29.85% -21.58%
=============================================
Files 1693 1605 -88
Lines 35811 33421 -2390
Branches 3960 4416 +456
=============================================
- Hits 18418 9977 -8441
- Misses 16454 22523 +6069
+ Partials 939 921 -18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `100.00% <ø> (+43.00%)` | `0.00 <0.00> (-60.00)` | :arrow_up: |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | `0.00 <0.00> (-8.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-12.17%)` | `0.00 <0.00> (-2.00)` | |
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/server/core/source/Source.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...che/skywalking/oap/server/core/source/Service.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/oap/server/core/source/SideCar.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NpZGVDYXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [749 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...9605d09](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (6e0a5a7) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `2.31%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.43% 49.11% -2.32%
+ Complexity 3519 2698 -821
============================================
Files 1693 764 -929
Lines 35811 19111 -16700
Branches 3960 1804 -2156
============================================
- Hits 18418 9386 -9032
+ Misses 16454 9022 -7432
+ Partials 939 703 -236
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1261 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...bfac6c1](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (bfac6c1) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `2.34%`.
> The diff coverage is `41.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.43% 49.08% -2.35%
+ Complexity 3519 2681 -838
============================================
Files 1693 764 -929
Lines 35811 19127 -16684
Branches 3960 1805 -2155
============================================
- Hits 18418 9389 -9029
+ Misses 16454 9047 -7407
+ Partials 939 691 -248
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.27% <22.22%> (-1.72%)` | `61.00 <2.00> (+1.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `2.00 <1.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1261 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...bfac6c1](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (8e40d6d) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `10.36%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.41% 41.04% -10.37%
+ Complexity 3516 2271 -1245
=============================================
Files 1693 747 -946
Lines 35811 18584 -17227
Branches 3960 1753 -2207
=============================================
- Hits 18412 7628 -10784
+ Misses 16459 10397 -6062
+ Partials 940 559 -381
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1300 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...8e40d6d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (71b9ddd) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `6.24%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.44% 45.20% -6.25%
+ Complexity 3530 3060 -470
============================================
Files 1695 892 -803
Lines 35839 22001 -13838
Branches 3958 2138 -1820
============================================
- Hits 18439 9946 -8493
+ Misses 16462 11209 -5253
+ Partials 938 846 -92
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1235 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...71b9ddd](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#discussion_r549281601
##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -266,6 +266,7 @@ envoy-metric:
# to append the version number to the service name.
# Be careful, when using environment variables to pass this configuration, use single quotes(`''`) to avoid it being evaluated by the shell.
k8sServiceNameRule: ${K8S_SERVICE_NAME_RULE:"${service.metadata.name}"}
+ enabledMALRules: ${SW_ENVOY_METRIC_MAL_RULES:"envoy"}
Review comment:
Why need this? Could we disable through `SW_ENVOY_METRIC=-`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (fd13101) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `5.03%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 46.29% -5.04%
+ Complexity 3504 2580 -924
============================================
Files 1693 764 -929
Lines 35808 19099 -16709
Branches 3956 1789 -2167
============================================
- Hits 18380 8841 -9539
+ Misses 16488 9580 -6908
+ Partials 940 678 -262
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1269 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (75e552d) into [master](https://codecov.io/gh/apache/skywalking/commit/1b1f08511ccb8542d96f29dcaee72c73492b74f9?el=desc) (1b1f085) will **decrease** coverage by `11.49%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 52.86% 41.37% -11.50%
+ Complexity 3472 2318 -1154
=============================================
Files 907 747 -160
Lines 22484 18600 -3884
Branches 2183 1751 -432
=============================================
- Hits 11887 7696 -4191
- Misses 9614 10312 +698
+ Partials 983 592 -391
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+3.33%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [290 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1b1f085...75e552d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (a2f70e5) into [master](https://codecov.io/gh/apache/skywalking/commit/1b1f08511ccb8542d96f29dcaee72c73492b74f9?el=desc) (1b1f085) will **increase** coverage by `3.72%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 52.86% 56.59% +3.72%
+ Complexity 3472 744 -2728
============================================
Files 907 160 -747
Lines 22484 3868 -18616
Branches 2183 451 -1732
============================================
- Hits 11887 2189 -9698
+ Misses 9614 1404 -8210
+ Partials 983 275 -708
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-25.65%)` | `6.00% <0.00%> (-4.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `53.57% <0.00%> (-7.15%)` | `5.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/storage/plugin/jaeger/JaegerSpan.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW4uamF2YQ==) | | | |
| [...figuration/apollo/ApolloConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwb2xsby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBvbGxvL0Fwb2xsb0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | | | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | | | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | | | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | | | |
| [...ap/server/telemetry/none/MetricsCollectorNoop.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90ZWxlbWV0cnkvbm9uZS9NZXRyaWNzQ29sbGVjdG9yTm9vcC5qYXZh) | | | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | | | |
| ... and [734 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1b1f085...75e552d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (71b9ddd) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `9.36%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.44% 42.08% -9.37%
+ Complexity 3530 2348 -1182
============================================
Files 1695 749 -946
Lines 35839 18622 -17217
Branches 3958 1752 -2206
============================================
- Hits 18439 7837 -10602
+ Misses 16462 10193 -6269
+ Partials 938 592 -346
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1299 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...71b9ddd](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4ba7244) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `0.07%`.
> The diff coverage is `31.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.42% 51.34% -0.08%
+ Complexity 3522 3511 -11
============================================
Files 1693 1693
Lines 35832 35843 +11
Branches 3958 3957 -1
============================================
- Hits 18425 18404 -21
- Misses 16467 16499 +32
Partials 940 940
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `21.87% <25.00%> (+9.71%)` | `3.00 <2.00> (+1.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.00% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/source/EnvoyInstanceMetric.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Vudm95SW5zdGFuY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/worker/TopNWorker.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5Xb3JrZXIuamF2YQ==) | `42.42% <0.00%> (-12.13%)` | `4.00% <0.00%> (-1.00%)` | |
| ... and [7 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...0fab4e4](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (8f508ea) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `21.58%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.43% 29.84% -21.59%
=============================================
Files 1693 1605 -88
Lines 35811 33422 -2389
Branches 3960 4416 +456
=============================================
- Hits 18418 9976 -8442
- Misses 16454 22525 +6071
+ Partials 939 921 -18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `100.00% <ø> (+43.00%)` | `0.00 <0.00> (-60.00)` | :arrow_up: |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | `0.00 <0.00> (-8.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-12.17%)` | `0.00 <0.00> (-2.00)` | |
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/server/core/source/Source.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...che/skywalking/oap/server/core/source/Service.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/oap/server/core/source/SideCar.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NpZGVDYXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [748 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...bfac6c1](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (763c807) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `0.08%`.
> The diff coverage is `31.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.42% 51.33% -0.09%
+ Complexity 3522 3510 -12
============================================
Files 1693 1693
Lines 35832 35843 +11
Branches 3958 3957 -1
============================================
- Hits 18425 18401 -24
- Misses 16467 16502 +35
Partials 940 940
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `21.87% <25.00%> (+9.71%)` | `3.00 <2.00> (+1.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.00% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/source/EnvoyInstanceMetric.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Vudm95SW5zdGFuY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/worker/TopNWorker.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5Xb3JrZXIuamF2YQ==) | `42.42% <0.00%> (-12.13%)` | `4.00% <0.00%> (-1.00%)` | |
| ... and [9 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...0fab4e4](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (8e40d6d) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `0.92%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.41% 50.48% -0.93%
+ Complexity 3516 3290 -226
============================================
Files 1693 890 -803
Lines 35811 21999 -13812
Branches 3960 2140 -1820
============================================
- Hits 18412 11107 -7305
+ Misses 16459 9971 -6488
+ Partials 940 921 -19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1209 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...8e40d6d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-752826675
> > And for isito data plane, do we intend to show relationship metrics between mesh services?
>
> @hanahmily I think we had already, isn't it? Through ALS. I am thinking this new dashboard is an attachment, which provide the additional sidecar's metrics
What I mean is to leverage telemetry v2 metrics from istio pilot. I knew this PR focus on envoy raw metrics. But if we name the dashboard "istio data plane", the users with Istio mesh background will ask us how to get mesh service relationship metrics, just like istio control plane telemetry add-ons.
Our solution is to persuade them to opt for ALS-based mesh relationship analysis instead of telemetry v2, or support the latter in the future? My preference is the second one, what's your thought?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (0fab4e4) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `0.35%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.42% 51.06% -0.36%
+ Complexity 3522 2777 -745
============================================
Files 1693 764 -929
Lines 35832 19162 -16670
Branches 3958 1804 -2154
============================================
- Hits 18425 9785 -8640
+ Misses 16467 8649 -7818
+ Partials 940 728 -212
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1252 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...0fab4e4](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#discussion_r550781037
##########
File path: .github/workflows/e2e.istio.yaml
##########
@@ -129,3 +129,93 @@ jobs:
- name: Clean up
if: ${{ always() }}
run: minikube delete
+
+ metrics-service:
+ runs-on: ubuntu-16.04
+ timeout-minutes: 60
+ name: MetricsService
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ submodules: true
+
+ - uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: ${{ runner.os }}-maven-
+
+ - name: Build Docker Image
+ run: make docker
+
+ - name: Prepare envrionment
+ run: bash ${SCRIPTS_DIR}/pre.sh
+
+ - name: Install Minikube
+ run: bash ${SCRIPTS_DIR}/minikube.sh start
+
+ - name: Install Istio
+ run: bash ${SCRIPTS_DIR}/istio.sh --set profile=demo --set meshConfig.defaultConfig.envoyMetricsService.address=skywalking-oap.istio-system:11800
Review comment:
And e2e fails, please recheck.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (f10ab5f) into [master](https://codecov.io/gh/apache/skywalking/commit/1b1f08511ccb8542d96f29dcaee72c73492b74f9?el=desc) (1b1f085) will **decrease** coverage by `13.39%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 52.86% 39.46% -13.40%
+ Complexity 3472 2197 -1275
=============================================
Files 907 747 -160
Lines 22484 18584 -3900
Branches 2183 1749 -434
=============================================
- Hits 11887 7335 -4552
- Misses 9614 10672 +1058
+ Partials 983 577 -406
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+3.33%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [292 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1b1f085...f10ab5f](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (cfbf5b3) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `11.27%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.42% 40.14% -11.28%
+ Complexity 3522 2302 -1220
=============================================
Files 1693 764 -929
Lines 35832 19081 -16751
Branches 3958 1797 -2161
=============================================
- Hits 18425 7660 -10765
+ Misses 16467 10852 -5615
+ Partials 940 569 -371
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1295 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...cfbf5b3](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (6754a3d) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `2.11%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 53.53% +2.11%
+ Complexity 3522 3508 -14
============================================
Files 1693 907 -786
Lines 35832 22513 -13319
Branches 3958 2185 -1773
============================================
- Hits 18425 12052 -6373
+ Misses 16467 9477 -6990
- Partials 940 984 +44
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1185 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...6754a3d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (9f3224e) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `8.18%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.44% 43.26% -8.19%
+ Complexity 3530 2449 -1081
============================================
Files 1695 766 -929
Lines 35839 19134 -16705
Branches 3958 1803 -2155
============================================
- Hits 18439 8278 -10161
+ Misses 16462 10260 -6202
+ Partials 938 596 -342
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1281 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...9f3224e](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (9171205) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **increase** coverage by `0.36%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.41% 51.77% +0.36%
+ Complexity 3516 3410 -106
============================================
Files 1693 907 -786
Lines 35811 22490 -13321
Branches 3960 2187 -1773
============================================
- Hits 18412 11645 -6767
+ Misses 16459 9862 -6597
- Partials 940 983 +43
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1196 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...f2cc92a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (0fab4e4) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `2.14%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 53.56% +2.14%
+ Complexity 3522 3508 -14
============================================
Files 1693 907 -786
Lines 35832 22513 -13319
Branches 3958 2185 -1773
============================================
- Hits 18425 12059 -6366
+ Misses 16467 9470 -6997
- Partials 940 984 +44
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1185 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...0fab4e4](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (0fab4e4) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `11.93%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.42% 39.48% -11.94%
+ Complexity 3522 2213 -1309
=============================================
Files 1693 747 -946
Lines 35832 18594 -17238
Branches 3958 1750 -2208
=============================================
- Hits 18425 7342 -11083
+ Misses 16467 10681 -5786
+ Partials 940 571 -369
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1310 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...0fab4e4](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (02b5eb0) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `8.43%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 42.88% -8.44%
+ Complexity 3505 2443 -1062
============================================
Files 1693 764 -929
Lines 35811 19054 -16757
Branches 3960 1786 -2174
============================================
- Hits 18381 8172 -10209
+ Misses 16490 10271 -6219
+ Partials 940 611 -329
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1281 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...02b5eb0](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (f10ab5f) into [master](https://codecov.io/gh/apache/skywalking/commit/1b1f08511ccb8542d96f29dcaee72c73492b74f9?el=desc) (1b1f085) will **decrease** coverage by `24.94%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 52.86% 27.92% -24.95%
+ Complexity 3472 1640 -1832
=============================================
Files 907 746 -161
Lines 22484 18508 -3976
Branches 2183 1730 -453
=============================================
- Hits 11887 5169 -6718
- Misses 9614 12948 +3334
+ Partials 983 391 -592
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+3.33%)` | `3.00 <2.00> (+1.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [427 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1b1f085...f10ab5f](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (20aae26) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `15.37%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.44% 36.07% -15.38%
+ Complexity 3530 2032 -1498
=============================================
Files 1695 749 -946
Lines 35839 18596 -17243
Branches 3958 1748 -2210
=============================================
- Hits 18439 6709 -11730
+ Misses 16462 11372 -5090
+ Partials 938 515 -423
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1326 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...20aae26](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4fa1eb2) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **increase** coverage by `2.55%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.32% 53.88% +2.55%
- Complexity 3505 3531 +26
============================================
Files 1693 907 -786
Lines 35811 22492 -13319
Branches 3960 2187 -1773
============================================
- Hits 18381 12120 -6261
+ Misses 16490 9396 -7094
- Partials 940 976 +36
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1185 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...aff25f5](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4ba7244) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `1.47%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 52.89% +1.47%
+ Complexity 3522 3482 -40
============================================
Files 1693 907 -786
Lines 35832 22513 -13319
Branches 3958 2185 -1773
============================================
- Hits 18425 11908 -6517
+ Misses 16467 9633 -6834
- Partials 940 972 +32
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1184 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...4ba7244](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (8e40d6d) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `3.80%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.41% 47.61% -3.81%
+ Complexity 3516 2563 -953
============================================
Files 1693 747 -946
Lines 35811 18648 -17163
Branches 3960 1759 -2201
============================================
- Hits 18412 8879 -9533
+ Misses 16459 9104 -7355
+ Partials 940 665 -275
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1277 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...8e40d6d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (9f3224e) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `0.40%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.44% 51.04% -0.41%
+ Complexity 3530 2777 -753
============================================
Files 1695 766 -929
Lines 35839 19184 -16655
Branches 3958 1805 -2153
============================================
- Hits 18439 9792 -8647
+ Misses 16462 8673 -7789
+ Partials 938 719 -219
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1253 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...9f3224e](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (7659c5a) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `1.70%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.41% 49.71% -1.71%
+ Complexity 3516 2733 -783
============================================
Files 1693 764 -929
Lines 35811 19142 -16669
Branches 3960 1806 -2154
============================================
- Hits 18412 9516 -8896
+ Misses 16459 8918 -7541
+ Partials 940 708 -232
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1255 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...7659c5a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (f25ee23) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `21.57%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.43% 29.86% -21.58%
=============================================
Files 1693 1605 -88
Lines 35811 33422 -2389
Branches 3960 4416 +456
=============================================
- Hits 18418 9980 -8438
- Misses 16454 22520 +6066
+ Partials 939 922 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `100.00% <ø> (+43.00%)` | `0.00 <0.00> (-60.00)` | :arrow_up: |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | `0.00 <0.00> (-8.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-12.17%)` | `0.00 <0.00> (-2.00)` | |
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/server/core/source/Source.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...che/skywalking/oap/server/core/source/Service.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/oap/server/core/source/SideCar.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NpZGVDYXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [748 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...bfac6c1](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (763c807) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `14.94%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.42% 36.47% -14.95%
+ Complexity 3522 2066 -1456
=============================================
Files 1693 747 -946
Lines 35832 18579 -17253
Branches 3958 1735 -2223
=============================================
- Hits 18425 6776 -11649
+ Misses 16467 11290 -5177
+ Partials 940 513 -427
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1322 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...4ba7244](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (0fab4e4) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `2.11%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 53.53% +2.11%
+ Complexity 3522 3507 -15
============================================
Files 1693 907 -786
Lines 35832 22513 -13319
Branches 3958 2185 -1773
============================================
- Hits 18425 12053 -6372
+ Misses 16467 9476 -6991
- Partials 940 984 +44
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1185 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...0fab4e4](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (71b9ddd) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `1.53%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.44% 49.91% -1.54%
+ Complexity 3530 3356 -174
============================================
Files 1695 909 -786
Lines 35839 22535 -13304
Branches 3958 2186 -1772
============================================
- Hits 18439 11249 -7190
+ Misses 16462 10369 -6093
+ Partials 938 917 -21
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1196 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...71b9ddd](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (d44af04) into [master](https://codecov.io/gh/apache/skywalking/commit/1f012463a21b4274a2c633a1515f91b57174fc4b?el=desc) (1f01246) will **decrease** coverage by `4.24%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.41% 47.17% -4.25%
+ Complexity 3517 2534 -983
============================================
Files 1692 746 -946
Lines 35802 18632 -17170
Branches 3959 1756 -2203
============================================
- Hits 18408 8789 -9619
+ Misses 16457 9189 -7268
+ Partials 937 654 -283
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1279 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1f01246...d44af04](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4fa1eb2) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `11.76%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.32% 39.56% -11.77%
+ Complexity 3505 2214 -1291
=============================================
Files 1693 747 -946
Lines 35811 18574 -17237
Branches 3960 1752 -2208
=============================================
- Hits 18381 7348 -11033
+ Misses 16490 10674 -5816
+ Partials 940 552 -388
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1305 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...14c8eaf](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (6e0a5a7) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **increase** coverage by `2.10%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.43% 53.53% +2.10%
+ Complexity 3519 3502 -17
============================================
Files 1693 907 -786
Lines 35811 22493 -13318
Branches 3960 2187 -1773
============================================
- Hits 18418 12042 -6376
+ Misses 16454 9470 -6984
- Partials 939 981 +42
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1186 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...bfac6c1](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (f2cc92a) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `4.38%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.41% 47.02% -4.39%
+ Complexity 3516 2545 -971
============================================
Files 1693 747 -946
Lines 35811 18620 -17191
Branches 3960 1754 -2206
============================================
- Hits 18412 8756 -9656
+ Misses 16459 9198 -7261
+ Partials 940 666 -274
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1278 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...f2cc92a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (bfac6c1) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **increase** coverage by `2.16%`.
> The diff coverage is `41.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.43% 53.59% +2.16%
+ Complexity 3519 3501 -18
============================================
Files 1693 907 -786
Lines 35811 22492 -13319
Branches 3960 2187 -1773
============================================
- Hits 18418 12055 -6363
+ Misses 16454 9455 -6999
- Partials 939 982 +43
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.27% <22.22%> (-1.72%)` | `61.00 <2.00> (+1.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `2.00 <1.00> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1184 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...bfac6c1](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] muse-dev[bot] commented on a change in pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
muse-dev[bot] commented on a change in pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#discussion_r549776190
##########
File path: oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/metrics/adapters/ProtoMetricFamily2MetricsAdapter.java
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.receiver.envoy.metrics.adapters;
+
+import io.prometheus.client.Metrics;
+import java.util.Map;
+import java.util.stream.Stream;
+import lombok.RequiredArgsConstructor;
+import org.apache.skywalking.oap.server.library.util.prometheus.metrics.Gauge;
+import org.apache.skywalking.oap.server.library.util.prometheus.metrics.Metric;
+
+import static java.util.stream.Collectors.toMap;
+
+@RequiredArgsConstructor
+public class ProtoMetricFamily2MetricsAdapter {
+ protected final Metrics.MetricFamily metricFamily;
+
+ public Stream<Metric> adapt() {
+ // TODO: should adapt more types
+ switch (metricFamily.getType()) {
Review comment:
*NULL_DEREFERENCE:* object returned by `ProtoMetricFamily2MetricsAdapter.metricFamily.getType()` could be null and is dereferenced at line 36.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (7659c5a) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `9.56%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.41% 41.84% -9.57%
+ Complexity 3516 2330 -1186
============================================
Files 1693 747 -946
Lines 35811 18603 -17208
Branches 3960 1757 -2203
============================================
- Hits 18412 7785 -10627
+ Misses 16459 10233 -6226
+ Partials 940 585 -355
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1299 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...7659c5a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (8e40d6d) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `14.85%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.41% 36.55% -14.86%
+ Complexity 3516 2065 -1451
=============================================
Files 1693 747 -946
Lines 35811 18560 -17251
Branches 3960 1737 -2223
=============================================
- Hits 18412 6785 -11627
+ Misses 16459 11266 -5193
+ Partials 940 509 -431
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1321 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...8e40d6d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (9171205) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **increase** coverage by `0.41%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.41% 51.82% +0.41%
+ Complexity 3516 3416 -100
============================================
Files 1693 907 -786
Lines 35811 22490 -13321
Branches 3960 2187 -1773
============================================
- Hits 18412 11656 -6756
+ Misses 16459 9852 -6607
- Partials 940 982 +42
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1195 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...7659c5a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (6e0a5a7) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `0.23%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.43% 51.19% -0.24%
+ Complexity 3519 2768 -751
============================================
Files 1693 764 -929
Lines 35811 19142 -16669
Branches 3960 1806 -2154
============================================
- Hits 18418 9800 -8618
+ Misses 16454 8618 -7836
+ Partials 939 724 -215
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1255 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...bfac6c1](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (763c807) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `0.08%`.
> The diff coverage is `31.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.42% 51.33% -0.09%
+ Complexity 3522 3510 -12
============================================
Files 1693 1693
Lines 35832 35843 +11
Branches 3958 3957 -1
============================================
- Hits 18425 18401 -24
- Misses 16467 16502 +35
Partials 940 940
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `21.87% <25.00%> (+9.71%)` | `3.00 <2.00> (+1.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.00% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/source/EnvoyInstanceMetric.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Vudm95SW5zdGFuY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/worker/TopNWorker.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5Xb3JrZXIuamF2YQ==) | `42.42% <0.00%> (-12.13%)` | `4.00% <0.00%> (-1.00%)` | |
| ... and [9 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...4ba7244](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (20aae26) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `0.10%`.
> The diff coverage is `30.37%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.44% 51.34% -0.11%
+ Complexity 3530 3520 -10
============================================
Files 1695 1695
Lines 35839 35855 +16
Branches 3958 3954 -4
============================================
- Hits 18439 18411 -28
- Misses 16462 16502 +40
- Partials 938 942 +4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.85% <19.04%> (-4.14%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `25.92% <27.27%> (+13.76%)` | `3.00 <2.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/source/EnvoyInstanceMetric.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Vudm95SW5zdGFuY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/worker/TopNWorker.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5Xb3JrZXIuamF2YQ==) | `42.42% <0.00%> (-12.13%)` | `4.00% <0.00%> (-1.00%)` | |
| ... and [12 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...9f3224e](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (f2cc92a) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `7.52%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.41% 43.88% -7.53%
+ Complexity 3516 2431 -1085
============================================
Files 1693 747 -946
Lines 35811 18584 -17227
Branches 3960 1753 -2207
============================================
- Hits 18412 8156 -10256
+ Misses 16459 9824 -6635
+ Partials 940 604 -336
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1288 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...f2cc92a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (7659c5a) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `6.74%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.41% 44.66% -6.75%
+ Complexity 3516 2537 -979
============================================
Files 1693 764 -929
Lines 35811 19092 -16719
Branches 3960 1804 -2156
============================================
- Hits 18412 8528 -9884
+ Misses 16459 9943 -6516
+ Partials 940 621 -319
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1272 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...7659c5a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (6da1cb4) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `3.64%`.
> The diff coverage is `31.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 47.68% -3.65%
+ Complexity 3504 2607 -897
============================================
Files 1693 1683 -10
Lines 35808 35565 -243
Branches 3956 4116 +160
============================================
- Hits 18380 16960 -1420
- Misses 16488 17652 +1164
- Partials 940 953 +13
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `21.87% <25.00%> (+9.71%)` | `3.00 <2.00> (+1.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.00% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...op/server/receiver/mesh/MeshGRPCHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlckNvbXBhdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [182 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-752906069
For me, still `Data Panel` makes more sense. Due to these metrics belong to envoy, and others represent for the target services.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (20aae26) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **increase** coverage by `2.24%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.44% 53.69% +2.24%
+ Complexity 3530 3520 -10
============================================
Files 1695 909 -786
Lines 35839 22535 -13304
Branches 3958 2186 -1772
============================================
- Hits 18439 12100 -6339
+ Misses 16462 9452 -7010
- Partials 938 983 +45
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1184 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...9f3224e](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (763c807) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `0.08%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 51.50% +0.08%
+ Complexity 3522 2788 -734
============================================
Files 1693 764 -929
Lines 35832 19162 -16670
Branches 3958 1804 -2154
============================================
- Hits 18425 9869 -8556
+ Misses 16467 8569 -7898
+ Partials 940 724 -216
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1250 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...4ba7244](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (7659c5a) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **increase** coverage by `2.11%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.41% 53.52% +2.11%
+ Complexity 3516 3502 -14
============================================
Files 1693 907 -786
Lines 35811 22493 -13318
Branches 3960 2187 -1773
============================================
- Hits 18412 12040 -6372
+ Misses 16459 9472 -6987
- Partials 940 981 +41
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1184 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...7659c5a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4fa1eb2) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `2.46%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 53.88% +2.46%
- Complexity 3522 3531 +9
============================================
Files 1693 907 -786
Lines 35832 22492 -13340
Branches 3958 2187 -1771
============================================
- Hits 18425 12120 -6305
+ Misses 16467 9396 -7071
- Partials 940 976 +36
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1184 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...763c807](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-752488292
I am thinking about the name. As the control panel is actually for the services of Istio components, but the data panel is the sidecar metrics, which included all meshed service.
Do you think providing 2 separated level 1 dashboard called `Istio` and `Istio Sidecars` makes more sense? In this case, we could provide another group name for those sidecar's services/instances.
@hanahmily What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (d44af04) into [master](https://codecov.io/gh/apache/skywalking/commit/1f012463a21b4274a2c633a1515f91b57174fc4b?el=desc) (1f01246) will **decrease** coverage by `0.11%`.
> The diff coverage is `32.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.41% 51.30% -0.12%
+ Complexity 3517 3504 -13
============================================
Files 1692 1692
Lines 35802 35814 +12
Branches 3959 3958 -1
============================================
- Hits 18408 18374 -34
- Misses 16457 16499 +42
- Partials 937 941 +4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `21.87% <25.00%> (+9.71%)` | `3.00 <2.00> (+1.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.00% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/source/EnvoyInstanceMetric.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Vudm95SW5zdGFuY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| ... and [12 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1f01246...d44af04](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (cfbf5b3) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `1.39%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.42% 50.02% -1.40%
+ Complexity 3522 2726 -796
============================================
Files 1693 764 -929
Lines 35832 19162 -16670
Branches 3958 1804 -2154
============================================
- Hits 18425 9586 -8839
+ Misses 16467 8868 -7599
+ Partials 940 708 -232
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1257 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...cfbf5b3](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-752831172
> Our solution is to persuade them to opt for ALS-based mesh relationship analysis instead of telemetry v2, or support the latter in the future? My preference is the second one, what's your thought?
I agree to support the latter in the future, if this works for you @wu-sheng , I can create an issue to track this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-752906069
For me, still `Data Panel` makes more sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (71b9ddd) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **increase** coverage by `1.43%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.44% 52.88% +1.43%
+ Complexity 3530 3480 -50
============================================
Files 1695 909 -786
Lines 35839 22535 -13304
Branches 3958 2186 -1772
============================================
- Hits 18439 11918 -6521
+ Misses 16462 9649 -6813
- Partials 938 968 +30
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1186 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...71b9ddd](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4fa1eb2) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `11.77%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.32% 39.54% -11.78%
+ Complexity 3505 2212 -1293
=============================================
Files 1693 747 -946
Lines 35811 18574 -17237
Branches 3960 1752 -2208
=============================================
- Hits 18381 7346 -11035
+ Misses 16490 10675 -5815
+ Partials 940 553 -387
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1305 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...14c8eaf](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4ba7244) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `0.60%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 52.02% +0.60%
+ Complexity 3522 3378 -144
============================================
Files 1693 890 -803
Lines 35832 22024 -13808
Branches 3958 2124 -1834
============================================
- Hits 18425 11458 -6967
+ Misses 16467 9622 -6845
- Partials 940 944 +4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1203 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...4ba7244](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (bfac6c1) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `11.79%`.
> The diff coverage is `41.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.43% 39.63% -11.80%
+ Complexity 3519 2214 -1305
=============================================
Files 1693 747 -946
Lines 35811 18574 -17237
Branches 3960 1752 -2208
=============================================
- Hits 18418 7362 -11056
+ Misses 16454 10655 -5799
+ Partials 939 557 -382
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.27% <22.22%> (-1.72%)` | `61.00 <2.00> (+1.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `2.00 <1.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1309 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...bfac6c1](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (6754a3d) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `0.51%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 51.93% +0.51%
+ Complexity 3522 3441 -81
============================================
Files 1693 907 -786
Lines 35832 22513 -13319
Branches 3958 2185 -1773
============================================
- Hits 18425 11692 -6733
+ Misses 16467 9854 -6613
- Partials 940 967 +27
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1190 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...6754a3d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#discussion_r550781015
##########
File path: .github/workflows/e2e.istio.yaml
##########
@@ -129,3 +129,93 @@ jobs:
- name: Clean up
if: ${{ always() }}
run: minikube delete
+
+ metrics-service:
+ runs-on: ubuntu-16.04
+ timeout-minutes: 60
+ name: MetricsService
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ submodules: true
+
+ - uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: ${{ runner.os }}-maven-
+
+ - name: Build Docker Image
+ run: make docker
+
+ - name: Prepare envrionment
+ run: bash ${SCRIPTS_DIR}/pre.sh
+
+ - name: Install Minikube
+ run: bash ${SCRIPTS_DIR}/minikube.sh start
+
+ - name: Install Istio
+ run: bash ${SCRIPTS_DIR}/istio.sh --set profile=demo --set meshConfig.defaultConfig.envoyMetricsService.address=skywalking-oap.istio-system:11800
Review comment:
I assume meta-exchange is default ON by today's Istio, right? I think we need to disable it manually?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (9f3224e) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **increase** coverage by `2.24%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.44% 53.69% +2.24%
+ Complexity 3530 3519 -11
============================================
Files 1695 909 -786
Lines 35839 22535 -13304
Branches 3958 2186 -1772
============================================
- Hits 18439 12100 -6339
+ Misses 16462 9452 -7010
- Partials 938 983 +45
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1184 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...9f3224e](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (8e40d6d) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `9.89%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.41% 41.52% -9.90%
+ Complexity 3516 2301 -1215
============================================
Files 1693 747 -946
Lines 35811 18612 -17199
Branches 3960 1758 -2202
============================================
- Hits 18412 7728 -10684
+ Misses 16459 10319 -6140
+ Partials 940 565 -375
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1298 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...8e40d6d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (7659c5a) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `15.43%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.41% 35.98% -15.44%
+ Complexity 3516 2025 -1491
=============================================
Files 1693 747 -946
Lines 35811 18556 -17255
Branches 3960 1751 -2209
=============================================
- Hits 18412 6677 -11735
+ Misses 16459 11365 -5094
+ Partials 940 514 -426
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1325 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...7659c5a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4b81577) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `21.55%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.41% 29.85% -21.56%
=============================================
Files 1693 1605 -88
Lines 35811 33422 -2389
Branches 3960 4416 +456
=============================================
- Hits 18412 9979 -8433
- Misses 16459 22523 +6064
+ Partials 940 920 -20
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `100.00% <ø> (+43.00%)` | `0.00 <0.00> (-60.00)` | :arrow_up: |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | `0.00 <0.00> (-8.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-12.17%)` | `0.00 <0.00> (-2.00)` | |
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/server/core/source/Source.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...che/skywalking/oap/server/core/source/Service.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/oap/server/core/source/SideCar.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NpZGVDYXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [748 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...7659c5a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (20aae26) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **increase** coverage by `2.20%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.44% 53.65% +2.20%
+ Complexity 3530 3515 -15
============================================
Files 1695 909 -786
Lines 35839 22535 -13304
Branches 3958 2186 -1772
============================================
- Hits 18439 12092 -6347
+ Misses 16462 9460 -7002
- Partials 938 983 +45
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1184 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...20aae26](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (14c8eaf) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `21.46%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.32% 29.85% -21.47%
=============================================
Files 1693 1605 -88
Lines 35811 33421 -2390
Branches 3960 4416 +456
=============================================
- Hits 18381 9979 -8402
- Misses 16490 22522 +6032
+ Partials 940 920 -20
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `100.00% <ø> (+43.00%)` | `0.00 <0.00> (-60.00)` | :arrow_up: |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | `0.00 <0.00> (-8.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-12.17%)` | `0.00 <0.00> (-2.00)` | |
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/server/core/source/Source.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...che/skywalking/oap/server/core/source/Service.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/oap/server/core/source/SideCar.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NpZGVDYXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [749 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...14c8eaf](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (9f3224e) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `10.95%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.44% 40.49% -10.96%
+ Complexity 3530 2310 -1220
=============================================
Files 1695 766 -929
Lines 35839 19131 -16708
Branches 3958 1803 -2155
=============================================
- Hits 18439 7747 -10692
+ Misses 16462 10811 -5651
+ Partials 938 573 -365
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1295 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...9f3224e](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4ba7244) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `0.07%`.
> The diff coverage is `31.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.42% 51.34% -0.08%
+ Complexity 3522 3511 -11
============================================
Files 1693 1693
Lines 35832 35843 +11
Branches 3958 3957 -1
============================================
- Hits 18425 18404 -21
- Misses 16467 16499 +32
Partials 940 940
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `21.87% <25.00%> (+9.71%)` | `3.00 <2.00> (+1.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.00% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/source/EnvoyInstanceMetric.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Vudm95SW5zdGFuY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-2.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/worker/TopNWorker.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5Xb3JrZXIuamF2YQ==) | `42.42% <0.00%> (-12.13%)` | `4.00% <0.00%> (-1.00%)` | |
| ... and [7 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...4ba7244](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4fa1eb2) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `13.66%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.32% 37.66% -13.67%
+ Complexity 3505 2097 -1408
=============================================
Files 1693 747 -946
Lines 35811 18565 -17246
Branches 3960 1752 -2208
=============================================
- Hits 18381 6993 -11388
+ Misses 16490 11051 -5439
+ Partials 940 521 -419
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1316 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...14c8eaf](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (20aae26) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `9.89%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.44% 41.55% -9.90%
+ Complexity 3530 2307 -1223
============================================
Files 1695 749 -946
Lines 35839 18650 -17189
Branches 3958 1757 -2201
============================================
- Hits 18439 7750 -10689
+ Misses 16462 10305 -6157
+ Partials 938 595 -343
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1304 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...20aae26](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (fd13101) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `2.80%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 48.52% -2.81%
+ Complexity 3504 3276 -228
============================================
Files 1693 907 -786
Lines 35808 22450 -13358
Branches 3956 2170 -1786
============================================
- Hits 18380 10893 -7487
+ Misses 16488 10630 -5858
+ Partials 940 927 -13
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1204 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (8e40d6d) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `1.65%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.41% 49.76% -1.66%
+ Complexity 3516 3263 -253
============================================
Files 1693 890 -803
Lines 35811 21999 -13812
Branches 3960 2140 -1820
============================================
- Hits 18412 10947 -7465
+ Misses 16459 10136 -6323
+ Partials 940 916 -24
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1211 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...8e40d6d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-752396319
> Istio / MetricsService (pull_request)
e2e fails. Could you give an update about latest screenshots?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (fd13101) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `14.73%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.32% 36.59% -14.74%
+ Complexity 3504 2064 -1440
=============================================
Files 1693 747 -946
Lines 35808 18575 -17233
Branches 3956 1741 -2215
=============================================
- Hits 18380 6797 -11583
+ Misses 16488 11257 -5231
+ Partials 940 521 -419
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1320 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (cfbf5b3) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `2.26%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 53.68% +2.26%
- Complexity 3522 3532 +10
============================================
Files 1693 911 -782
Lines 35832 22578 -13254
Branches 3958 2193 -1765
============================================
- Hits 18425 12120 -6305
+ Misses 16467 9462 -7005
- Partials 940 996 +56
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1182 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...cfbf5b3](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (0fab4e4) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `20.28%`.
> The diff coverage is `19.56%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.42% 31.13% -20.29%
+ Complexity 3522 1784 -1738
=============================================
Files 1693 747 -946
Lines 35832 18428 -17404
Branches 3958 1704 -2254
=============================================
- Hits 18425 5737 -12688
+ Misses 16467 12286 -4181
+ Partials 940 405 -535
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `5.55% <0.00%> (-84.59%)` | `2.00 <0.00> (-18.00)` | |
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `24.62% <11.11%> (-32.38%)` | `25.00 <1.00> (-35.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1345 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...0fab4e4](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (75e552d) into [master](https://codecov.io/gh/apache/skywalking/commit/1b1f08511ccb8542d96f29dcaee72c73492b74f9?el=desc) (1b1f085) will **increase** coverage by `0.86%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 52.86% 53.73% +0.86%
- Complexity 3472 3520 +48
============================================
Files 907 907
Lines 22484 22513 +29
Branches 2183 2185 +2
============================================
+ Hits 11887 12097 +210
+ Misses 9614 9436 -178
+ Partials 983 980 -3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+3.33%)` | `3.00 <2.00> (+1.00)` | |
| [...ng/oap/server/core/source/EnvoyInstanceMetric.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Vudm95SW5zdGFuY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-2.00%)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `73.56% <0.00%> (-3.45%)` | `28.00% <0.00%> (-2.00%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| ... and [31 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1b1f085...75e552d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (cfbf5b3) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `8.23%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.42% 43.18% -8.24%
+ Complexity 3522 2472 -1050
============================================
Files 1693 764 -929
Lines 35832 19109 -16723
Branches 3958 1802 -2156
============================================
- Hits 18425 8253 -10172
+ Misses 16467 10241 -6226
+ Partials 940 615 -325
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1282 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...cfbf5b3](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (54efea6) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `11.41%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.44% 40.02% -11.42%
+ Complexity 3527 2283 -1244
=============================================
Files 1695 766 -929
Lines 35839 19091 -16748
Branches 3958 1797 -2161
=============================================
- Hits 18437 7642 -10795
+ Misses 16462 10891 -5571
+ Partials 940 558 -382
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `95.00% <100.00%> (-0.84%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1294 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...54efea6](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (75e552d) into [master](https://codecov.io/gh/apache/skywalking/commit/1b1f08511ccb8542d96f29dcaee72c73492b74f9?el=desc) (1b1f085) will **increase** coverage by `0.86%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 52.86% 53.73% +0.86%
- Complexity 3472 3520 +48
============================================
Files 907 907
Lines 22484 22513 +29
Branches 2183 2185 +2
============================================
+ Hits 11887 12097 +210
+ Misses 9614 9436 -178
+ Partials 983 980 -3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+3.33%)` | `3.00 <2.00> (+1.00)` | |
| [...ng/oap/server/core/source/EnvoyInstanceMetric.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Vudm95SW5zdGFuY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-2.00%)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `73.56% <0.00%> (-3.45%)` | `28.00% <0.00%> (-2.00%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| ... and [31 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1b1f085...75e552d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (0fab4e4) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `2.15%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 53.57% +2.15%
+ Complexity 3522 3511 -11
============================================
Files 1693 907 -786
Lines 35832 22513 -13319
Branches 3958 2185 -1773
============================================
- Hits 18425 12062 -6363
+ Misses 16467 9467 -7000
- Partials 940 984 +44
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1185 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...0fab4e4](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (8e40d6d) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `6.52%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.41% 44.88% -6.53%
+ Complexity 3516 2453 -1063
============================================
Files 1693 747 -946
Lines 35811 18612 -17199
Branches 3960 1758 -2202
============================================
- Hits 18412 8354 -10058
+ Misses 16459 9629 -6830
+ Partials 940 629 -311
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1287 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...8e40d6d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (c79305a) into [master](https://codecov.io/gh/apache/skywalking/commit/209a3bd044d24bbce9beadc39f6b9c58f58db4ef?el=desc) (209a3bd) will **decrease** coverage by `19.53%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 49.38% 29.85% -19.54%
=============================================
Files 907 1605 +698
Lines 22436 33421 +10985
Branches 2180 4416 +2236
=============================================
- Hits 11081 9977 -1104
- Misses 10421 22523 +12102
+ Partials 934 921 -13
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `100.00% <ø> (+43.22%)` | `0.00 <0.00> (-60.00)` | :arrow_up: |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | `0.00 <0.00> (-8.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-90.00%)` | `0.00 <0.00> (-2.00)` | |
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/server/core/source/Source.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...che/skywalking/oap/server/core/source/Service.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/oap/server/core/source/SideCar.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NpZGVDYXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1599 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (8e40d6d) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `6.41%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.41% 44.99% -6.42%
+ Complexity 3516 2461 -1055
============================================
Files 1693 747 -946
Lines 35811 18612 -17199
Branches 3960 1758 -2202
============================================
- Hits 18412 8375 -10037
+ Misses 16459 9607 -6852
+ Partials 940 630 -310
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1286 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...8e40d6d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4fa1eb2) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **increase** coverage by `2.55%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.32% 53.88% +2.55%
- Complexity 3505 3531 +26
============================================
Files 1693 907 -786
Lines 35811 22492 -13319
Branches 3960 2187 -1773
============================================
- Hits 18381 12120 -6261
+ Misses 16490 9396 -7094
- Partials 940 976 +36
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1185 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...14c8eaf](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4ba7244) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `2.38%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.42% 49.03% -2.39%
+ Complexity 3522 3209 -313
============================================
Files 1693 890 -803
Lines 35832 22004 -13828
Branches 3958 2122 -1836
============================================
- Hits 18425 10789 -7636
+ Misses 16467 10317 -6150
+ Partials 940 898 -42
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1218 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...4ba7244](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (b966295) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `4.73%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 46.58% -4.74%
+ Complexity 3505 2517 -988
============================================
Files 1693 747 -946
Lines 35811 18642 -17169
Branches 3960 1746 -2214
============================================
- Hits 18381 8685 -9696
+ Misses 16490 9303 -7187
+ Partials 940 654 -286
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1279 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...02b5eb0](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (8e40d6d) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `20.22%`.
> The diff coverage is `21.27%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.41% 31.19% -20.23%
+ Complexity 3516 1784 -1732
=============================================
Files 1693 747 -946
Lines 35811 18409 -17402
Branches 3960 1706 -2254
=============================================
- Hits 18412 5742 -12670
+ Misses 16459 12262 -4197
+ Partials 940 405 -535
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `5.55% <0.00%> (-84.59%)` | `2.00 <0.00> (-18.00)` | |
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `24.62% <11.11%> (-32.38%)` | `25.00 <1.00> (-35.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1344 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...8e40d6d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (fd13101) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `11.57%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.32% 39.75% -11.58%
+ Complexity 3504 2217 -1287
=============================================
Files 1693 747 -946
Lines 35808 18600 -17208
Branches 3956 1743 -2213
=============================================
- Hits 18380 7395 -10985
+ Misses 16488 10634 -5854
+ Partials 940 571 -369
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1307 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (7659c5a) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `0.83%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.41% 50.57% -0.84%
+ Complexity 3516 2760 -756
============================================
Files 1693 764 -929
Lines 35811 19142 -16669
Branches 3960 1806 -2154
============================================
- Hits 18412 9682 -8730
+ Misses 16459 8740 -7719
+ Partials 940 720 -220
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1252 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...7659c5a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (75e552d) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `0.02%`.
> The diff coverage is `31.25%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.44% 51.41% -0.03%
+ Complexity 3524 3520 -4
============================================
Files 1695 1693 -2
Lines 35839 35843 +4
Branches 3958 3957 -1
============================================
- Hits 18437 18430 -7
- Misses 16462 16474 +12
+ Partials 940 939 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `21.87% <25.00%> (+9.71%)` | `3.00 <2.00> (+1.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.00% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-2.09%)` | `8.00 <0.00> (ø)` | |
| [...ng/oap/server/core/source/EnvoyInstanceMetric.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0Vudm95SW5zdGFuY2VNZXRyaWMuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-2.00%)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `58.00% <0.00%> (-2.00%)` | `7.00% <0.00%> (ø%)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `91.95% <0.00%> (-1.15%)` | `28.00% <0.00%> (-2.00%)` | |
| ... and [9 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...54efea6](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (8e40d6d) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `12.79%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.41% 38.62% -12.80%
+ Complexity 3516 2143 -1373
=============================================
Files 1693 747 -946
Lines 35811 18578 -17233
Branches 3960 1752 -2208
=============================================
- Hits 18412 7175 -11237
+ Misses 16459 10879 -5580
+ Partials 940 524 -416
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1310 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...8e40d6d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (cfbf5b3) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `15.38%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.42% 36.03% -15.39%
+ Complexity 3522 2034 -1488
=============================================
Files 1693 747 -946
Lines 35832 18575 -17257
Branches 3958 1749 -2209
=============================================
- Hits 18425 6694 -11731
+ Misses 16467 11366 -5101
+ Partials 940 515 -425
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1325 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...cfbf5b3](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#discussion_r549756754
##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -266,6 +266,7 @@ envoy-metric:
# to append the version number to the service name.
# Be careful, when using environment variables to pass this configuration, use single quotes(`''`) to avoid it being evaluated by the shell.
k8sServiceNameRule: ${K8S_SERVICE_NAME_RULE:"${service.metadata.name}"}
+ enabledMALRules: ${SW_ENVOY_METRIC_MAL_RULES:"envoy"}
Review comment:
What is this related to the #5853 ? Could you be more clear? That issue is asking for adding group for all services involved in the specific dashboard.
Such as envoy service should include a `group` name in name definition, then they wouldn't show up in other dashboard's service list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (9605d09) into [master](https://codecov.io/gh/apache/skywalking/commit/209a3bd044d24bbce9beadc39f6b9c58f58db4ef?el=desc) (209a3bd) will **decrease** coverage by `12.68%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 49.38% 36.70% -12.69%
+ Complexity 3273 2078 -1195
=============================================
Files 907 747 -160
Lines 22436 18532 -3904
Branches 2180 1735 -445
=============================================
- Hits 11081 6802 -4279
- Misses 10421 11207 +786
+ Partials 934 523 -411
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+3.33%)` | `3.00 <2.00> (+1.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [299 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (c79305a) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `21.57%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.43% 29.85% -21.58%
=============================================
Files 1693 1605 -88
Lines 35811 33421 -2390
Branches 3960 4416 +456
=============================================
- Hits 18418 9977 -8441
- Misses 16454 22523 +6069
+ Partials 939 921 -18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `100.00% <ø> (+43.00%)` | `0.00 <0.00> (-60.00)` | :arrow_up: |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | `0.00 <0.00> (-8.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-12.17%)` | `0.00 <0.00> (-2.00)` | |
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/server/core/source/Source.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...che/skywalking/oap/server/core/source/Service.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/oap/server/core/source/SideCar.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NpZGVDYXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [749 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...bfac6c1](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (8e40d6d) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **increase** coverage by `2.12%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.41% 53.53% +2.12%
+ Complexity 3516 3504 -12
============================================
Files 1693 907 -786
Lines 35811 22493 -13318
Branches 3960 2187 -1773
============================================
- Hits 18412 12042 -6370
+ Misses 16459 9476 -6983
- Partials 940 975 +35
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1184 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...8e40d6d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (7659c5a) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **increase** coverage by `2.17%`.
> The diff coverage is `44.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.41% 53.58% +2.17%
+ Complexity 3516 3508 -8
============================================
Files 1693 907 -786
Lines 35811 22493 -13318
Branches 3960 2187 -1773
============================================
- Hits 18412 12053 -6359
+ Misses 16459 9462 -6997
- Partials 940 978 +38
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `71.42% <100.00%> (+11.42%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1184 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...7659c5a](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (6da1cb4) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `7.62%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 43.70% -7.63%
+ Complexity 3504 2438 -1066
============================================
Files 1693 764 -929
Lines 35808 19047 -16761
Branches 3956 1784 -2172
============================================
- Hits 18380 8324 -10056
+ Misses 16488 10077 -6411
+ Partials 940 646 -294
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1282 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...fd13101](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (71b9ddd) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `4.61%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.44% 46.83% -4.62%
+ Complexity 3530 3156 -374
============================================
Files 1695 892 -803
Lines 35839 22004 -13835
Branches 3958 2138 -1820
============================================
- Hits 18439 10306 -8133
+ Misses 16462 10840 -5622
+ Partials 938 858 -80
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1223 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...71b9ddd](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4fa1eb2) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `0.37%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 50.95% -0.38%
+ Complexity 3505 2779 -726
============================================
Files 1693 764 -929
Lines 35811 19124 -16687
Branches 3960 1805 -2155
============================================
- Hits 18381 9745 -8636
+ Misses 16490 8656 -7834
+ Partials 940 723 -217
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1255 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...14c8eaf](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (f25ee23) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `21.57%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.43% 29.86% -21.58%
=============================================
Files 1693 1605 -88
Lines 35811 33422 -2389
Branches 3960 4416 +456
=============================================
- Hits 18418 9980 -8438
- Misses 16454 22520 +6066
+ Partials 939 922 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `100.00% <ø> (+43.00%)` | `0.00 <0.00> (-60.00)` | :arrow_up: |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | `0.00 <0.00> (-8.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-12.17%)` | `0.00 <0.00> (-2.00)` | |
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/server/core/source/Source.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...che/skywalking/oap/server/core/source/Service.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/oap/server/core/source/SideCar.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NpZGVDYXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [748 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...8e40d6d](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (0fab4e4) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **decrease** coverage by `15.44%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.42% 35.97% -15.45%
+ Complexity 3522 2035 -1487
=============================================
Files 1693 747 -946
Lines 35832 18584 -17248
Branches 3958 1749 -2209
=============================================
- Hits 18425 6685 -11740
+ Misses 16467 11384 -5083
+ Partials 940 515 -425
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1324 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...0fab4e4](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4fa1eb2) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `7.95%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 43.36% -7.96%
+ Complexity 3505 2409 -1096
============================================
Files 1693 747 -946
Lines 35811 18580 -17231
Branches 3960 1753 -2207
============================================
- Hits 18381 8058 -10323
+ Misses 16490 9920 -6570
+ Partials 940 602 -338
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1288 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...14c8eaf](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#discussion_r550777865
##########
File path: oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/MetricServiceGRPCHandler.java
##########
@@ -79,17 +93,15 @@ public void onNext(StreamMetricsMessage message) {
isFirst = false;
StreamMetricsMessage.Identifier identifier = message.getIdentifier();
Node node = identifier.getNode();
- if (node != null) {
- String nodeId = node.getId();
- if (!StringUtil.isEmpty(nodeId)) {
- serviceInstanceName = nodeId;
- }
- String cluster = node.getCluster();
- if (!StringUtil.isEmpty(cluster)) {
- serviceName = cluster;
- if (serviceInstanceName == null) {
- serviceInstanceName = serviceName;
- }
+ String nodeId = node.getId();
+ if (!StringUtil.isEmpty(nodeId)) {
+ serviceInstanceName = nodeId;
+ }
+ String cluster = node.getCluster();
+ if (!StringUtil.isEmpty(cluster)) {
+ serviceName = cluster;
+ if (serviceInstanceName == null) {
+ serviceInstanceName = serviceName;
Review comment:
The service names in metrics service have a service group prefix (`istio-dp::`) while those in ALS don't have, do we want to add service group in ALS as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (916e20a) into [master](https://codecov.io/gh/apache/skywalking/commit/1f012463a21b4274a2c633a1515f91b57174fc4b?el=desc) (1f01246) will **decrease** coverage by `21.58%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.41% 29.83% -21.59%
=============================================
Files 1692 1605 -87
Lines 35802 33425 -2377
Branches 3959 4414 +455
=============================================
- Hits 18408 9971 -8437
- Misses 16457 22534 +6077
+ Partials 937 920 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `100.00% <ø> (+43.00%)` | `0.00 <0.00> (-60.00)` | :arrow_up: |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | `0.00 <0.00> (-8.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-12.17%)` | `0.00 <0.00> (-2.00)` | |
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/server/core/source/Source.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...che/skywalking/oap/server/core/source/Service.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/oap/server/core/source/SideCar.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NpZGVDYXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [749 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1f01246...d44af04](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (f10ab5f) into [master](https://codecov.io/gh/apache/skywalking/commit/1b1f08511ccb8542d96f29dcaee72c73492b74f9?el=desc) (1b1f085) will **decrease** coverage by `7.19%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 52.86% 45.67% -7.20%
+ Complexity 3472 2544 -928
============================================
Files 907 764 -143
Lines 22484 19145 -3339
Branches 2183 1803 -380
============================================
- Hits 11887 8745 -3142
- Misses 9614 9732 +118
+ Partials 983 668 -315
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.00%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+3.33%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [218 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [1b1f085...f10ab5f](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (02b5eb0) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `2.74%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.32% 48.58% -2.75%
+ Complexity 3505 2657 -848
============================================
Files 1693 764 -929
Lines 35811 19093 -16718
Branches 3960 1800 -2160
============================================
- Hits 18381 9276 -9105
+ Misses 16490 9108 -7382
+ Partials 940 709 -231
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1266 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...02b5eb0](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4ba7244) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `1.04%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 52.46% +1.04%
+ Complexity 3522 3457 -65
============================================
Files 1693 907 -786
Lines 35832 22505 -13327
Branches 3958 2170 -1788
============================================
- Hits 18425 11808 -6617
+ Misses 16467 9742 -6725
- Partials 940 955 +15
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1189 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...4ba7244](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (28025de) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `21.61%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.44% 29.83% -21.62%
=============================================
Files 1695 1607 -88
Lines 35839 33439 -2400
Branches 3958 4411 +453
=============================================
- Hits 18439 9976 -8463
- Misses 16462 22542 +6080
+ Partials 938 921 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `100.00% <ø> (+43.00%)` | `0.00 <0.00> (-60.00)` | :arrow_up: |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-2.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-95.84%)` | `0.00 <0.00> (-8.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-12.17%)` | `0.00 <0.00> (-2.00)` | |
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/server/core/source/Source.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...che/skywalking/oap/server/core/source/Service.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/oap/server/core/source/SideCar.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NpZGVDYXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [749 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...71b9ddd](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (b966295) into [master](https://codecov.io/gh/apache/skywalking/commit/8aeabfd5a60bdf557f50484f1523dd78d87bf626?el=desc) (8aeabfd) will **decrease** coverage by `15.34%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.32% 35.97% -15.35%
+ Complexity 3505 2026 -1479
=============================================
Files 1693 747 -946
Lines 35811 18547 -17264
Branches 3960 1736 -2224
=============================================
- Hits 18381 6673 -11708
+ Misses 16490 11359 -5131
+ Partials 940 515 -425
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1323 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [8aeabfd...02b5eb0](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (bfac6c1) into [master](https://codecov.io/gh/apache/skywalking/commit/f4b739c26b6cbf8272abee8cadef13230de45358?el=desc) (f4b739c) will **decrease** coverage by `3.37%`.
> The diff coverage is `41.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
- Coverage 51.43% 48.05% -3.38%
+ Complexity 3519 2650 -869
============================================
Files 1693 764 -929
Lines 35811 19110 -16701
Branches 3960 1804 -2156
============================================
- Hits 18418 9184 -9234
+ Misses 16454 9239 -7215
+ Partials 939 687 -252
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.27% <22.22%> (-1.72%)` | `61.00 <2.00> (+1.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `2.00 <1.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1263 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [f4b739c...bfac6c1](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-752566365
> And for isito data plane, do we intend to show relationship metrics between mesh services?
@hanahmily I think we had already, isn't it? Through ALS. I am thinking this new dashboard is an attachment, which provide the additional sidecar's metrics
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (9f3224e) into [master](https://codecov.io/gh/apache/skywalking/commit/61011635135cfe777370db59f0988d5a3c546dd2?el=desc) (6101163) will **decrease** coverage by `23.35%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
=============================================
- Coverage 51.44% 28.09% -23.36%
+ Complexity 3530 1646 -1884
=============================================
Files 1695 748 -947
Lines 35839 18530 -17309
Branches 3958 1731 -2227
=============================================
- Hits 18439 5206 -13233
+ Misses 16462 12932 -3530
+ Partials 938 392 -546
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.63% <19.04%> (-4.37%)` | `62.00 <4.00> (+2.00)` | :arrow_down: |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.00% <66.66%> (-7.84%)` | `8.00 <2.00> (ø)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1381 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6101163...9f3224e](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (4ba7244) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `2.17%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 53.59% +2.17%
+ Complexity 3522 3511 -11
============================================
Files 1693 907 -786
Lines 35832 22513 -13319
Branches 3958 2185 -1773
============================================
- Hits 18425 12065 -6360
+ Misses 16467 9466 -7001
- Partials 940 982 +42
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1184 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...4ba7244](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6091: Enhance Envoy metrics service analyzer by MAL
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6091:
URL: https://github.com/apache/skywalking/pull/6091#issuecomment-751628900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=h1) Report
> Merging [#6091](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=desc) (cfbf5b3) into [master](https://codecov.io/gh/apache/skywalking/commit/6e48dca99a5910e311169c2e91354ec55ddc4300?el=desc) (6e48dca) will **increase** coverage by `1.52%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6091 +/- ##
============================================
+ Coverage 51.42% 52.94% +1.52%
+ Complexity 3522 3491 -31
============================================
Files 1693 911 -782
Lines 35832 22578 -13254
Branches 3958 2193 -1765
============================================
- Hits 18425 11954 -6471
+ Misses 16467 9642 -6825
- Partials 940 982 +42
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/adapters/ProtoMetricFamily2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvbWV0cmljcy9hZGFwdGVycy9Qcm90b01ldHJpY0ZhbWlseTJNZXRyaWNzQWRhcHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.77% <33.33%> (-1.22%)` | `62.00 <3.00> (+2.00)` | :arrow_down: |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.27% <90.00%> (+0.13%)` | `21.00 <1.00> (+1.00)` | |
| [...rver/receiver/envoy/EnvoyMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlckNvbmZpZy5qYXZh) | `66.66% <100.00%> (+6.66%)` | `3.00 <1.00> (+1.00)` | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `93.75% <100.00%> (-1.25%)` | `8.00 <0.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `93.33% <100.00%> (+81.17%)` | `3.00 <2.00> (+1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1185 more](https://codecov.io/gh/apache/skywalking/pull/6091/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=footer). Last update [6e48dca...cfbf5b3](https://codecov.io/gh/apache/skywalking/pull/6091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org