You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/12/09 16:45:42 UTC

[GitHub] [hbase] pankaj72981 commented on a change in pull request #2756: HBASE-25378 Legacy comparator in Hfile trailer will fail to load

pankaj72981 commented on a change in pull request #2756:
URL: https://github.com/apache/hbase/pull/2756#discussion_r539468971



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java
##########
@@ -612,6 +612,8 @@ private String getHBase1CompatibleName(final String comparator) {
       comparatorKlass = CellComparatorImpl.class;
     } else if (comparatorClassName.equals(KeyValue.META_COMPARATOR.getLegacyKeyComparatorName())
       || comparatorClassName.equals(KeyValue.META_COMPARATOR.getClass().getName())
+      || (comparatorClassName.equals("org.apache.hadoop.hbase.CellComparator$MetaCellComparator"))      
+      || (comparatorClassName.equals("org.apache.hadoop.hbase.CellComparatorImpl$MetaCellComparator"))      

Review comment:
       Before HBASE-24968, MetaCellComparator.class.getName() was org.apache.hadoop.hbase.CellComparatorImpl$MetaCellComparator




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org