You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by IMS94 <gi...@git.apache.org> on 2016/12/15 07:29:05 UTC
[GitHub] curator pull request #177: [CURATOR-364] Persistent Node Constructor Require...
GitHub user IMS94 opened a pull request:
https://github.com/apache/curator/pull/177
[CURATOR-364] Persistent Node Constructor Requires a Started ZK Connection
I have moved the
```
createMode= useProtection ? client.create().creatingParentContainersIfNeeded().withProtection() : client.create().creatingParentContainersIfNeeded();
```
code segment to the **createNode()** method. Then, an exception will be raised only when you call the `start()` method of the PersistentNode without starting the client. This should be the expected behavior I guess?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/IMS94/curator CURATOR-364
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/177.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #177
----
commit a8a5d46cca4a6257d7f8edce9f3d21af3526847b
Author: Imesha <im...@gmail.com>
Date: 2016-11-29T09:54:37Z
Introduced hostname to InstanceSpec so that the TestingServer can be bound to other interfaces in a machine other than localhost (127.0.01)
commit 140342045e15876e610d5adee5eda5723d00f09d
Author: Imesha <im...@gmail.com>
Date: 2016-12-13T02:54:00Z
Merge branch 'master' of https://github.com/apache/curator
commit ea710f4ed62aed1a3a8f324280d1592a7c23b8e0
Author: Imesha <im...@gmail.com>
Date: 2016-12-15T07:18:15Z
CURATOR-364 - Moved createMode=client.create() segment to createNode() method
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator issue #177: [CURATOR-364] Persistent Node Constructor Requires a Sta...
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the issue:
https://github.com/apache/curator/pull/177
Note: after merging I noticed that the original PR breaks nodes with protection as the protection ID is stored in the create builder. https://github.com/apache/curator/commit/0b699a368bbb5f3c72ab609fa590bf225c2a2d7a fixes this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request #177: [CURATOR-364] Persistent Node Constructor Require...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/curator/pull/177
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator issue #177: [CURATOR-364] Persistent Node Constructor Requires a Sta...
Posted by ilyabiryukov-r7 <gi...@git.apache.org>.
Github user ilyabiryukov-r7 commented on the issue:
https://github.com/apache/curator/pull/177
Hey guys, are we ok to merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---