You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2021/01/25 22:43:06 UTC
[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16982
Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support
......................................................................
IMPALA-10404: Update docs to reflect RLE_DICTIONARY support
Fix references to PLAIN_DICTIONARY to reflect that
RLE_DICTIONARY is supported too.
Change-Id: Iee98abfd760396cf43302c9077c6165eb3623335
---
M docs/shared/impala_common.xml
M docs/topics/impala_parquet_dictionary_filtering.xml
2 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/16982/1
--
To view, visit http://gerrit.cloudera.org:8080/16982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee98abfd760396cf43302c9077c6165eb3623335
Gerrit-Change-Number: 16982
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16982 )
Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16982/1/docs/topics/impala_parquet_dictionary_filtering.xml
File docs/topics/impala_parquet_dictionary_filtering.xml:
http://gerrit.cloudera.org:8080/#/c/16982/1/docs/topics/impala_parquet_dictionary_filtering.xml@61
PS1, Line 61:
> nit: extra spaces
Done
--
To view, visit http://gerrit.cloudera.org:8080/16982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee98abfd760396cf43302c9077c6165eb3623335
Gerrit-Change-Number: 16982
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jan 2021 16:35:51 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support
Posted by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org>.
Shajini Thayasingh has posted comments on this change. ( http://gerrit.cloudera.org:8080/16982 )
Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/16982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee98abfd760396cf43302c9077c6165eb3623335
Gerrit-Change-Number: 16982
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jan 2021 19:14:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Shajini Thayasingh, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16982
to look at the new patch set (#2).
Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support
......................................................................
IMPALA-10404: Update docs to reflect RLE_DICTIONARY support
Fix references to PLAIN_DICTIONARY to reflect that
RLE_DICTIONARY is supported too.
Change-Id: Iee98abfd760396cf43302c9077c6165eb3623335
---
M docs/shared/impala_common.xml
M docs/topics/impala_parquet_dictionary_filtering.xml
2 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/16982/2
--
To view, visit http://gerrit.cloudera.org:8080/16982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee98abfd760396cf43302c9077c6165eb3623335
Gerrit-Change-Number: 16982
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16982 )
Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/618/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/16982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee98abfd760396cf43302c9077c6165eb3623335
Gerrit-Change-Number: 16982
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jan 2021 16:42:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16982 )
Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support
......................................................................
Patch Set 2: Code-Review+2
carry
--
To view, visit http://gerrit.cloudera.org:8080/16982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee98abfd760396cf43302c9077c6165eb3623335
Gerrit-Change-Number: 16982
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jan 2021 16:35:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16982 )
Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/618/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/16982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee98abfd760396cf43302c9077c6165eb3623335
Gerrit-Change-Number: 16982
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jan 2021 16:35:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16982 )
Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/617/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/16982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee98abfd760396cf43302c9077c6165eb3623335
Gerrit-Change-Number: 16982
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jan 2021 22:43:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16982 )
Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16982/1/docs/topics/impala_parquet_dictionary_filtering.xml
File docs/topics/impala_parquet_dictionary_filtering.xml:
http://gerrit.cloudera.org:8080/#/c/16982/1/docs/topics/impala_parquet_dictionary_filtering.xml@61
PS1, Line 61:
nit: extra spaces
--
To view, visit http://gerrit.cloudera.org:8080/16982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee98abfd760396cf43302c9077c6165eb3623335
Gerrit-Change-Number: 16982
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jan 2021 14:16:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16982 )
Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support
......................................................................
IMPALA-10404: Update docs to reflect RLE_DICTIONARY support
Fix references to PLAIN_DICTIONARY to reflect that
RLE_DICTIONARY is supported too.
Change-Id: Iee98abfd760396cf43302c9077c6165eb3623335
Reviewed-on: http://gerrit.cloudera.org:8080/16982
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/shared/impala_common.xml
M docs/topics/impala_parquet_dictionary_filtering.xml
2 files changed, 8 insertions(+), 5 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee98abfd760396cf43302c9077c6165eb3623335
Gerrit-Change-Number: 16982
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16982 )
Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/617/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/16982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee98abfd760396cf43302c9077c6165eb3623335
Gerrit-Change-Number: 16982
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jan 2021 22:50:18 +0000
Gerrit-HasComments: No