You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/18 01:45:29 UTC
[GitHub] [fineract] percyashu opened a new pull request #1083: FINERACT-822 Enforce SameNameButDifferent check
percyashu opened a new pull request #1083:
URL: https://github.com/apache/fineract/pull/1083
FINERACT-822
https://errorprone.info/bugpattern/SameNameButDifferent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1083: FINERACT-822 Enforce SameNameButDifferent check
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1083:
URL: https://github.com/apache/fineract/pull/1083#issuecomment-648690210
Ohh..Now there are conflicts.. Please @percyashu , will you be able to help me fix them? So sorry for giving you double work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] percyashu commented on pull request #1083: FINERACT-822 Enforce SameNameButDifferent check
Posted by GitBox <gi...@apache.org>.
percyashu commented on pull request #1083:
URL: https://github.com/apache/fineract/pull/1083#issuecomment-648730846
Ok will fix conflict
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1083: FINERACT-822 Enforce SameNameButDifferent check
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1083:
URL: https://github.com/apache/fineract/pull/1083#issuecomment-648689809
On second thought, lets reopen this and merge. When someone gets into the situation I had last year (which was in a private fork), then, they can always reverse this. Sorry for holding this PR. @percyashu .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] percyashu commented on pull request #1083: FINERACT-822 Enforce SameNameButDifferent check
Posted by GitBox <gi...@apache.org>.
percyashu commented on pull request #1083:
URL: https://github.com/apache/fineract/pull/1083#issuecomment-645778381
@awasum LGTY?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [GitHub] [fineract] awasum commented on pull request #1083:
FINERACT-822 Enforce SameNameButDifferent check
Posted by Percy Enoabane <pe...@gmail.com>.
No problem.
On Fri, Jun 19, 2020, 14:36 GitBox <gi...@apache.org> wrote:
>
> awasum commented on pull request #1083:
> URL: https://github.com/apache/fineract/pull/1083#issuecomment-646639803
>
>
> > I think we should leave this check disabled as it may mess with
> Swagger format especially when using it as a generator for API clients
> using something like Retrofit. I had an experience on another Fineract fork
> which when the names of classes are not very descriptive to the last
> details, one may get confused using these Swagger classes as a generator. I
> dont know if you understand me? @vorburger FYI. In addition, this is not a
> major problem.
>
> @percyashu did you want to do this?
>
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
>
[GitHub] [fineract] awasum commented on pull request #1083: FINERACT-822 Enforce SameNameButDifferent check
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1083:
URL: https://github.com/apache/fineract/pull/1083#issuecomment-646639803
> I think we should leave this check disabled as it may mess with Swagger format especially when using it as a generator for API clients using something like Retrofit. I had an experience on another Fineract fork which when the names of classes are not very descriptive to the last details, one may get confused using these Swagger classes as a generator. I dont know if you understand me? @vorburger FYI. In addition, this is not a major problem.
@percyashu did you want to do this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum closed pull request #1083: FINERACT-822 Enforce SameNameButDifferent check
Posted by GitBox <gi...@apache.org>.
awasum closed pull request #1083:
URL: https://github.com/apache/fineract/pull/1083
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1083: FINERACT-822 Enforce SameNameButDifferent check
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1083:
URL: https://github.com/apache/fineract/pull/1083#issuecomment-648572010
@vorburger Sorry no - I haven't looked into this check, so not sure how it will interact with Swagger. Given @awasum 's concern, perhaps we can first get Swagger to work (including generation of test clients) and then see if this makes sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1083: FINERACT-822 Enforce SameNameButDifferent check
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1083:
URL: https://github.com/apache/fineract/pull/1083#issuecomment-646881206
@ptuomola do you have any input/view re. this and Swagger? (Given your Swagger related PR, which BTW I'll review tomorrow.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1083: FINERACT-822 Enforce SameNameButDifferent check
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1083:
URL: https://github.com/apache/fineract/pull/1083#issuecomment-645850605
I think we should leave this check disabled as it may mess with Swagger format especially when using it as a generator for API clients using something like Retrofit. I had an experience on another Fineract fork which when the names of classes are not very descriptive to the last details, one may get confused using these Swagger classes as a generator. I dont know if you understand me? @vorburger FYI. In addition, this is not a major problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #1083: FINERACT-822 Enforce SameNameButDifferent check
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1083:
URL: https://github.com/apache/fineract/pull/1083
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org