You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/13 21:11:26 UTC
[GitHub] [incubator-superset] serenajiang opened a new pull request #8833:
[fix] nullable booleans in dataframe
serenajiang opened a new pull request #8833: [fix] nullable booleans in dataframe
URL: https://github.com/apache/incubator-superset/pull/8833
### CATEGORY
Choose one
- [X] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
The pandas `"bool"` dtype is not nullable, so null booleans were incorrectly displayed as `false` in sqllab.
e.g. `SELECT true UNION ALL (SELECT null);` ->
Mapping boolean to object type to support boolean + null.
### TEST PLAN
Ran the above query locally and confirmed it showed `null` instead of `false`.
### REVIEWERS
@etr2460 @graceguo-supercat
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org