You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2017/05/10 20:20:03 UTC
[GitHub] nifi pull request #1781: NIFI-3837: Being more specific with escaping of bac...
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1781
NIFI-3837: Being more specific with escaping of back references in ReplaceText
NIFI-3837:
- Being more specific regarding the escaping of back references in evaluated expressions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-3837
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1781.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1781
----
commit b5d6158304ee94493f69bc9ce20ce1c53173636b
Author: Matt Gilman <ma...@gmail.com>
Date: 2017-05-10T20:15:10Z
NIFI-3837:
- Being more specific regarding the escaping of back references in evaluated expressions.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1781: NIFI-3837: Being more specific with escaping of back refer...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1781
+1 LGTM, verified the unit test fails without the fix. Thanks much, merging to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1781: NIFI-3837: Being more specific with escaping of bac...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1781#discussion_r116141429
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ReplaceText.java ---
@@ -307,7 +307,7 @@ private static String escapeLiteralBackReferences(final String unescaped, final
}
String value = unescaped;
- final Matcher backRefMatcher = backReferencePattern.matcher(value);
+ final Matcher backRefMatcher = unescapedBackReferencePattern.matcher(value); // consider unscaped back references
--- End diff --
Minor typo in comment, will fix on merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1781: NIFI-3837: Being more specific with escaping of bac...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1781
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---