[jira] [Commented] (TEZ-1511) MROutputConfigBuilder sets OutputFormat as String class if OutputFormat is not provided

["Hitesh Shah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114131#comment-14114131 ] 

Hitesh Shah commented on TEZ-1511:
----------------------------------

The use of NEW_API_CONFIG seems incorrect. There should be 2 such fields - one for mapper and one for the reducer - as there seems to be a mix of both mapper.new-api and reducer.new-api being used ( though not sure if that is intended or a bug ).

For future reference, Configuration::getClassByName seems a better implementation than ReflectionUtils::getClazz. 


> MROutputConfigBuilder sets OutputFormat as String class if OutputFormat is not provided
> ---------------------------------------------------------------------------------------
>
>                 Key: TEZ-1511
>                 URL: https://issues.apache.org/jira/browse/TEZ-1511
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Bikas Saha
>            Priority: Blocker
>         Attachments: TEZ-1511.1.patch, TEZ-1511.2.patch
>
>
> Code uses: 
> {code}
>           this.outputFormat = ReflectionUtils.getClass(conf.get(MRJobConfig.OUTPUT_FORMAT_CLASS_ATTR));
>         } else {
>           this.outputFormat = ReflectionUtils.getClass(conf.get("mapred.output.format.class"));
> {code}
> where ReflectionUtils has :
> {code}
> <T> Class<T> getClass(T o)
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)