You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2017/08/15 19:29:38 UTC
Review Request 61671: GEODE-3328: fix
testAddGemFirePropertyFileToCommandLineNew on Windows
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61671/
-----------------------------------------------------------
Review request for geode, Jinmei Liao, Jared Stewart, and Ken Howe.
Bugs: GEODE-3328
https://issues.apache.org/jira/browse/GEODE-3328
Repository: geode
Description
-------
I had to temporarily revert Jinmei's fix for GEODE-3328 in order to fully revert Emily's refactorings of GFSH commands. This commit reintroduces her fix with minor tweak to get it to work without Emily's changes.
Diffs
-----
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GfshCommandJUnitTest.java da60c7aa481954be0acc8c7e2b88717cf8bc9c37
Diff: https://reviews.apache.org/r/61671/diff/1/
Testing
-------
precheckin in progress
Thanks,
Kirk Lund
Re: Review Request 61671: GEODE-3328: fix
testAddGemFirePropertyFileToCommandLineNew on Windows
Posted by Kirk Lund <ki...@gmail.com>.
> On Aug. 15, 2017, 9:38 p.m., Ken Howe wrote:
> > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GfshCommandJUnitTest.java
> > Line 411 (original), 411 (patched)
> > <https://reviews.apache.org/r/61671/diff/1/?file=1798156#file1798156line411>
> >
> > Why was this test renamed? Not really a problem but on the surface looks unneeded.
Oops that was caused by me have both versions of the test in the class briefly. I'll remove "New"
- Kirk
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61671/#review182999
-----------------------------------------------------------
On Aug. 15, 2017, 7:29 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61671/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 7:29 p.m.)
>
>
> Review request for geode, Jinmei Liao, Jared Stewart, and Ken Howe.
>
>
> Bugs: GEODE-3328
> https://issues.apache.org/jira/browse/GEODE-3328
>
>
> Repository: geode
>
>
> Description
> -------
>
> I had to temporarily revert Jinmei's fix for GEODE-3328 in order to fully revert Emily's refactorings of GFSH commands. This commit reintroduces her fix with minor tweak to get it to work without Emily's changes.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GfshCommandJUnitTest.java da60c7aa481954be0acc8c7e2b88717cf8bc9c37
>
>
> Diff: https://reviews.apache.org/r/61671/diff/1/
>
>
> Testing
> -------
>
> precheckin in progress
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 61671: GEODE-3328: fix
testAddGemFirePropertyFileToCommandLineNew on Windows
Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61671/#review182999
-----------------------------------------------------------
Ship it!
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GfshCommandJUnitTest.java
Line 411 (original), 411 (patched)
<https://reviews.apache.org/r/61671/#comment258982>
Why was this test renamed? Not really a problem but on the surface looks unneeded.
- Ken Howe
On Aug. 15, 2017, 7:29 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61671/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 7:29 p.m.)
>
>
> Review request for geode, Jinmei Liao, Jared Stewart, and Ken Howe.
>
>
> Bugs: GEODE-3328
> https://issues.apache.org/jira/browse/GEODE-3328
>
>
> Repository: geode
>
>
> Description
> -------
>
> I had to temporarily revert Jinmei's fix for GEODE-3328 in order to fully revert Emily's refactorings of GFSH commands. This commit reintroduces her fix with minor tweak to get it to work without Emily's changes.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GfshCommandJUnitTest.java da60c7aa481954be0acc8c7e2b88717cf8bc9c37
>
>
> Diff: https://reviews.apache.org/r/61671/diff/1/
>
>
> Testing
> -------
>
> precheckin in progress
>
>
> Thanks,
>
> Kirk Lund
>
>