You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/04/16 08:09:41 UTC
[GitHub] wu-sheng opened a new pull request #1081: Refactor ServerTypeDefine
and ComponentsDefine to be more extendable
wu-sheng opened a new pull request #1081: Refactor ServerTypeDefine and ComponentsDefine to be more extendable
URL: https://github.com/apache/incubator-skywalking/pull/1081
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve performance
- Related issues
#1078
___
### New feature or improvement
- Describe the details and related test reports.
I refactor the ServerTypeDefine and ComponentsDefine to `component-libraries.yml` file with two sections in it:
1. Component Section
2. Component Server Mapping Section
Id should be unique, every other language agent or SDK should submit your component to here, to change these manually. Of source, we only accept open source frameworks or online services.
I add a service `IComponentLibraryCatalogService` in configuration module provider, to read component id, component name and component server id.
Other thing in this proposal is a bug. When component name should be used if component id is 0(means null).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services