You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "daylicron (via GitHub)" <gi...@apache.org> on 2023/07/28 15:15:06 UTC
[GitHub] [solr] daylicron opened a new pull request, #1811: SOLR-16905: fix(java security policy): allow access to configured value of allowPaths
daylicron opened a new pull request, #1811:
URL: https://github.com/apache/solr/pull/1811
* SOLR-16905: Java Security Manager rules don't inclue "solr.allowPaths" property
# Description
Since solr 9 java security policy is enabled by default. When you configure the allowPaths property, acces will be denied by java security policy.
# Solution
To grant acces this creates a policy for that.
Additionally my IDE deletes Spaces of empty lines, thats why there are changes on multiple lines.
# Tests
Unfortunately I don't know how to write tests for this
# Checklist
Please review the following and check all that apply:
- [/] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [/] I have created a Jira issue and added the issue ID to my pull request title.
- [/] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [/] I have developed this patch against the `main` branch.
- [/] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [/] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1811: SOLR-16905: fix(java security policy): allow access to configured value of allowPaths
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on PR #1811:
URL: https://github.com/apache/solr/pull/1811#issuecomment-1655935475
I added an integration test, which fails on `main` and passes on this PR. So I think this is good to go!
Thanks for finding this and making a fix 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman merged pull request #1811: SOLR-16905: fix(java security policy): allow access to configured value of allowPaths
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman merged PR #1811:
URL: https://github.com/apache/solr/pull/1811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org