You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Yu Kobayashi (JIRA)" <ji...@apache.org> on 2008/04/11 07:48:04 UTC

[jira] Created: (EMAIL-75) Email.setFrom, addTo should use Email.charset

Email.setFrom, addTo should use Email.charset
---------------------------------------------

                 Key: EMAIL-75
                 URL: https://issues.apache.org/jira/browse/EMAIL-75
             Project: Commons Email
          Issue Type: Bug
    Affects Versions: 1.1
            Reporter: Yu Kobayashi
            Priority: Minor


Email.addTo() and setFrom() doesn't use Email.charset.

Code should be as following.

    public Email setFrom(String email, String name)
        throws EmailException
    {
        return setFrom(email, name, this.charset);
    }

    public Email addTo(String email, String name)
        throws EmailException
    {
        return addTo(email, name, this.charset);
    }


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (EMAIL-75) Email.setFrom, addTo should use Email.charset

Posted by "Yu Kobayashi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/EMAIL-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588357#action_12588357 ] 

yukoba edited comment on EMAIL-75 at 4/12/08 9:02 PM:
------------------------------------------------------------

I created a patch for this issue.


      was (Author: yukoba):
    Patch for this issue.

  
> Email.setFrom, addTo should use Email.charset
> ---------------------------------------------
>
>                 Key: EMAIL-75
>                 URL: https://issues.apache.org/jira/browse/EMAIL-75
>             Project: Commons Email
>          Issue Type: Bug
>    Affects Versions: 1.1
>            Reporter: Yu Kobayashi
>            Priority: Minor
>         Attachments: EmailCharset.patch
>
>
> Email.addTo() and setFrom() doesn't use Email.charset.
> Code should be as following.
> public Email setFrom(String email, String name)
>     throws EmailException
> {
>     return setFrom(email, name, this.charset);
> }
> public Email addTo(String email, String name)
>     throws EmailException
> {
>     return addTo(email, name, this.charset);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (EMAIL-75) Email.setFrom, addTo should use Email.charset

Posted by "Ben Speakmon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/EMAIL-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587877#action_12587877 ] 

Ben Speakmon commented on EMAIL-75:
-----------------------------------

Agree. Can you provide a patch against the trunk?

> Email.setFrom, addTo should use Email.charset
> ---------------------------------------------
>
>                 Key: EMAIL-75
>                 URL: https://issues.apache.org/jira/browse/EMAIL-75
>             Project: Commons Email
>          Issue Type: Bug
>    Affects Versions: 1.1
>            Reporter: Yu Kobayashi
>            Priority: Minor
>
> Email.addTo() and setFrom() doesn't use Email.charset.
> Code should be as following.
> public Email setFrom(String email, String name)
>     throws EmailException
> {
>     return setFrom(email, name, this.charset);
> }
> public Email addTo(String email, String name)
>     throws EmailException
> {
>     return addTo(email, name, this.charset);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (EMAIL-75) Email.setFrom, addTo should use Email.charset

Posted by "Yu Kobayashi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/EMAIL-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yu Kobayashi updated EMAIL-75:
------------------------------

    Attachment: EmailCharset.patch

Patch for this issue.


> Email.setFrom, addTo should use Email.charset
> ---------------------------------------------
>
>                 Key: EMAIL-75
>                 URL: https://issues.apache.org/jira/browse/EMAIL-75
>             Project: Commons Email
>          Issue Type: Bug
>    Affects Versions: 1.1
>            Reporter: Yu Kobayashi
>            Priority: Minor
>         Attachments: EmailCharset.patch
>
>
> Email.addTo() and setFrom() doesn't use Email.charset.
> Code should be as following.
> public Email setFrom(String email, String name)
>     throws EmailException
> {
>     return setFrom(email, name, this.charset);
> }
> public Email addTo(String email, String name)
>     throws EmailException
> {
>     return addTo(email, name, this.charset);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (EMAIL-75) Email.setFrom, addTo should use Email.charset

Posted by "Yu Kobayashi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/EMAIL-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yu Kobayashi updated EMAIL-75:
------------------------------

    Description: 
Email.addTo() and setFrom() doesn't use Email.charset.

Code should be as following.

public Email setFrom(String email, String name)
    throws EmailException
{
    return setFrom(email, name, this.charset);
}

public Email addTo(String email, String name)
    throws EmailException
{
    return addTo(email, name, this.charset);
}


  was:
Email.addTo() and setFrom() doesn't use Email.charset.

Code should be as following.

    public Email setFrom(String email, String name)
        throws EmailException
    {
        return setFrom(email, name, this.charset);
    }

    public Email addTo(String email, String name)
        throws EmailException
    {
        return addTo(email, name, this.charset);
    }



> Email.setFrom, addTo should use Email.charset
> ---------------------------------------------
>
>                 Key: EMAIL-75
>                 URL: https://issues.apache.org/jira/browse/EMAIL-75
>             Project: Commons Email
>          Issue Type: Bug
>    Affects Versions: 1.1
>            Reporter: Yu Kobayashi
>            Priority: Minor
>
> Email.addTo() and setFrom() doesn't use Email.charset.
> Code should be as following.
> public Email setFrom(String email, String name)
>     throws EmailException
> {
>     return setFrom(email, name, this.charset);
> }
> public Email addTo(String email, String name)
>     throws EmailException
> {
>     return addTo(email, name, this.charset);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (EMAIL-75) Email.setFrom, addTo should use Email.charset

Posted by "Siegfried Goeschl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/EMAIL-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Siegfried Goeschl resolved EMAIL-75.
------------------------------------

    Resolution: Fixed

Will be part of the 1.2 release

> Email.setFrom, addTo should use Email.charset
> ---------------------------------------------
>
>                 Key: EMAIL-75
>                 URL: https://issues.apache.org/jira/browse/EMAIL-75
>             Project: Commons Email
>          Issue Type: Bug
>    Affects Versions: 1.1
>            Reporter: Yu Kobayashi
>            Assignee: Siegfried Goeschl
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: EmailCharset.patch
>
>
> Email.addTo() and setFrom() doesn't use Email.charset.
> Code should be as following.
> public Email setFrom(String email, String name)
>     throws EmailException
> {
>     return setFrom(email, name, this.charset);
> }
> public Email addTo(String email, String name)
>     throws EmailException
> {
>     return addTo(email, name, this.charset);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (EMAIL-75) Email.setFrom, addTo should use Email.charset

Posted by "Siegfried Goeschl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/EMAIL-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Siegfried Goeschl updated EMAIL-75:
-----------------------------------

    Fix Version/s: 1.2

> Email.setFrom, addTo should use Email.charset
> ---------------------------------------------
>
>                 Key: EMAIL-75
>                 URL: https://issues.apache.org/jira/browse/EMAIL-75
>             Project: Commons Email
>          Issue Type: Bug
>    Affects Versions: 1.1
>            Reporter: Yu Kobayashi
>            Assignee: Siegfried Goeschl
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: EmailCharset.patch
>
>
> Email.addTo() and setFrom() doesn't use Email.charset.
> Code should be as following.
> public Email setFrom(String email, String name)
>     throws EmailException
> {
>     return setFrom(email, name, this.charset);
> }
> public Email addTo(String email, String name)
>     throws EmailException
> {
>     return addTo(email, name, this.charset);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.