[GitHub] [beam] johnjcasey commented on a diff in pull request #22028: pulsar connector accepts auth params

[GitBox <gi...@apache.org>]

johnjcasey commented on code in PR #22028:
URL: https://github.com/apache/beam/pull/22028#discussion_r906363738


##########
sdks/java/io/pulsar/src/main/java/org/apache/beam/sdk/io/pulsar/ReadFromPulsarDoFn.java:
##########
@@ -53,18 +53,23 @@ public class ReadFromPulsarDoFn extends DoFn<PulsarSourceDescriptor, PulsarMessa
   private PulsarAdmin admin;
   private String clientUrl;
   private String adminUrl;
+  private String authPluginClassName;
+  private String authParameters;
 
   private final SerializableFunction<Message<byte[]>, Instant> extractOutputTimestampFn;
 
   public ReadFromPulsarDoFn(PulsarIO.Read transform) {
     this.extractOutputTimestampFn = transform.getExtractOutputTimestampFn();
     this.clientUrl = transform.getClientUrl();
     this.adminUrl = transform.getAdminUrl();
+    this.authPluginClassName = transform.getAuthPluginClassName();
+    this.authParameters = transform.getAuthParameters();
     this.pulsarClientSerializableFunction = transform.getPulsarClient();
   }
 
   // Open connection to Pulsar clients
   @Setup
+  // TODO add auth related

Review Comment:
   What is TODO here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org