You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "k-wall (via GitHub)" <gi...@apache.org> on 2026/02/04 13:27:15 UTC
[PR] fix: fix addParentPoms=true causes repositories to be ignored. [maven-dependency-plugin]
k-wall opened a new pull request, #1585:
URL: https://github.com/apache/maven-dependency-plugin/pull/1585
Draft fix for #1028.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Your pull request should address just one issue, without pulling in other changes.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
- [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [ ] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: fix addParentPoms=true causes repositories to be ignored. [maven-dependency-plugin]
Posted by "k-wall (via GitHub)" <gi...@apache.org>.
k-wall commented on code in PR #1585:
URL: https://github.com/apache/maven-dependency-plugin/pull/1585#discussion_r2764220728
##########
src/main/java/org/apache/maven/plugins/dependency/fromDependencies/AbstractDependencyFilterMojo.java:
##########
@@ -381,9 +381,13 @@ private MavenProject buildProjectFromArtifact(Artifact artifact) throws MojoExec
ProjectBuildingRequest buildingRequest =
new DefaultProjectBuildingRequest(session.getProjectBuildingRequest());
buildingRequest.setProcessPlugins(false);
+ if (getProject().getRemoteArtifactRepositories() != null
Review Comment:
Inspired by https://github.com/apache/maven-javadoc-plugin/blob/ace4fe073378474b53296bd8c7a3f4a3faa44e17/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L2364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: fix addParentPoms=true causes repositories to be ignored. [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #1585:
URL: https://github.com/apache/maven-dependency-plugin/pull/1585#issuecomment-4435023397
@k-wall thanks, I have rebased with current muster to trigger CI build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: fix addParentPoms=true causes repositories to be ignored. [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #1585:
URL: https://github.com/apache/maven-dependency-plugin/pull/1585#discussion_r3229982537
##########
src/main/java/org/apache/maven/plugins/dependency/fromDependencies/AbstractDependencyFilterMojo.java:
##########
@@ -381,9 +381,13 @@ private MavenProject buildProjectFromArtifact(Artifact artifact) throws MojoExec
ProjectBuildingRequest buildingRequest =
new DefaultProjectBuildingRequest(session.getProjectBuildingRequest());
buildingRequest.setProcessPlugins(false);
+ if (getProject().getRemoteArtifactRepositories() != null
+ && !getProject().getRemoteArtifactRepositories().isEmpty()) {
Review Comment:
also `getProject().getRemoteArtifactRepositories()` should never be empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: fix addParentPoms=true causes repositories to be ignored. [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #1585:
URL: https://github.com/apache/maven-dependency-plugin/pull/1585#discussion_r3229922534
##########
src/main/java/org/apache/maven/plugins/dependency/fromDependencies/AbstractDependencyFilterMojo.java:
##########
@@ -381,9 +381,13 @@ private MavenProject buildProjectFromArtifact(Artifact artifact) throws MojoExec
ProjectBuildingRequest buildingRequest =
new DefaultProjectBuildingRequest(session.getProjectBuildingRequest());
buildingRequest.setProcessPlugins(false);
+ if (getProject().getRemoteArtifactRepositories() != null
Review Comment:
`getProject().getRemoteArtifactRepositories()` it should be never null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: fix addParentPoms=true causes repositories to be ignored. [maven-dependency-plugin]
Posted by "k-wall (via GitHub)" <gi...@apache.org>.
k-wall commented on PR #1585:
URL: https://github.com/apache/maven-dependency-plugin/pull/1585#issuecomment-4498534322
I've added an IT and believe I have addressed the feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: fix addParentPoms=true causes repositories to be ignored. [maven-dependency-plugin]
Posted by "k-wall (via GitHub)" <gi...@apache.org>.
k-wall commented on PR #1585:
URL: https://github.com/apache/maven-dependency-plugin/pull/1585#issuecomment-3876275816
Anyone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: fix addParentPoms=true causes repositories to be ignored. [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #1585:
URL: https://github.com/apache/maven-dependency-plugin/pull/1585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: fix addParentPoms=true causes repositories to be ignored. [maven-dependency-plugin]
Posted by "k-wall (via GitHub)" <gi...@apache.org>.
k-wall commented on PR #1585:
URL: https://github.com/apache/maven-dependency-plugin/pull/1585#issuecomment-4486318023
Great, thanks for picking up. I'll see if I can add a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: fix addParentPoms=true causes repositories to be ignored. [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #1585:
URL: https://github.com/apache/maven-dependency-plugin/pull/1585#issuecomment-4486530387
> @k-wall thanks, I have rebased with current muster to trigger CI build
You can look at my coments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: fix addParentPoms=true causes repositories to be ignored. [maven-dependency-plugin]
Posted by "k-wall (via GitHub)" <gi...@apache.org>.
k-wall commented on PR #1585:
URL: https://github.com/apache/maven-dependency-plugin/pull/1585#issuecomment-4332875343
I would really like to see this issue resolved, would any commiter be able to comment please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org