You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/03/08 03:52:28 UTC
Review Request 65964: Updated the master's status update handler to
avoid unnecessary copying.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65964/
-----------------------------------------------------------
Review request for mesos and Meng Zhu.
Bugs: MESOS-8628
https://issues.apache.org/jira/browse/MESOS-8628
Repository: mesos
Description
-------
Previously, we took a copy in order to mutate the UUID within the
update if communicating with an agent prior to 0.26. We now no longer
need to copy the update.
Diffs
-----
src/master/master.hpp c9c8a968b6f56fe261ac9fe374e926a28d40fccb
src/master/master.cpp e666b664dd125317cda5d16285d444b9c21e1f35
Diff: https://reviews.apache.org/r/65964/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 65964: Updated the master's status update handler
to avoid unnecessary copying.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65964/#review198963
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On March 7, 2018, 7:52 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65964/
> -----------------------------------------------------------
>
> (Updated March 7, 2018, 7:52 p.m.)
>
>
> Review request for mesos and Meng Zhu.
>
>
> Bugs: MESOS-8628
> https://issues.apache.org/jira/browse/MESOS-8628
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, we took a copy in order to mutate the UUID within the
> update if communicating with an agent prior to 0.26. We now no longer
> need to copy the update.
>
>
> Diffs
> -----
>
> src/master/master.hpp c9c8a968b6f56fe261ac9fe374e926a28d40fccb
> src/master/master.cpp e666b664dd125317cda5d16285d444b9c21e1f35
>
>
> Diff: https://reviews.apache.org/r/65964/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>