You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/02/13 21:48:43 UTC

[GitHub] [arrow-rs] alamb commented on a diff in pull request #3713: Filter exact list prefix matches for MemoryStore and HttpStore (#3712)

alamb commented on code in PR #3713:
URL: https://github.com/apache/arrow-rs/pull/3713#discussion_r1105050629


##########
object_store/src/lib.rs:
##########
@@ -911,9 +911,27 @@ mod tests {
         let content_list = flatten_list_stream(storage, Some(&prefix)).await.unwrap();
         assert_eq!(content_list, &[location1.clone()]);
 
+        let result = storage.list_with_delimiter(Some(&prefix)).await.unwrap();
+        assert_eq!(result.objects.len(), 1);
+        assert_eq!(result.objects[0].location, location1);
+        assert_eq!(result.common_prefixes, &[]);
+
+        let content_list = flatten_list_stream(storage, Some(&location1))

Review Comment:
   ```suggestion
           // Listing an existing path (file) should return an empty list:
           // https://github.com/apache/arrow-rs/issues/3712
           let content_list = flatten_list_stream(storage, Some(&location1))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org