[GitHub] [incubator-hudi] n3nash commented on a change in pull request #618: fix Schema.parse to new Schema.Parser().parse

[GitBox <gi...@apache.org>]

n3nash commented on a change in pull request #618: fix Schema.parse to new Schema.Parser().parse
URL: https://github.com/apache/incubator-hudi/pull/618#discussion_r271980252
 
 

 ##########
 File path: hoodie-common/src/main/java/com/uber/hoodie/common/table/log/HoodieLogFormatVersion.java
 ##########
 @@ -80,18 +80,15 @@ public boolean hasHeader() {
 
   @Override
   public boolean hasFooter() {
-    switch (super.getVersion()) {
-      case DEFAULT_VERSION:
-        return false;
-      case 1:
-        return true;
-      default:
-        return false;
-    }
+    return hasLogFooterAndBlockLength();
 
 Review comment:
   Can you please limit a PR to a particular issue ? For example, you can just use this PR to change Schema.parse to new Schema.Parser(). The other changes could be part of another PR (which should have it's own meaning) but at the same time necessitating a change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services