[GitHub] [doris] yiguolei commented on a diff in pull request #10700: [improvement]pre-serialize aggregation keys

[GitBox <gi...@apache.org>]

yiguolei commented on code in PR #10700:
URL: https://github.com/apache/doris/pull/10700#discussion_r916669026


##########
be/src/vec/columns/column.h:
##########
@@ -246,6 +246,14 @@ class IColumn : public COW<IColumn> {
     /// Returns pointer to the position after the read data.
     virtual const char* deserialize_and_insert_from_arena(const char* pos) = 0;
 
+    virtual size_t get_max_row_byte_size() const { return 0; }

Review Comment:
   Add some comments for new method. Then other people could read the code more clearly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org