You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/30 09:01:25 UTC

[GitHub] [flink] JingsongLi commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…

JingsongLi commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#discussion_r361930479
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/conversion/HiveInspectors.java
 ##########
 @@ -146,9 +146,9 @@ public static HiveObjectConversion getConversion(ObjectInspector inspector, Logi
 			} else if (inspector instanceof TimestampObjectInspector) {
 
 Review comment:
   Should mark `HiveObjectConversion`:
   `@Nullable Object toHiveObject(@Nullable Object o);`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services