[dev] [jira] [Commented] (LIBCLOUD-247) dns drivers - update_record

["Tomaz Muraus (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LIBCLOUD-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474587#comment-13474587 ] 

Tomaz Muraus commented on LIBCLOUD-247:
---------------------------------------

Thanks for the report, I agree about both points:

1. We should rename 'type' to 'record_type'
2. All the if checks should do 'if record_type is not None' ...
                
> dns drivers - update_record
> ---------------------------
>
>                 Key: LIBCLOUD-247
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-247
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Core
>            Reporter: Dinesh Bhoopathy
>            Priority: Minor
>              Labels: dns
>
> I know its an edge case but say when we do update_record() and change the 'type' for the record
> and if it 'is' RecordType.A then the value for it is 0 and in all the dns drivers I see things like 'if type:' which will never be True isn't it ?
> and just fft isn't it a good practice not using keywords like 'type' . Guess we could've used something like record_type or zone_type ? or simply like pep says use 'single_trailing_underscore_:' http://www.python.org/dev/peps/pep-0008/ 
>  I guess we need to set those record type constants starting from 1 in RecordType class. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira