You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-dev@hadoop.apache.org by Jens Rabe <ra...@t-online.de> on 2015/02/08 16:37:50 UTC
Re: Hadoop-QA finds FindBugs issues in code I did not even touch
Hello,
today I witnessed something strange. Yesterday I submitted another patch for a small improvement, done against trunk, and Hadoop QA complained about the same 13 FindBugs issues. However, I examined another patch from another contributor, MAPREDUCE-6243, where the FindBugs test passes. What is the reason for this difference? Is this because MAPREDUCE-6243 was done against 2.6.0 and mine against trunk?
I would be glad if you could clarify this a little.
Thanks,
Jens
> Am 28.12.2014 um 08:43 schrieb Harsh J <ha...@cloudera.com>:
>
> We've upgraded the version of findbugs in use and are yet to clear the
> new found ones out. You can track the overall progress at
> https://issues.apache.org/jira/browse/HADOOP-10477. For the moment, so
> long as you're certain your changes didn't introduce anything within
> the findbugs results, please ignore them until HADOOP-10477 is
> entirely resolved.
>
> On Fri, Dec 26, 2014 at 2:51 AM, Jens Rabe <ra...@t-online.de> wrote:
>> Hello,
>>
>> I just submitted two small patches for MAPREDUCE-6155 and MAPREDUCE-6206. However, the automatic QA there states that my patches introduce 13 new FindBugs, but they occur in files I did not touch and that are not affected by my patches. A clear sign is that both patches, which are completely different, introduce the same set of new FindBugs issues. What can I do in that case?
>>
>> Thanks, and merry christmas,
>> Jens
>
>
>
> --
> Harsh J
Re: Hadoop-QA finds FindBugs issues in code I did not even touch
Posted by Jens Rabe <ra...@t-online.de>.
Hello Ted,
thanks for clarifying this,
Jens
> Am 08.02.2015 um 17:20 schrieb Ted Yu <yu...@gmail.com>:
>
> Looking under
> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5153/artifact/patchprocess/
> (for MAPREDUCE-6243), I only saw findbugs result for hadoop rumen module.
>
> For your JIRA, I found
> newPatchFindbugsWarningshadoop-mapreduce-client-core.html.
>
> The difference in number of findbugs warnings was due to difference in
> module being tested.
>
> Cheers
>
> On Sun, Feb 8, 2015 at 7:48 AM, Jens Rabe <ra...@t-online.de> wrote:
>
>> Hello Ted,
>>
>> it is HADOOP-11561. The FindBugs issues appear in files I did not touch.
>>
>> Thanks,
>> Jens
>>
>>
>>> Am 08.02.2015 um 16:45 schrieb Ted Yu <yu...@gmail.com>:
>>>
>>> MAPREDUCE-6243.002.patch
>>> <
>> http://issues.apache.org/jira/secure/attachment/12696496/MAPREDUCE-6243.002.patch
>>>
>>> was
>>> tested against trunk.
>>>
>>> Can you give us your JIRA number so that we can look at the 13 FindBugs
>>> warnings ?
>>>
>>> Cheers
>>>
>>> On Sun, Feb 8, 2015 at 7:37 AM, Jens Rabe <ra...@t-online.de> wrote:
>>>
>>>> Hello,
>>>>
>>>> today I witnessed something strange. Yesterday I submitted another patch
>>>> for a small improvement, done against trunk, and Hadoop QA complained
>> about
>>>> the same 13 FindBugs issues. However, I examined another patch from
>> another
>>>> contributor, MAPREDUCE-6243, where the FindBugs test passes. What is the
>>>> reason for this difference? Is this because MAPREDUCE-6243 was done
>> against
>>>> 2.6.0 and mine against trunk?
>>>> I would be glad if you could clarify this a little.
>>>>
>>>> Thanks,
>>>> Jens
>>>>
>>>>> Am 28.12.2014 um 08:43 schrieb Harsh J <ha...@cloudera.com>:
>>>>>
>>>>> We've upgraded the version of findbugs in use and are yet to clear the
>>>>> new found ones out. You can track the overall progress at
>>>>> https://issues.apache.org/jira/browse/HADOOP-10477. For the moment, so
>>>>> long as you're certain your changes didn't introduce anything within
>>>>> the findbugs results, please ignore them until HADOOP-10477 is
>>>>> entirely resolved.
>>>>>
>>>>> On Fri, Dec 26, 2014 at 2:51 AM, Jens Rabe <ra...@t-online.de>
>>>> wrote:
>>>>>> Hello,
>>>>>>
>>>>>> I just submitted two small patches for MAPREDUCE-6155 and
>>>> MAPREDUCE-6206. However, the automatic QA there states that my patches
>>>> introduce 13 new FindBugs, but they occur in files I did not touch and
>> that
>>>> are not affected by my patches. A clear sign is that both patches, which
>>>> are completely different, introduce the same set of new FindBugs issues.
>>>> What can I do in that case?
>>>>>>
>>>>>> Thanks, and merry christmas,
>>>>>> Jens
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Harsh J
>>>>
>>>>
>>
>>
Re: Hadoop-QA finds FindBugs issues in code I did not even touch
Posted by Ted Yu <yu...@gmail.com>.
Looking under
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5153/artifact/patchprocess/
(for MAPREDUCE-6243), I only saw findbugs result for hadoop rumen module.
For your JIRA, I found
newPatchFindbugsWarningshadoop-mapreduce-client-core.html.
The difference in number of findbugs warnings was due to difference in
module being tested.
Cheers
On Sun, Feb 8, 2015 at 7:48 AM, Jens Rabe <ra...@t-online.de> wrote:
> Hello Ted,
>
> it is HADOOP-11561. The FindBugs issues appear in files I did not touch.
>
> Thanks,
> Jens
>
>
> > Am 08.02.2015 um 16:45 schrieb Ted Yu <yu...@gmail.com>:
> >
> > MAPREDUCE-6243.002.patch
> > <
> http://issues.apache.org/jira/secure/attachment/12696496/MAPREDUCE-6243.002.patch
> >
> > was
> > tested against trunk.
> >
> > Can you give us your JIRA number so that we can look at the 13 FindBugs
> > warnings ?
> >
> > Cheers
> >
> > On Sun, Feb 8, 2015 at 7:37 AM, Jens Rabe <ra...@t-online.de> wrote:
> >
> >> Hello,
> >>
> >> today I witnessed something strange. Yesterday I submitted another patch
> >> for a small improvement, done against trunk, and Hadoop QA complained
> about
> >> the same 13 FindBugs issues. However, I examined another patch from
> another
> >> contributor, MAPREDUCE-6243, where the FindBugs test passes. What is the
> >> reason for this difference? Is this because MAPREDUCE-6243 was done
> against
> >> 2.6.0 and mine against trunk?
> >> I would be glad if you could clarify this a little.
> >>
> >> Thanks,
> >> Jens
> >>
> >>> Am 28.12.2014 um 08:43 schrieb Harsh J <ha...@cloudera.com>:
> >>>
> >>> We've upgraded the version of findbugs in use and are yet to clear the
> >>> new found ones out. You can track the overall progress at
> >>> https://issues.apache.org/jira/browse/HADOOP-10477. For the moment, so
> >>> long as you're certain your changes didn't introduce anything within
> >>> the findbugs results, please ignore them until HADOOP-10477 is
> >>> entirely resolved.
> >>>
> >>> On Fri, Dec 26, 2014 at 2:51 AM, Jens Rabe <ra...@t-online.de>
> >> wrote:
> >>>> Hello,
> >>>>
> >>>> I just submitted two small patches for MAPREDUCE-6155 and
> >> MAPREDUCE-6206. However, the automatic QA there states that my patches
> >> introduce 13 new FindBugs, but they occur in files I did not touch and
> that
> >> are not affected by my patches. A clear sign is that both patches, which
> >> are completely different, introduce the same set of new FindBugs issues.
> >> What can I do in that case?
> >>>>
> >>>> Thanks, and merry christmas,
> >>>> Jens
> >>>
> >>>
> >>>
> >>> --
> >>> Harsh J
> >>
> >>
>
>
Re: Hadoop-QA finds FindBugs issues in code I did not even touch
Posted by Jens Rabe <ra...@t-online.de>.
Hello Ted,
it is HADOOP-11561. The FindBugs issues appear in files I did not touch.
Thanks,
Jens
> Am 08.02.2015 um 16:45 schrieb Ted Yu <yu...@gmail.com>:
>
> MAPREDUCE-6243.002.patch
> <http://issues.apache.org/jira/secure/attachment/12696496/MAPREDUCE-6243.002.patch>
> was
> tested against trunk.
>
> Can you give us your JIRA number so that we can look at the 13 FindBugs
> warnings ?
>
> Cheers
>
> On Sun, Feb 8, 2015 at 7:37 AM, Jens Rabe <ra...@t-online.de> wrote:
>
>> Hello,
>>
>> today I witnessed something strange. Yesterday I submitted another patch
>> for a small improvement, done against trunk, and Hadoop QA complained about
>> the same 13 FindBugs issues. However, I examined another patch from another
>> contributor, MAPREDUCE-6243, where the FindBugs test passes. What is the
>> reason for this difference? Is this because MAPREDUCE-6243 was done against
>> 2.6.0 and mine against trunk?
>> I would be glad if you could clarify this a little.
>>
>> Thanks,
>> Jens
>>
>>> Am 28.12.2014 um 08:43 schrieb Harsh J <ha...@cloudera.com>:
>>>
>>> We've upgraded the version of findbugs in use and are yet to clear the
>>> new found ones out. You can track the overall progress at
>>> https://issues.apache.org/jira/browse/HADOOP-10477. For the moment, so
>>> long as you're certain your changes didn't introduce anything within
>>> the findbugs results, please ignore them until HADOOP-10477 is
>>> entirely resolved.
>>>
>>> On Fri, Dec 26, 2014 at 2:51 AM, Jens Rabe <ra...@t-online.de>
>> wrote:
>>>> Hello,
>>>>
>>>> I just submitted two small patches for MAPREDUCE-6155 and
>> MAPREDUCE-6206. However, the automatic QA there states that my patches
>> introduce 13 new FindBugs, but they occur in files I did not touch and that
>> are not affected by my patches. A clear sign is that both patches, which
>> are completely different, introduce the same set of new FindBugs issues.
>> What can I do in that case?
>>>>
>>>> Thanks, and merry christmas,
>>>> Jens
>>>
>>>
>>>
>>> --
>>> Harsh J
>>
>>
Re: Hadoop-QA finds FindBugs issues in code I did not even touch
Posted by Ted Yu <yu...@gmail.com>.
MAPREDUCE-6243.002.patch
<http://issues.apache.org/jira/secure/attachment/12696496/MAPREDUCE-6243.002.patch>
was
tested against trunk.
Can you give us your JIRA number so that we can look at the 13 FindBugs
warnings ?
Cheers
On Sun, Feb 8, 2015 at 7:37 AM, Jens Rabe <ra...@t-online.de> wrote:
> Hello,
>
> today I witnessed something strange. Yesterday I submitted another patch
> for a small improvement, done against trunk, and Hadoop QA complained about
> the same 13 FindBugs issues. However, I examined another patch from another
> contributor, MAPREDUCE-6243, where the FindBugs test passes. What is the
> reason for this difference? Is this because MAPREDUCE-6243 was done against
> 2.6.0 and mine against trunk?
> I would be glad if you could clarify this a little.
>
> Thanks,
> Jens
>
> > Am 28.12.2014 um 08:43 schrieb Harsh J <ha...@cloudera.com>:
> >
> > We've upgraded the version of findbugs in use and are yet to clear the
> > new found ones out. You can track the overall progress at
> > https://issues.apache.org/jira/browse/HADOOP-10477. For the moment, so
> > long as you're certain your changes didn't introduce anything within
> > the findbugs results, please ignore them until HADOOP-10477 is
> > entirely resolved.
> >
> > On Fri, Dec 26, 2014 at 2:51 AM, Jens Rabe <ra...@t-online.de>
> wrote:
> >> Hello,
> >>
> >> I just submitted two small patches for MAPREDUCE-6155 and
> MAPREDUCE-6206. However, the automatic QA there states that my patches
> introduce 13 new FindBugs, but they occur in files I did not touch and that
> are not affected by my patches. A clear sign is that both patches, which
> are completely different, introduce the same set of new FindBugs issues.
> What can I do in that case?
> >>
> >> Thanks, and merry christmas,
> >> Jens
> >
> >
> >
> > --
> > Harsh J
>
>