You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mime4j-dev@james.apache.org by "Ioan Eugen Stan (JIRA)" <mi...@james.apache.org> on 2012/09/21 10:37:07 UTC
[jira] [Commented] (MIME4J-217) DomainsList is not immutable as
stated in docs
[ https://issues.apache.org/jira/browse/MIME4J-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460351#comment-13460351 ]
Ioan Eugen Stan commented on MIME4J-217:
----------------------------------------
Got a fix online for review: https://github.com/ieugen/james-mime4j/commit/6685639e575a529a72af2c34e786f24e910d0cb1
I will commit in 72 hours if no objections.
> DomainsList is not immutable as stated in docs
> ----------------------------------------------
>
> Key: MIME4J-217
> URL: https://issues.apache.org/jira/browse/MIME4J-217
> Project: JAMES Mime4j
> Issue Type: Bug
> Components: dom
> Affects Versions: 0.5, 0.6, 0.6.1, 0.7, 0.7.1
> Reporter: Ioan Eugen Stan
> Assignee: Ioan Eugen Stan
>
> DomainList passes a java.util.List which can be modified from outside if you pass a reference to it and keep the reference.
> Test: https://github.com/ieugen/james-mime4j/commit/a2f72d0cd2c7f6544e220ba31ca805e684f45d1a
> We should always make a copy of the list inside the constructor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira