You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "fyf2016 (via GitHub)" <gi...@apache.org> on 2023/03/03 07:03:32 UTC
[GitHub] [dubbo-samples] fyf2016 opened a new pull request, #763: Refactor dubbo-samples-local
fyf2016 opened a new pull request, #763:
URL: https://github.com/apache/dubbo-samples/pull/763
- add dubbo-samples-local module refator code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] chickenlj commented on a diff in pull request #763: Refactor dubbo-samples-local
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on code in PR #763:
URL: https://github.com/apache/dubbo-samples/pull/763#discussion_r1126262265
##########
2-advanced/dubbo-samples-local/case-configuration.yml:
##########
@@ -17,8 +17,22 @@
# local call through injvm, start test container only
services:
- dubbo-samples-local-test:
+ local-provider:
Review Comment:
The test failed for lacking `zookeeper` configuration.
https://github.com/apache/dubbo-samples/blob/master/1-basic/dubbo-samples-spring-boot/case-configuration.yml#L18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] chickenlj commented on pull request #763: Refactor dubbo-samples-local
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on PR #763:
URL: https://github.com/apache/dubbo-samples/pull/763#issuecomment-1457361552
https://cn.dubbo.apache.org/zh-cn/overview/mannual/java-sdk/advanced-features-and-usage/service/local-call/
Please read this documentation to learn about how `local` feature works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] chickenlj commented on pull request #763: Refactor dubbo-samples-local
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on PR #763:
URL: https://github.com/apache/dubbo-samples/pull/763#issuecomment-1453195446
Please add ASF license for newly added files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] chickenlj commented on pull request #763: Refactor dubbo-samples-local
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on PR #763:
URL: https://github.com/apache/dubbo-samples/pull/763#issuecomment-1457363445
Instead of separating provider and consumer into different modules or processes like the other samples do, we should put provider and consumer in the same process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org