[GitHub] [netbeans] matthiasblaesing commented on issue #1411: build branding

[GitBox <gi...@apache.org>]

matthiasblaesing commented on issue #1411: build branding
URL: https://github.com/apache/netbeans/pull/1411#issuecomment-541199812
 
 
   I debugged and the build number is correctly exported (not-null). The regexp @oyarzun references is this:
   
   https://github.com/apache/netbeans/blob/master/platform/options.api/src/org/netbeans/modules/options/export/OptionsExportModel.java#L99
   
   It is used here:
   
   https://github.com/apache/netbeans/blob/master/platform/options.api/src/org/netbeans/modules/options/export/OptionsExportModel.java#L218
   
   And the reason for the null value is here:
   
   https://github.com/apache/netbeans/blob/master/platform/options.api/src/org/netbeans/modules/options/export/OptionsExportModel.java#L229
   
   TL;DR: The module assumes, that the build number always contains a date pattern.
   
   This is even tested:
   
   https://github.com/apache/netbeans/blob/master/platform/options.api/test/unit/src/org/netbeans/modules/options/export/OptionsExportModelTest.java#L345
   https://github.com/apache/netbeans/blob/master/platform/options.api/test/unit/src/org/netbeans/modules/options/export/OptionsExportModelTest.java#L362
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists